public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Schmidt, Adriaan" <adriaan.schmidt@siemens.com>
To: "Bezdeka, Florian" <florian.bezdeka@siemens.com>,
	"amikan@ilbers.de" <amikan@ilbers.de>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>,
	"jan.kiszka@siemens.com" <jan.kiszka@siemens.com>
Subject: RE: [PATCH] RECIPE-API-CHANGELOG: Fix typo
Date: Mon, 20 Jun 2022 14:22:12 +0000	[thread overview]
Message-ID: <AS4PR10MB531801874D9B9E5786A546FEEDB09@AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <0a8067bc224cc47d4ca321dbc1c49eb63491efc4.camel@siemens.com>

Bezdeka, Florian, Montag, 20. Juni 2022 16:03:
> On Mon, 2022-06-20 at 13:51 +0000, Bezdeka, Florian wrote:
> > On Mon, 2022-06-20 at 16:41 +0300, Anton Mikanovich wrote:
> > > 15.06.2022 19:22, Jan Kiszka wrote:
> > > > From: Jan Kiszka <jan.kiszka@siemens.com>
> > > >
> > > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > > > ---
> > > >   RECIPE-API-CHANGELOG.md | 2 +-
> > > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
> > > > index 2998824b..cd6e7565 100644
> > > > --- a/RECIPE-API-CHANGELOG.md
> > > > +++ b/RECIPE-API-CHANGELOG.md
> > > > @@ -362,7 +362,7 @@ Changes when using the built-in types:
> > > >       and so on.
> > > >     * Image types defined in IMAGE_FSTYPES can be suffixed with
> conversions.
> > > >       To get a compressed image, set IMAGE_FSTYPES to `wic.xz`,
> `ext4.gz`, etc.
> > > > -    That also means that the type of the previous `targz-img` is not
> `tar.gz`.
> > > > +    That also means that the type of the previous `targz-img` is now
> `tar.gz`.
> > > >     * Container types (previously CONTAINER_IMAGE_FORMATS) are now
> > > >       first class image types (oci, oci-archive, docker-archive,
> > > >       docker-daemon, containers-storage)
> > >
> > > Applied to next, thanks.
> >
> > That was one of my review commits to the patch series that "introduced"
> > the typo. I'm quite sure that there was a follow up version containing
> > that fix.
> >
> > So my question is: Are you sure that you merged the right version of
> > the patch series? There might be missing more now...
> 
> Something went wrong with v2. See [1]. It claimed to have the fix but
> actually did not. No further steps necessary.
> 
> Adriaan, it seems that something went wrong on your end when sending
> out v2.

Yes, I don't know what happened. I have the fix on a local branch,
but must have sent something else. But that typo was the only difference
between v1 and the intended v2.

Sorry about the confusion.
Adriaan

> [1] https://groups.google.com/g/isar-users/c/MGOLSTWd83s/m/ZZHO8zszBgAJ
> >
> > >
> >


      parent reply	other threads:[~2022-06-20 14:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-15 16:22 Jan Kiszka
2022-06-20 13:41 ` Anton Mikanovich
2022-06-20 13:51   ` Bezdeka, Florian
2022-06-20 14:03     ` Bezdeka, Florian
2022-06-20 14:05       ` Anton Mikanovich
2022-06-20 14:22       ` Schmidt, Adriaan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS4PR10MB531801874D9B9E5786A546FEEDB09@AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM \
    --to=adriaan.schmidt@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=florian.bezdeka@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox