* [PATCH] RECIPE-API-CHANGELOG: Fix typo
@ 2022-06-15 16:22 Jan Kiszka
2022-06-20 13:41 ` Anton Mikanovich
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2022-06-15 16:22 UTC (permalink / raw)
To: isar-users
From: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
RECIPE-API-CHANGELOG.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
index 2998824b..cd6e7565 100644
--- a/RECIPE-API-CHANGELOG.md
+++ b/RECIPE-API-CHANGELOG.md
@@ -362,7 +362,7 @@ Changes when using the built-in types:
and so on.
* Image types defined in IMAGE_FSTYPES can be suffixed with conversions.
To get a compressed image, set IMAGE_FSTYPES to `wic.xz`, `ext4.gz`, etc.
- That also means that the type of the previous `targz-img` is not `tar.gz`.
+ That also means that the type of the previous `targz-img` is now `tar.gz`.
* Container types (previously CONTAINER_IMAGE_FORMATS) are now
first class image types (oci, oci-archive, docker-archive,
docker-daemon, containers-storage)
--
2.35.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RECIPE-API-CHANGELOG: Fix typo
2022-06-15 16:22 [PATCH] RECIPE-API-CHANGELOG: Fix typo Jan Kiszka
@ 2022-06-20 13:41 ` Anton Mikanovich
2022-06-20 13:51 ` Bezdeka, Florian
0 siblings, 1 reply; 6+ messages in thread
From: Anton Mikanovich @ 2022-06-20 13:41 UTC (permalink / raw)
To: Jan Kiszka, isar-users
15.06.2022 19:22, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> RECIPE-API-CHANGELOG.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
> index 2998824b..cd6e7565 100644
> --- a/RECIPE-API-CHANGELOG.md
> +++ b/RECIPE-API-CHANGELOG.md
> @@ -362,7 +362,7 @@ Changes when using the built-in types:
> and so on.
> * Image types defined in IMAGE_FSTYPES can be suffixed with conversions.
> To get a compressed image, set IMAGE_FSTYPES to `wic.xz`, `ext4.gz`, etc.
> - That also means that the type of the previous `targz-img` is not `tar.gz`.
> + That also means that the type of the previous `targz-img` is now `tar.gz`.
> * Container types (previously CONTAINER_IMAGE_FORMATS) are now
> first class image types (oci, oci-archive, docker-archive,
> docker-daemon, containers-storage)
Applied to next, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RECIPE-API-CHANGELOG: Fix typo
2022-06-20 13:41 ` Anton Mikanovich
@ 2022-06-20 13:51 ` Bezdeka, Florian
2022-06-20 14:03 ` Bezdeka, Florian
0 siblings, 1 reply; 6+ messages in thread
From: Bezdeka, Florian @ 2022-06-20 13:51 UTC (permalink / raw)
To: amikan, isar-users, jan.kiszka
On Mon, 2022-06-20 at 16:41 +0300, Anton Mikanovich wrote:
> 15.06.2022 19:22, Jan Kiszka wrote:
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> > RECIPE-API-CHANGELOG.md | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
> > index 2998824b..cd6e7565 100644
> > --- a/RECIPE-API-CHANGELOG.md
> > +++ b/RECIPE-API-CHANGELOG.md
> > @@ -362,7 +362,7 @@ Changes when using the built-in types:
> > and so on.
> > * Image types defined in IMAGE_FSTYPES can be suffixed with conversions.
> > To get a compressed image, set IMAGE_FSTYPES to `wic.xz`, `ext4.gz`, etc.
> > - That also means that the type of the previous `targz-img` is not `tar.gz`.
> > + That also means that the type of the previous `targz-img` is now `tar.gz`.
> > * Container types (previously CONTAINER_IMAGE_FORMATS) are now
> > first class image types (oci, oci-archive, docker-archive,
> > docker-daemon, containers-storage)
>
> Applied to next, thanks.
That was one of my review commits to the patch series that "introduced"
the typo. I'm quite sure that there was a follow up version containing
that fix.
So my question is: Are you sure that you merged the right version of
the patch series? There might be missing more now...
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RECIPE-API-CHANGELOG: Fix typo
2022-06-20 13:51 ` Bezdeka, Florian
@ 2022-06-20 14:03 ` Bezdeka, Florian
2022-06-20 14:05 ` Anton Mikanovich
2022-06-20 14:22 ` Schmidt, Adriaan
0 siblings, 2 replies; 6+ messages in thread
From: Bezdeka, Florian @ 2022-06-20 14:03 UTC (permalink / raw)
To: amikan, isar-users, jan.kiszka; +Cc: Schmidt, Adriaan
On Mon, 2022-06-20 at 13:51 +0000, Bezdeka, Florian wrote:
> On Mon, 2022-06-20 at 16:41 +0300, Anton Mikanovich wrote:
> > 15.06.2022 19:22, Jan Kiszka wrote:
> > > From: Jan Kiszka <jan.kiszka@siemens.com>
> > >
> > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > > ---
> > > RECIPE-API-CHANGELOG.md | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
> > > index 2998824b..cd6e7565 100644
> > > --- a/RECIPE-API-CHANGELOG.md
> > > +++ b/RECIPE-API-CHANGELOG.md
> > > @@ -362,7 +362,7 @@ Changes when using the built-in types:
> > > and so on.
> > > * Image types defined in IMAGE_FSTYPES can be suffixed with conversions.
> > > To get a compressed image, set IMAGE_FSTYPES to `wic.xz`, `ext4.gz`, etc.
> > > - That also means that the type of the previous `targz-img` is not `tar.gz`.
> > > + That also means that the type of the previous `targz-img` is now `tar.gz`.
> > > * Container types (previously CONTAINER_IMAGE_FORMATS) are now
> > > first class image types (oci, oci-archive, docker-archive,
> > > docker-daemon, containers-storage)
> >
> > Applied to next, thanks.
>
> That was one of my review commits to the patch series that "introduced"
> the typo. I'm quite sure that there was a follow up version containing
> that fix.
>
> So my question is: Are you sure that you merged the right version of
> the patch series? There might be missing more now...
Something went wrong with v2. See [1]. It claimed to have the fix but
actually did not. No further steps necessary.
Adriaan, it seems that something went wrong on your end when sending
out v2.
[1] https://groups.google.com/g/isar-users/c/MGOLSTWd83s/m/ZZHO8zszBgAJ
>
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RECIPE-API-CHANGELOG: Fix typo
2022-06-20 14:03 ` Bezdeka, Florian
@ 2022-06-20 14:05 ` Anton Mikanovich
2022-06-20 14:22 ` Schmidt, Adriaan
1 sibling, 0 replies; 6+ messages in thread
From: Anton Mikanovich @ 2022-06-20 14:05 UTC (permalink / raw)
To: Bezdeka, Florian, Schmidt, Adriaan, isar-users; +Cc: jan.kiszka
20.06.2022 17:03, Bezdeka, Florian wrote:
> On Mon, 2022-06-20 at 13:51 +0000, Bezdeka, Florian wrote:
>> That was one of my review commits to the patch series that "introduced"
>> the typo. I'm quite sure that there was a follow up version containing
>> that fix.
>>
>> So my question is: Are you sure that you merged the right version of
>> the patch series? There might be missing more now...
> Something went wrong with v2. See [1]. It claimed to have the fix but
> actually did not. No further steps necessary.
>
> Adriaan, it seems that something went wrong on your end when sending
> out v2.
>
> [1] https://groups.google.com/g/isar-users/c/MGOLSTWd83s/m/ZZHO8zszBgAJ
Yes, the patch `[PATCH v2 1/1] imagetypes: update recipe API changelog`
submitted on the list is exactly what we merged. It didn't include typo fix
(but declared to do so), that's why this typo fix was resend.
That was my fault to do not recheck the text but trust to commit message.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] RECIPE-API-CHANGELOG: Fix typo
2022-06-20 14:03 ` Bezdeka, Florian
2022-06-20 14:05 ` Anton Mikanovich
@ 2022-06-20 14:22 ` Schmidt, Adriaan
1 sibling, 0 replies; 6+ messages in thread
From: Schmidt, Adriaan @ 2022-06-20 14:22 UTC (permalink / raw)
To: Bezdeka, Florian, amikan, isar-users, jan.kiszka
Bezdeka, Florian, Montag, 20. Juni 2022 16:03:
> On Mon, 2022-06-20 at 13:51 +0000, Bezdeka, Florian wrote:
> > On Mon, 2022-06-20 at 16:41 +0300, Anton Mikanovich wrote:
> > > 15.06.2022 19:22, Jan Kiszka wrote:
> > > > From: Jan Kiszka <jan.kiszka@siemens.com>
> > > >
> > > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > > > ---
> > > > RECIPE-API-CHANGELOG.md | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
> > > > index 2998824b..cd6e7565 100644
> > > > --- a/RECIPE-API-CHANGELOG.md
> > > > +++ b/RECIPE-API-CHANGELOG.md
> > > > @@ -362,7 +362,7 @@ Changes when using the built-in types:
> > > > and so on.
> > > > * Image types defined in IMAGE_FSTYPES can be suffixed with
> conversions.
> > > > To get a compressed image, set IMAGE_FSTYPES to `wic.xz`,
> `ext4.gz`, etc.
> > > > - That also means that the type of the previous `targz-img` is not
> `tar.gz`.
> > > > + That also means that the type of the previous `targz-img` is now
> `tar.gz`.
> > > > * Container types (previously CONTAINER_IMAGE_FORMATS) are now
> > > > first class image types (oci, oci-archive, docker-archive,
> > > > docker-daemon, containers-storage)
> > >
> > > Applied to next, thanks.
> >
> > That was one of my review commits to the patch series that "introduced"
> > the typo. I'm quite sure that there was a follow up version containing
> > that fix.
> >
> > So my question is: Are you sure that you merged the right version of
> > the patch series? There might be missing more now...
>
> Something went wrong with v2. See [1]. It claimed to have the fix but
> actually did not. No further steps necessary.
>
> Adriaan, it seems that something went wrong on your end when sending
> out v2.
Yes, I don't know what happened. I have the fix on a local branch,
but must have sent something else. But that typo was the only difference
between v1 and the intended v2.
Sorry about the confusion.
Adriaan
> [1] https://groups.google.com/g/isar-users/c/MGOLSTWd83s/m/ZZHO8zszBgAJ
> >
> > >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-20 14:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-15 16:22 [PATCH] RECIPE-API-CHANGELOG: Fix typo Jan Kiszka
2022-06-20 13:41 ` Anton Mikanovich
2022-06-20 13:51 ` Bezdeka, Florian
2022-06-20 14:03 ` Bezdeka, Florian
2022-06-20 14:05 ` Anton Mikanovich
2022-06-20 14:22 ` Schmidt, Adriaan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox