RE: [PATCH v2 3/7] meta: introduce IMAGE_CMD_*

["Schmidt, Adriaan" <adriaan.schmidt@siemens.com>]

Hi Anton,

Anton Mikanovich, Donnerstag, 14. April 2022 19:47:
> >
> >   # glibc bug 23960 https://sourceware.org/bugzilla/show_bug.cgi?id=23960
> >   # should not use QEMU on armhf target with mkfs.ubifs < v2.1.3
> > -ISAR_CROSS_COMPILE_armhf = "1"
> > +python() {
> > +    if 'ubifs' in (d.getVar('IMAGE_BASETYPES') or '').split():
> > +        d.setVar('ISAR_CROSS_COMPILE_armhf', '1')
> > +}
> >
> This will also not work and actually fails on imx6-sabrelite-bullseye
> target.
> Reasons:
> 1) IMAGE_BASETYPES = "ubi ubi-ubifs" for that target and condition is False

Yes, this is actually a mistake I made. When caclucating IMAGE_BASETYPES,
we need to add IMAGE_TYPEDEPS_xxx recursively. Fixed in v3.

> 2) ISAR_CROSS_COMPILE should be set before anonymous python code because
> buildchroot selection is done also in python() {}

Fixed in v3:
THIS_ISAR_CROSS_COMPILE := "${ISAR_CROSS_COMPILE}"
ISAR_CROSS_COMPILE_armhf = "${@bb.utils.contains('IMAGE_BASETYPES', 'ubifs', '1', '${THIS_ISAR_CROSS_COMPILE}', d)}"

It looks a little ugly because I'm trying to preserve any previous value
of ISAR_CROSS_COMPILE without the variable referencing itself...

With these changes I can now build the imx6-sabrelite-bullseye target, and I
confirmed that ISAR_CROSS_COMPILE is not set when using armhf with image
types != ubifs.

> Also it better to document (or at least comment) IMAGE_BASETYPES as a
> new variable.

For the user manual, I think adding this would be much more detail than
we generally have throughout the document, but I added a comment in v3.

Adriaan