RE: [PATCH] sstate: Make image cache imagetype-specific

["Schmidt, Adriaan" <adriaan.schmidt@siemens.com>]

Anton Mikanovich, 15. Dezember 2021 13:58:
> Building of isar-image-base for targets qemuamd64-buster-tgz and
> qemuamd64-buster-cpiogz with one bitbake call fails with:
> 
> ERROR: mc:qemuamd64-buster-tgz:isar-image-base-1.0-r0 do_rootfs: Package
> already staged
> 
> This is caused by sstate cache conflict for those two packages.
> We need to add image type to sstate manifest data to fix the issue.

Actually, now that IMAGE_FSTYPES supports generating multiple images
with different types at once, multiconfig is the wrong way to go in
this scenario.

When creating the same two images via IMAGE_FSTYPES="targz-img cpiogz-img"
there is no problem, and we can then even go one step further and
remove the ${IMAGE_SUFFIX} completely.
Eventually, this will enable better sharing (and caching), e.g., in this
case both images are built from the same rootfs, which is what is
stored in the sstate-cache.

Also, when removing IMAGE_SUFFIX, the task-once-stamp logic from isar-events
will warn that something is wrong in case IMAGE_FSTYPES is set in
multiconfig (which is exactly what we want):

ERROR: Detect multiple executions of do_image in /work/build/tmp/work/debian-buster-amd64/isar-image-base-qemuamd64/1.0-r0
ERROR: Rerun a clean build with empty STAMPCLEAN and compare the sigdata files

Adriaan

> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  meta/classes/image.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index d757256d..50ae03e6 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -9,7 +9,7 @@ STAMP = "${STAMPS_DIR}/${DISTRO}-${DISTRO_ARCH}/${PN}-
> ${MACHINE}-${IMAGE_SUFFIX}
>  STAMPCLEAN = "${STAMPS_DIR}/${DISTRO}-${DISTRO_ARCH}/${PN}-${MACHINE}-
> ${IMAGE_SUFFIX}/*-*"
> 
>  # Sstate also needs to be machine-specific
> -SSTATE_MANIFESTS = "${TMPDIR}/sstate-control/${MACHINE}-${DISTRO}-
> ${DISTRO_ARCH}"
> +SSTATE_MANIFESTS = "${TMPDIR}/sstate-control/${MACHINE}-${DISTRO}-
> ${DISTRO_ARCH}-${IMAGE_SUFFIX}"
> 
>  IMAGE_INSTALL ?= ""
>  IMAGE_FSTYPES ?= "${@ d.getVar("IMAGE_TYPE", True) if d.getVar("IMAGE_TYPE",
> True) else "ext4-img"}"
> --
> 2.20.1
> 
> --
> You received this message because you are subscribed to the Google Groups
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/isar-users/20211215125748.299859-1-
> amikan%40ilbers.de.