public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Schmidt, Adriaan" <adriaan.schmidt@siemens.com>
To: "MOESSBAUER, Felix" <felix.moessbauer@siemens.com>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Cc: "amikan@ilbers.de" <amikan@ilbers.de>,
	"Kiszka, Jan" <jan.kiszka@siemens.com>,
	"quirin.gylstorff@siemens.com" <quirin.gylstorff@siemens.com>
Subject: RE: [PATCH 0/1] fix copy out of apt cache after sbuild
Date: Mon, 22 Jan 2024 13:47:32 +0000	[thread overview]
Message-ID: <AS4PR10MB53183E4234F80E6B8F559E7DED752@AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240122132647.779902-1-felix.moessbauer@siemens.com>

'Felix Moessbauer' via isar-users <isar-users@googlegroups.com>, Monday, January 22, 2024 2:27 PM
> This series fixes the build issues reported in "potential race
> condition in sbuild post commands" by not copying symlinks. This has
> been tested on various large layers and seems to do the job. However,
> it still remains unclear why packages are missing in the apt cache
> under some rebuild scenarios.
> 
> While investigating this, I also noticed that we AGAIN have a quadratic
> space blow-up in the isar-apt directory that is copied into the build
> folder of each package. This makes me wonder if the whole APT handling
> is properly understood. IMHO this needs another haul-over, which is also
> indicated by the number of apt related issues which were reported in the
> last months.

https://github.com/ilbers/isar/blob/master/meta/classes/dpkg-base.bbclass#L198

Looking at the code, the intention is that hard links are used to pass isar-apt
into each package build. Could your measurement be counting those wrong?

And if we do think that another approach at handling the whole apt topic is worth
considering: I posted about that a while back ("[RFC PATCH] Remove isar-apt and
the corresponding lock" from 2022-10-19)...

Adriaan

> 
> Best regards,
> Felix
> 
> Felix Moessbauer (1):
>   fix copy out of apt cache after sbuild
> 
>  meta/classes/dpkg.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --
> 2.39.2
> 
> --
> You received this message because you are subscribed to the Google Groups
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/isar-users/20240122132647.779902-1-
> felix.moessbauer%40siemens.com.

  parent reply	other threads:[~2024-01-22 13:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 13:26 Felix Moessbauer
2024-01-22 13:26 ` [PATCH 1/1] " Felix Moessbauer
2024-01-22 13:47 ` Schmidt, Adriaan [this message]
2024-01-22 15:04   ` [PATCH 0/1] " MOESSBAUER, Felix
2024-01-29 10:50 ` Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS4PR10MB53183E4234F80E6B8F559E7DED752@AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM \
    --to=adriaan.schmidt@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    --cc=quirin.gylstorff@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox