RE: [PATCH v2 4/4] multiarch: Fix SRC_URI:remove ignoring

["Schmidt, Adriaan" <adriaan.schmidt@siemens.com>]

Anton Mikanovich, Friday, February 16, 2024 3:11 PM:
> Setting SRC_URI right after getVar with expand=False results in loosing
> SRC_URI:remove values. Rebuild logic to use remove-append approach.
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  meta/classes/multiarch.bbclass | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/multiarch.bbclass b/meta/classes/multiarch.bbclass
> index 48cec9ab..b3fc9441 100644
> --- a/meta/classes/multiarch.bbclass
> +++ b/meta/classes/multiarch.bbclass
> @@ -49,8 +49,9 @@ python multiarch_virtclass_handler() {
>          vars = 'SRC_URI FILESPATH'.split()
>          for var in vars:
>              v = d.getVar(var, expand=False)
> -            if v is not None:
> -                d.setVar(var, v.replace('${PN}', '${BPN}'))
> +            if v is not None and '${PN}' in v:
> +                d.setVar(var + ':remove', v)
> +                d.appendVar(var, v.replace('${PN}', '${BPN}'))

Hi Anton,

Just stumbled across this when using current next:
There is a space missing in the append:
d.appendVar(var, ' ' + v.replace('${PN}', '${BPN}'))

Also, setting variables "V:remove" (potentially multiple times) from
Python code smells a little funny. I'm not sure about Bitbake parsing,
and the order of execution-of-Python-blocks vs. variable-assignments vs.
expansions vs. :remove-operators, but I'm a worried that this might
be relying on some undocumented implementation details and only work
by accident.
But I admit that I didn't have a closer look at the actual problem
you're solving here, so I also don't have a good alternative proposal.

So for now, I'd suggest to just fix the missing space.

Thanks,
Adriaan

> 
>      # When building compat/native, the corresponding suffix needs to be
>      # propagated to all bitbake dependency definitions.
> --
> 2.34.1
> 
> --
> You received this message because you are subscribed to the Google Groups
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/isar-users/20240216141051.3490109-5-
> amikan%40ilbers.de.