public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Schmidt, Adriaan" <adriaan.schmidt@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: RE: [PATCH 0/7] Rebuild phyBOARD-Mira UBI image generation
Date: Thu, 31 Mar 2022 06:10:15 +0000	[thread overview]
Message-ID: <AS4PR10MB53185B4311D81542998D0EA7EDE19@AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <0d5ceae2-3e06-da63-a782-02015062bceb@ilbers.de>

Anton Mikanovich, Freitag, 18. Februar 2022 17:38:
> 10.02.2022 09:52, Schmidt, Adriaan wrote:
> > Anton Mikanovich, 9. Februar 2022 14:54:
> >> Rebuild UBI image generation implementation to support any count of
> >> targets with different settings. This also will allow to build the same
> >> isar-image-base image for both UBI and non-UBI targets.
> >> Add correct UBI and UBIFS layouts for phyBOARD-Mira after that.
> > I've just posted a proposal to generally rework image generation
> > ([PATCH 0/6] imagetypes), which overlaps with your patches 1..3.
> > I admit that I don't fully understand the ubi(-ubifs) process, so my series
> > might actually break something here. But I can imagine that your image
> > changes could also get simpler if you put them on top of my imagetypes
> > patches.
> >
> > Adriaan
> 
> The main "blocking" issue I've found is override implementation. We need to
> have a way to use image type related overrides outside recipes included by
> INHERIT variable.
> Moreover, current implementation of overrides for multiple image types looks
> incorrect, because only one type is actually used for override at one
> inherit.

Turns out that this is really hard to implement.
The actual list of image types is computed from IMAGE_FSTYPES:
- remove any conversions (e.g., "wic.xz" should set "wic" override)
- resolve dependencies (e.g., "ova" should set both "ova" and dependent "wic" overrides)

And it seems that the OVERRIDES variable is something so low-level, that
when I try to append a computed list like this, bitbake breaks in very strange ways.

The current implementation (inspired by OE) only sets the override inside
a local environment created for the single IMAGE_CMD. But that means it is
not available at "general recipe level", so in your concrete case (ubi/fit) you
can't use it to change SRC_URI.

I'm wondering if there is a better way to implement that ubi/fit case.
I notice that the wic class makes quite some effort to process the wks file
from a template, while never touching SRC_URI. Maybe appending to SRC_URI
based on image type is just something that should be avoided? I haven't
thought it through yet...

Adriaan

      reply	other threads:[~2022-03-31  6:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09 13:54 Anton Mikanovich
2022-02-09 13:54 ` [PATCH 1/7] ubi: Move default output paths to image class Anton Mikanovich
2022-02-09 13:54 ` [PATCH 2/7] ubi: Remove isar-image-ubi Anton Mikanovich
2022-02-09 13:54 ` [PATCH 3/7] ubi: Move tasks reorder into parent task Anton Mikanovich
2022-02-09 13:54 ` [PATCH 4/7] ubi: Split UBI configs for phyboard-mira and imx6-sabrelite Anton Mikanovich
2022-02-09 13:54 ` [PATCH 5/7] conf: Remove machine-specific defines from multiconfig Anton Mikanovich
2022-02-09 13:54 ` [PATCH 6/7] meta-isar: Add linux-phy kernel Anton Mikanovich
2022-02-09 13:54 ` [PATCH 7/7] meta: Add barebox bootloader support Anton Mikanovich
2022-02-09 18:08   ` Jan Kiszka
2022-02-10  7:58     ` Anton Mikanovich
2022-02-10  8:05       ` Jan Kiszka
2022-02-10  8:45         ` Anton Mikanovich
2022-02-10 11:24           ` Jan Kiszka
2022-02-10 14:03             ` Anton Mikanovich
2022-02-10  6:52 ` [PATCH 0/7] Rebuild phyBOARD-Mira UBI image generation Schmidt, Adriaan
2022-02-10  8:12   ` Anton Mikanovich
2022-02-18 16:38   ` Anton Mikanovich
2022-03-31  6:10     ` Schmidt, Adriaan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS4PR10MB53185B4311D81542998D0EA7EDE19@AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM \
    --to=adriaan.schmidt@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox