From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7121963773926047744 X-Received: by 2002:a1f:2fc5:0:b0:375:95c5:c729 with SMTP id v188-20020a1f2fc5000000b0037595c5c729mr3103588vkv.39.1658218316218; Tue, 19 Jul 2022 01:11:56 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a67:dc1a:0:b0:357:ca8c:5078 with SMTP id x26-20020a67dc1a000000b00357ca8c5078ls69784vsj.11.-pod-prod-gmail; Tue, 19 Jul 2022 01:11:55 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vkFeqNfb6kv4/Spu9dPCiLu7e9DkpkJulIJjQPWE6NEwyzVzKI0Ddpl9mZd0woZe/lEb2k X-Received: by 2002:a05:6102:3d20:b0:357:7f61:6127 with SMTP id i32-20020a0561023d2000b003577f616127mr9924740vsv.11.1658218315584; Tue, 19 Jul 2022 01:11:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1658218315; cv=pass; d=google.com; s=arc-20160816; b=fO3TeyzC2rLNZAymQFqHVVz06KQwl3zyeL+cDiP0r9yFmysKGzYfxZOg1oE3+w2U/4 u5kwGSCWJcd/bMTzKLmMGf4VfqCI5I80fhMRjztxPcCtYNFVX3JkDyG2geSQaYp/X7tD zBUd4L5IY9fppz9GCAlCYP7gmqyX0h6fiTXZuUX88cJG6TmtaJ3aMjtLqdrEEXG9sVTe q3gwJJZZvcjdakdUhE/FBNQ728jlLlekCW+dSxQCW6cCUeRJvGHBju4J+MUETJ2CDc+J OoC9lOMDvKKLKwo5Vx44GDVtusMKh24Ufo1xcDhLSxf23Cpd7kL0M6M36+uv1PLVqsNw jNhg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:document_confidentiality :msip_labels:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=GRExFP80OYoToyBne365oOCdFp/ZgJseCihf9y4NONI=; b=DtvoO8oqnyqIQ0BOgY4oN+JTdK3lpvAZXWqC4hKdgWuQQCVGwnihWqWASR7VVgnR/U Rv0rlhy/tiPfQ9AARduqoPJnMGWzfNaDKtY1lmr6e+BcbZMew1Z3tBY/fPiK7JVsEKAp MzyFHX/JRii4MlIl4G03uosoLKLTk0CESs44O8v6d0zHIXVKrLnGINgLKXxvnUauvVJP QuR/QhxyXaXk8BsLwCWK6yBsvwX+7onuQ4RNT88/bZipX0kzOURJOuAUB63WqxEi/z48 2KyI0WAATOf8JMDsCt9UmFvXF7f8e91acG79720cuzH3RVWPH9Hy1uR1d0Kj229czFgN L9iQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=VgR6hTG6; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 40.107.21.72 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2072.outbound.protection.outlook.com. [40.107.21.72]) by gmr-mx.google.com with ESMTPS id f81-20020a1f9c54000000b0037467483219si587896vke.0.2022.07.19.01.11.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jul 2022 01:11:55 -0700 (PDT) Received-SPF: pass (google.com: domain of adriaan.schmidt@siemens.com designates 40.107.21.72 as permitted sender) client-ip=40.107.21.72; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=VgR6hTG6; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 40.107.21.72 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l7XHc/8zQi21wnW9VGONUcGP5xUXLvA4/VD8+L2Rd+VZpf/u1s65kS497TtpLxHIBp7CmoDYEzcycjT8IWyJKgUekLR4nlkHUGjM8/yBlIB70pyZTm6Q7MYK6DcHD8FpSHoIJw0TCrccQDrT8DihUdoW+zdSAfMjwfq16KQyIJ7LaJWFHNiGSh2EbW7LtEwC08wshDZgpVXRq0LEU53dboPzORllfz0QWFl4nzOdjHI8erWNxLeKKlJWAXwdsNzLOVyiAWxesY4JiUnV4iLtSD9zZV0HDJStH6IfiY4TfDWuKW2QHS4UUXqCTNPW0MA7S9WOFuQPfFg3qiWwU07y2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GRExFP80OYoToyBne365oOCdFp/ZgJseCihf9y4NONI=; b=jt30BkKXTBhAsRGma+y21OV/U/BjrVmNlsHfj1XNYBsvsMGI6eBGH7+aiJe+5m5kOFgZ1G0ppnsv2K05RQYbHGqGbXqTUb9FC+SvI4x1ikKpnHiHb2g1lT37IFIPvZ2twfNep3wtdT8FsFhYaIhVt8kLJLqwcTY+xnDBQGxFC/QUK1hHngKB1Ad14oLWgbIcSSl54T2HWwCOMNOnrJBuaN6/nODtTvPd1IhYuUSYEMEc0KOjuj1cHf3+sEHE6cmDRLVVdm81BTgr/zl2Gv/pxMpOWXk5+QmxA0YAVT2umfK2Do9Xt65h2boDAgJtyZpkMo/BHxBZ/+rTNxmFEUo+EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GRExFP80OYoToyBne365oOCdFp/ZgJseCihf9y4NONI=; b=VgR6hTG6Y6vAwrPupf+oSwL4H0KZakb5osmkyZhkqjizZzNhL//a2Lkuah5X4EAptId4VDJHiJAhEyONLI2Z/lmPhhUcdZptpRacFwfVVI8sbyEAVvqUFVrHJ+Wnk4bqKzUSO97U/bfYa48bynCYp59Rg5/UzBqNBiAL4e35KVCfkFVu7812/uv5zBQw7dMjaLeufM1+0sNUgCD6bTBUIjW4POECgF5jfB3LlL61kLsRJ/BadN70xdsB0JanF0w2ZUJ0pmJO2zW4tSGwWzeXNXIxbGmvrAuy912YQnBd2+w/uzUl8KA2H6oc6gCmxNpFOWhLR90/iCCQ5+INZLuvbw== Received: from AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:4b8::15) by AM0PR10MB1939.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:44::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.21; Tue, 19 Jul 2022 08:11:48 +0000 Received: from AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM ([fe80::f18c:c236:d044:3f12]) by AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM ([fe80::f18c:c236:d044:3f12%7]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 08:11:48 +0000 From: "Schmidt, Adriaan" To: "Schild, Henning" CC: "isar-users@googlegroups.com" Subject: RE: [PATCH 1/3] fix(isar-sstate): catch errors in signature comparison Thread-Topic: [PATCH 1/3] fix(isar-sstate): catch errors in signature comparison Thread-Index: AQHYmzceT2tRqpYYG0mNyYbx7EbP1K2FRWqAgAAFqdA= Date: Tue, 19 Jul 2022 08:11:48 +0000 Message-ID: References: <20220719061628.192078-1-adriaan.schmidt@siemens.com> <20220719061628.192078-2-adriaan.schmidt@siemens.com> <20220719090527.0979e298@md1za8fc.ad001.siemens.net> In-Reply-To: <20220719090527.0979e298@md1za8fc.ad001.siemens.net> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Enabled=true; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SetDate=2022-07-19T08:11:46Z; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Method=Standard; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Name=restricted-default; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SiteId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ActionId=dca2be31-6f17-4566-847c-1cfdc690d4e0; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ContentBits=0 document_confidentiality: Restricted authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3a97fafd-c156-40f9-9298-08da695e5445 x-ms-traffictypediagnostic: AM0PR10MB1939:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6QhUy58IsvaZM0BKb4ciCnsWyDDp1Vl0MhRRafPtjBrzNpXAGP1qmcTLSUAa2O/N424G7zRkBfa/cou/iSByinDrlsjr8nOOGx5mMQK5MERASUq6cg3y39c2atrnua8wgNIdYlAiHzIzl2OYBiQkNLY5yTbvEWXv4e5SR0IA5BBjVnIZAhlwsWc8DXUhEBk7P+mVlzj3PMnSd5XP7DdTvgxmaZfz1VHe3Xk1C08RzACcpxYI+xWKA4LehQFzX/NzSdIuTZnilabhmTcqEOWYAw1Z213GA+bBp5jTO3JVRwP4PumeHtA1bDtb524VOhXBnFXJqmrcY1TjzM+Qt0oZmSavY7hp6l/LH6wBNDRhyzUdgHwZDX3eunYdogz+F4jirqGfxYGDS8O5oghwzsZyaJ6+dQlUUqhOKv/Tauv7VKGXu8jYjoFM+1NdvDtWs3pG4HHqD4OYlG2l/0t5ZlWoK7kEp0aey58zK+q0RI7EpS91YIevpMtERRAW9VIzCJGKcQKWtfADfpOZJZL+jiyYMDWANKMELBQuuOknlBceMQL/QgLIvEbubQsvxwtbaQHlWsyeth+W5mTUMNHpwbSDm4PPYz/bZwPST/zD2F0Ssc/KIQGNoqewBbcvvBtBV6YfVo0Ffvm//5MXPVlIbrd0IJWoE1HAhYV3geJRbiUfShlmKsS3Q0oNHVUxhQZbrkUhiJAtdGLIXQNCM41q1xUE3O9kud6uJiEc2GjUTmibz43vVJt2uzfI2WS/iFwKRtZSuMgFTuRxOnjWM8KYQRW8zJPMTJupAt4crVqJKpW1yrTF0Ary3rWRm4CD8UmM5NSE x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(39860400002)(376002)(346002)(136003)(33656002)(52536014)(8936002)(38070700005)(6862004)(86362001)(66556008)(64756008)(66446008)(66946007)(8676002)(4326008)(76116006)(66476007)(38100700002)(6506007)(82960400001)(55016003)(6636002)(7696005)(316002)(186003)(41300700001)(122000001)(83380400001)(9686003)(26005)(71200400001)(478600001)(5660300002)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JDoc1xBvg0BPEfmkwoPxx4NidOJeozX/h+NOujad7upEzTGhQ2HxWbRZSTB1?= =?us-ascii?Q?1SBM7ObnE6sRnE032gBp6IkGm9jT3gkhCyhnXD/QbheVfX1T5FfT260NoYMc?= =?us-ascii?Q?gjk9tBAkHZmvjR3xz2OUFulFgXvWh++I40RRe4ks7DE7cbQknrEjorfuQllk?= =?us-ascii?Q?SsZhw/yT1PoD0Al71NjiZ36jQ3Vu02PaL0KxkV9h3RtUFW3+IpHmZ1xKDHAo?= =?us-ascii?Q?cvYiooNbElGo1TK9vIyAQ+KM4KbD/MOIdS71GxgDM8IvhmaFhsTD3OZfvXWF?= =?us-ascii?Q?A4YG2qgV1iAARoOtmzI8cYBe15uk2J8TQ1ZoDMI9Gtb9ZI+Qzbet9V1LoJUh?= =?us-ascii?Q?vwr7gFsgZLWhN/8f0ZhYhrGqwpqq2KjV7gV4SU/UouHyHNQllNX1017rBwN6?= =?us-ascii?Q?8PDLdIOPiZ8ZxAiUFnHnwIk5R8JvU/MsGxkiAeXlRiEYLy2/9jGV3Hkydo57?= =?us-ascii?Q?ZEXLyzEdrjWPJpBY9l1AJ0RVfGRd1BOH1/tzqOYVeRyqPmke70jurafu94rx?= =?us-ascii?Q?v9sDQO+5aW7xuuZ8/AzC12OSTcZJgg8X3uHU0iXnt3dqY1xgZAITChTZuN+5?= =?us-ascii?Q?QD8snAR0q/NO0q9kKjAdrO2ndnG8IbWnoSGL2p08xstGCwlNjSA9jL1I0Dqy?= =?us-ascii?Q?gBcNtGAkB3gbl5xNO51aJr8Tm45kd5XD/nrhvRQf0Vs8eY8EUCPFkSvVUunH?= =?us-ascii?Q?L0pcXaN3Ikm2LpantgKn9CIysLxaePNYmC8Gc5y2WxCs4G4Ma/mkFPlzyoUC?= =?us-ascii?Q?tHrjiBI4lbNeKjRXNzE43jO8h5iLeJf2gd2EWGS9Zm5fkpMCE1ftl5xXO9eS?= =?us-ascii?Q?8pTF4D/TrPeuVCPoE7ltco1Fs9VF7B7Vwpg64X6hvAsgty1fnw7KlT9NKlYT?= =?us-ascii?Q?r9J49ZVXpjQw775TscVv+GXdq+VKzccfgRR/EAwffBHxBZnI2hak64d4rN91?= =?us-ascii?Q?RUJUOEKIER/HmIruXW4WXKPZlFdDXStzsnp5BwlnK/5516+7laVsj3WkOE5k?= =?us-ascii?Q?1v1sdvGE1CB8aRuP8DT9aHNoZHCPnxgUQ5eUhCY9mz1dA+QO6SycdwAXVkoQ?= =?us-ascii?Q?OZCjLkToHBldh8yjYHm44rbh+rqNWf5VzjefP2Yhg3rHx5l/TZvwyCOFNmVM?= =?us-ascii?Q?ONTP/UTeMm4JElQMyw9VpqJg1Z9IESAGRThu6rxh2vNMHXU+0c6TXCHnfDwv?= =?us-ascii?Q?FlnzJUN8/qbN6JChgA+CRgCL3cOlRgOcMDn9615Xni3YfRR+OdRA9Hx1WMWU?= =?us-ascii?Q?2BMVqq4cynoiVG7r618H/seQxO8I2HVnyetpJgXGMoSFxshiX5jBXVpNOo01?= =?us-ascii?Q?/P266fswnGkS8J9QniDBafTh/16ZYL8yOsUzV1+vndgn+tajOOwAtIqA5BUz?= =?us-ascii?Q?x2QhXhGB8yMfHXHukuCmhDscuHku/+7QBOvETpglN/UDFnsfsd4W8HupsFrd?= =?us-ascii?Q?P5UQpAR3CSYtlejHIOPm/LUejZVp6b0LFLF76phgKV/SYae/IyPnKB+GYlBf?= =?us-ascii?Q?Korfh3jmjJbAr1gxR6/stAuVzGaczbUGAgDZV2tsbzJQtYthZbU6u6iaIagl?= =?us-ascii?Q?qV5uh6UifLrjr2N5Bz4YOUvlW8vsonwhZ/w93aeCslppz7VmnwFUIiJb9qOM?= =?us-ascii?Q?qw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 3a97fafd-c156-40f9-9298-08da695e5445 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 08:11:48.7877 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q+4FmQzdUbCl23vwckZEt/Q0QeqtjGWUtE+CurSjvAtT/K/ocyeZWiE42+XcyrV29f4EurxP9bCwKpcP/7LBZpImf+JnJhCBHxj59ob3BaE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB1939 X-TUID: ey4KjYPGiGFW Schild, Henning, Dienstag, 19. Juli 2022 09:05: > Am Tue, 19 Jul 2022 08:16:26 +0200 > schrieb Adriaan Schmidt : >=20 > > Those errors happen when the sstate cache contains both pre and post > > bitbake-2.0 signatures, which have a different format (pickle vs. > > compressed json). > > > > Signed-off-by: Adriaan Schmidt > > --- > > scripts/isar-sstate | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/scripts/isar-sstate b/scripts/isar-sstate > > index 8ea85edc..9f5c17b0 100755 > > --- a/scripts/isar-sstate > > +++ b/scripts/isar-sstate > > @@ -781,7 +781,10 @@ def sstate_analyze(source, target, **kwargs): > > > > local_file =3D source.download(s.path) > > remote_file =3D target.download(t.path) > > - out =3D compare_sigfiles(remote_file, local_file, > > recursecb, color=3DTrue) > > + try: > > + out =3D compare_sigfiles(remote_file, local_file, > > recursecb, color=3DTrue) > > + except: > > + out =3D ["Failed to compare signatures."] >=20 > Maybe there is a python exception for just that, or an error code from > which we can take strerr so we do not invent our own. The exceptions we see here come from different locations during file readin= g. I'm seeing things like EOFError or _pickle.UnpicklingError, and when we mov= e to bitbake 2.0 it may be something compression or json related. The strings returned are not really useful (e.g. from the unpickler it might be "Memo value not found at index 97"), that's why I went for "catch anything and move on". But I just noticed that sstate_lint() also needs a try/catch when reading signature files. Will send update. Adriaan > Henning >=20 > > source.release(local_file) > > target.release(remote_file) > > # shorten hashes from 64 to 8 characters for better > > readability