public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Schmidt, Adriaan" <adriaan.schmidt@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: RE: [PATCH v2 00/18] Migrate to Bitbake 2.0
Date: Tue, 19 Jul 2022 11:36:13 +0000	[thread overview]
Message-ID: <AS4PR10MB53186729487A5C0ACD0EBD6AED8F9@AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20220715060442.18063-1-amikan@ilbers.de>

Anton Mikanovich, Freitag, 15. Juli 2022 08:04:
> This patchset moves Isar to use Bitbake 2.0 branch.

Hi Anton,

Looks great overall!

> scripts/contrib/convert-overrides.py is the script for overrides update and
> it
> needs some testing on downstream layers. Usage:
> $ ./scripts/contrib/convert-overrides.py meta-customlayer

I found a number of variables in the image(r) context in meta that we use with
overrides, and that are not yet covered by the conversion script:
IMAGE_FSTYPES
IMAGE_SRC_URI
IMAGE_TEMPLATE_FILES
IMAGE_TEMPLATE_VARS
IMAGE_CMD_REQUIRED_ARGS
IMAGE_FULLNAME
CONVERSION_DEPS
BUILDCHROOT_PREINSTALL
IMAGER_BUILD_DEPS
IMAGER_INSTALL

And then there's the issue with the [network] flag we currently add to
tasks that need network, but also to those that use sudo.
I'm not sure if there's a reason why bitbake creates a new user namespace
when disabling network. We could discuss with upsteam. This patch would
enable sudo for Isar:
---
diff --git a/bitbake/lib/bb/utils.py b/bitbake/lib/bb/utils.py
index 05adb415..d11da978 100644
--- a/bitbake/lib/bb/utils.py
+++ b/bitbake/lib/bb/utils.py
@@ -1618,7 +1618,7 @@ def disable_network(uid=None, gid=None):
     if gid is None:
         gid = os.getgid()
 
-    ret = libc.unshare(CLONE_NEWNET)
+    ret = libc.unshare(CLONE_NEWNET | CLONE_NEWUSER)
     if ret != 0:
         logger.debug("System doesn't suport disabling network without admin privs")
         return
---

Adriaan

> Known issues:
> - WIC is no more working on stretch targets: new bitbake version requires
> python 3.6 with libs non exist in 3.5 from stretch (like pyshtables)
> 
> Changes since v1:
> 
> - Rebased on top of sbuild
> - Resolved 'metadata is not deterministic' issues
> - Update sstate class and maintenance script
> - Update OE classes
> - Adopt CI configuration
> 
> Anton Mikanovich (18):
>   meta: change deprecated parse calls
>   scripts/contrib: Add override conversion script
>   scripts/contrib: configure override conversion script
>   meta-isar: set default branch names
>   meta: remove non recommended syntax
>   bitbake: Update to Bitbake 2.0.1
>   doc: require zstd tool
>   meta: update bitbake variables
>   bitbake.conf: align hash vars with openembedded
>   meta: mark network and sudo tasks
>   meta: update overrides syntax
>   sstate: update bbclass
>   bitbake.conf: declare default XZ and ZSTD options
>   Revert "devshell: Use different termination test to avoid warnings"
>   meta: align with OE-core libraries update
>   Revert "Revert "devshell: Use different termination test to avoid
>     warnings""
>   CI: Adopt tests to syntax change
>   isar-sstate: adopt sstate maintenance script
> 
>  bitbake/README                                |  21 +-
>  bitbake/bin/bitbake                           |   4 +-
>  bitbake/bin/bitbake-diffsigs                  |   5 +-
>  bitbake/bin/bitbake-getvar                    |  50 ++
>  bitbake/bin/bitbake-hashclient                |   2 +
>  bitbake/bin/bitbake-hashserv                  |   2 +
>  bitbake/bin/bitbake-layers                    |   2 +
>  bitbake/bin/bitbake-prserv                    |   6 +-
>  bitbake/bin/bitbake-selftest                  |   3 +
>  bitbake/bin/bitbake-server                    |   3 +-
>  bitbake/bin/bitbake-worker                    |  21 +-
>  bitbake/bin/git-make-shallow                  |   2 +
>  bitbake/bin/toaster                           |   6 +-
>  bitbake/bin/toaster-eventreplay               |   2 +
>  bitbake/conf/bitbake.conf                     |   6 +-
>  bitbake/contrib/hashserv/Dockerfile           |   6 +-
>  bitbake/contrib/prserv/Dockerfile             |  62 ++
>  bitbake/contrib/vim/plugin/newbbappend.vim    |   2 +-
>  bitbake/contrib/vim/syntax/bitbake.vim        |  11 +-
>  bitbake/doc/Makefile                          |   2 +-
>  bitbake/doc/README                            |   6 +-
>  .../bitbake-user-manual-execution.rst         | 112 ++--
>  .../bitbake-user-manual-fetching.rst          | 151 +++--
>  .../bitbake-user-manual-hello.rst             |  60 +-
>  .../bitbake-user-manual-intro.rst             |  64 +-
>  .../bitbake-user-manual-metadata.rst          | 446 +++++++-------
>  .../bitbake-user-manual-ref-variables.rst     | 583 ++++++++++--------
>  bitbake/doc/releases.rst                      |  84 ++-
>  bitbake/lib/bb/__init__.py                    |  19 +-
>  bitbake/lib/bb/asyncrpc/__init__.py           |  31 +
>  bitbake/lib/bb/asyncrpc/client.py             | 172 ++++++
>  bitbake/lib/bb/asyncrpc/serv.py               | 286 +++++++++
>  bitbake/lib/bb/build.py                       |  90 +--
>  bitbake/lib/bb/cache.py                       |  35 +-
>  bitbake/lib/bb/checksum.py                    |  22 +-
>  bitbake/lib/bb/codeparser.py                  |  20 +-
>  bitbake/lib/bb/command.py                     |  36 +-
>  bitbake/lib/bb/compress/_pipecompress.py      | 194 ++++++
>  bitbake/lib/bb/compress/lz4.py                |  17 +
>  bitbake/lib/bb/compress/zstd.py               |  28 +
>  bitbake/lib/bb/cooker.py                      | 293 +++++----
>  bitbake/lib/bb/cookerdata.py                  |  47 +-
>  bitbake/lib/bb/daemonize.py                   |  42 +-
>  bitbake/lib/bb/data.py                        |  57 +-
>  bitbake/lib/bb/data_smart.py                  | 213 ++++---
>  bitbake/lib/bb/event.py                       |   6 +-
>  bitbake/lib/bb/fetch2/README                  |  57 ++
>  bitbake/lib/bb/fetch2/__init__.py             | 136 ++--
>  bitbake/lib/bb/fetch2/crate.py                | 136 ++++
>  bitbake/lib/bb/fetch2/git.py                  |  54 +-
>  bitbake/lib/bb/fetch2/gitsm.py                |  20 +-
>  bitbake/lib/bb/fetch2/npm.py                  |  50 +-
>  bitbake/lib/bb/fetch2/npmsw.py                |  33 +-
>  bitbake/lib/bb/fetch2/osc.py                  |   2 +-
>  bitbake/lib/bb/fetch2/s3.py                   |  41 +-
>  bitbake/lib/bb/fetch2/ssh.py                  |  49 +-
>  bitbake/lib/bb/fetch2/svn.py                  |  10 +-
>  bitbake/lib/bb/fetch2/wget.py                 | 161 +++--
>  bitbake/lib/bb/main.py                        |   9 +-
>  bitbake/lib/bb/monitordisk.py                 |  17 +-
>  bitbake/lib/bb/msg.py                         |  32 +-
>  bitbake/lib/bb/parse/__init__.py              |   2 +
>  bitbake/lib/bb/parse/ast.py                   |  14 +-
>  bitbake/lib/bb/parse/parse_py/BBHandler.py    |   3 -
>  bitbake/lib/bb/parse/parse_py/ConfHandler.py  |   5 +-
>  bitbake/lib/bb/persist_data.py                |  54 +-
>  bitbake/lib/bb/process.py                     |   2 +-
>  bitbake/lib/bb/progress.py                    |   9 +-
>  bitbake/lib/bb/providers.py                   |  14 +-
>  bitbake/lib/bb/runqueue.py                    | 179 +++---
>  bitbake/lib/bb/server/process.py              |  44 +-
>  bitbake/lib/bb/server/xmlrpcserver.py         |   1 +
>  bitbake/lib/bb/siggen.py                      | 182 ++++--
>  bitbake/lib/bb/taskdata.py                    |  14 +-
>  bitbake/lib/bb/tests/codeparser.py            |  28 +-
>  bitbake/lib/bb/tests/compression.py           |  98 +++
>  bitbake/lib/bb/tests/data.py                  |  95 +--
>  .../debian/pool/main/m/minicom/index.html     |  59 ++
>  bitbake/lib/bb/tests/fetch.py                 | 529 ++++++++++------
>  bitbake/lib/bb/tests/parse.py                 |  20 +-
>  .../bb/tests/runqueue-tests/conf/bitbake.conf |   2 +-
>  bitbake/lib/bb/tests/runqueue.py              |  52 +-
>  bitbake/lib/bb/tests/utils.py                 |  20 +-
>  bitbake/lib/bb/tinfoil.py                     |  12 +-
>  bitbake/lib/bb/ui/buildinfohelper.py          |  83 +--
>  bitbake/lib/bb/ui/knotty.py                   | 100 +--
>  bitbake/lib/bb/ui/taskexp.py                  |   5 +
>  bitbake/lib/bb/ui/uievent.py                  |   6 +-
>  bitbake/lib/bb/ui/uihelper.py                 |   4 +-
>  bitbake/lib/bb/utils.py                       | 118 +++-
>  bitbake/lib/bblayers/action.py                |   2 +-
>  bitbake/lib/bblayers/layerindex.py            |  16 +-
>  bitbake/lib/bblayers/query.py                 |   8 +-
>  bitbake/lib/codegen.py                        |   6 +
>  bitbake/lib/hashserv/__init__.py              |  66 +-
>  bitbake/lib/hashserv/client.py                | 152 +----
>  bitbake/lib/hashserv/server.py                | 549 ++++++++---------
>  bitbake/lib/hashserv/tests.py                 | 161 ++++-
>  bitbake/lib/layerindexlib/__init__.py         |   9 +-
>  bitbake/lib/layerindexlib/cooker.py           |   2 +-
>  bitbake/lib/layerindexlib/restapi.py          |   4 +-
>  bitbake/lib/layerindexlib/tests/restapi.py    |   2 +-
>  bitbake/lib/ply/yacc.py                       |   7 +-
>  bitbake/lib/prserv/client.py                  |  48 ++
>  bitbake/lib/prserv/db.py                      |  65 +-
>  bitbake/lib/prserv/serv.py                    | 540 ++++++----------
>  bitbake/lib/pyinotify.py                      |  44 +-
>  .../bldcontrol/localhostbecontroller.py       |   4 +-
>  .../management/commands/runbuilds.py          |  83 ++-
>  .../migrations/0008_models_bigautofield.py    |  48 ++
>  .../lib/toaster/orm/fixtures/gen_fixtures.py  | 445 +++++++++++++
>  bitbake/lib/toaster/orm/fixtures/oe-core.xml  |  48 +-
>  bitbake/lib/toaster/orm/fixtures/poky.xml     | 118 ++--
>  bitbake/lib/toaster/orm/fixtures/settings.xml |   2 +-
>  .../orm/management/commands/lsupdates.py      |  14 +-
>  .../migrations/0020_models_bigautofield.py    | 173 ++++++
>  bitbake/lib/toaster/orm/models.py             |   5 +-
>  .../toaster/toastergui/templates/base.html    |   2 +-
>  .../toastergui/templates/configvars.html      |   2 +-
>  .../toaster/toastergui/templates/landing.html |   6 +-
>  .../templates/landing_not_managed.html        |  34 -
>  .../toastergui/templates/layerdetails.html    |   2 +-
>  .../templates/package_detail_base.html        |   2 +-
>  .../toaster/toastergui/templates/project.html |   2 +-
>  .../templates/project_specific.html           |   2 +-
>  .../toastergui/templates/projectconf.html     |  34 +-
>  bitbake/lib/toaster/toastergui/views.py       |  22 +-
>  .../management/commands/buildimport.py        |   2 +-
>  bitbake/lib/toaster/toastermain/settings.py   |   3 +
>  bitbake/toaster-requirements.txt              |   2 +-
>  doc/user_manual.md                            |   3 +-
>  meta-isar/classes/rpi-sdimg.bbclass           |   4 +-
>  meta-isar/classes/ubi-ubifs-img.bbclass       |   6 +-
>  meta-isar/conf/distro/raspios-bullseye.conf   |   8 +-
>  meta-isar/conf/distro/ubuntu-focal.conf       |   4 +-
>  meta-isar/conf/local.conf.sample              |   8 +-
>  meta-isar/conf/machine/de0-nano-soc.conf      |   4 +-
>  meta-isar/conf/machine/hikey.conf             |   2 +-
>  meta-isar/conf/machine/phyboard-mira.conf     |   2 +-
>  meta-isar/conf/machine/qemuamd64.conf         |   6 +-
>  meta-isar/conf/machine/qemuarm64.conf         |   2 +-
>  meta-isar/conf/machine/qemuriscv64.conf       |   2 +-
>  meta-isar/conf/machine/stm32mp15x.conf        |   4 +-
>  .../conf/multiconfig/qemuamd64-bullseye.conf  |   2 +-
>  meta-isar/recipes-app/cowsay/cowsay_git.bb    |   2 +-
>  .../recipes-app/hello-isar/hello-isar.bb      |   4 +-
>  meta-isar/recipes-app/libhello/libhello.bb    |   4 +-
>  .../bootconfig-rpi/bootconfig-rpi.bb          |   6 +-
>  .../optee-os/optee-os-stm32mp15x_3.11.0.bb    |   2 +-
>  .../linux/linux-cip_4.4.166-cip29.bb          |   2 +-
>  .../linux/linux-mainline_5.4.70.bb            |   4 +-
>  .../linux/linux-phy_5.10.76-phy4.bb           |   2 +-
>  meta/classes/base.bbclass                     |   1 +
>  meta/classes/dpkg-base.bbclass                |   9 +-
>  meta/classes/dpkg-gbp.bbclass                 |   2 +-
>  meta/classes/dpkg-prebuilt.bbclass            |   2 +-
>  meta/classes/dpkg.bbclass                     |   2 +-
>  meta/classes/image-locales-extension.bbclass  |   2 +
>  meta/classes/image-tools-extension.bbclass    |   1 +
>  meta/classes/image.bbclass                    |  26 +-
>  meta/classes/imagetypes.bbclass               |  27 +-
>  meta/classes/imagetypes_container.bbclass     |   2 +-
>  meta/classes/imagetypes_vm.bbclass            |   8 +-
>  meta/classes/imagetypes_wic.bbclass           |   3 +-
>  meta/classes/rootfs.bbclass                   |   7 +-
>  meta/classes/sdk.bbclass                      |  32 +-
>  meta/classes/sstate.bbclass                   | 247 ++++----
>  meta/conf/bitbake.conf                        |  66 +-
>  meta/conf/distro/debian-common.conf           |  12 +-
>  meta/conf/distro/debian-stretch.conf          |   4 +-
>  meta/lib/oe/gpg_sign.py                       |  33 +-
>  meta/lib/oe/maketype.py                       |   7 +-
>  meta/lib/oe/patch.py                          |  51 +-
>  meta/lib/oe/path.py                           |  77 +++
>  meta/lib/oe/sstatesig.py                      | 118 ++--
>  meta/lib/oe/terminal.py                       |  33 +-
>  meta/lib/oe/utils.py                          |  65 +-
>  meta/recipes-bsp/barebox/barebox.inc          |   2 +-
>  .../libubootenv/libubootenv_0.3-3.bb          |   2 +-
>  meta/recipes-bsp/optee-os/optee-os-custom.inc |   2 +-
>  .../trusted-firmware-a-custom.inc             |   2 +-
>  meta/recipes-bsp/u-boot/u-boot-custom.inc     |   2 +-
>  .../isar-bootstrap/isar-bootstrap.inc         |  14 +-
>  .../buildchroot/buildchroot-host.bb           |   2 +-
>  .../buildchroot/buildchroot.inc               |   6 +-
>  .../sbuild-chroot/sbuild-chroot.inc           |   2 +-
>  meta/recipes-kernel/kselftest/kselftest.inc   |   6 +-
>  meta/recipes-kernel/linux-module/module.inc   |   2 +-
>  meta/recipes-kernel/linux/linux-custom.inc    |  10 +-
>  scripts/contrib/convert-overrides.py          | 143 +++++
>  scripts/isar-buildenv-internal                |   4 +-
>  scripts/isar-sstate                           |  14 +-
>  testsuite/cibuilder.py                        |   8 +-
>  testsuite/citest.py                           |   2 +-
>  194 files changed, 6517 insertions(+), 3255 deletions(-)
>  create mode 100755 bitbake/bin/bitbake-getvar
>  create mode 100644 bitbake/contrib/prserv/Dockerfile
>  create mode 100644 bitbake/lib/bb/asyncrpc/__init__.py
>  create mode 100644 bitbake/lib/bb/asyncrpc/client.py
>  create mode 100644 bitbake/lib/bb/asyncrpc/serv.py
>  create mode 100644 bitbake/lib/bb/compress/_pipecompress.py
>  create mode 100644 bitbake/lib/bb/compress/lz4.py
>  create mode 100644 bitbake/lib/bb/compress/zstd.py
>  create mode 100644 bitbake/lib/bb/fetch2/README
>  create mode 100644 bitbake/lib/bb/fetch2/crate.py
>  create mode 100644 bitbake/lib/bb/tests/compression.py
>  create mode 100644 bitbake/lib/bb/tests/fetch-
> testdata/debian/pool/main/m/minicom/index.html
>  create mode 100644 bitbake/lib/prserv/client.py
>  create mode 100644
> bitbake/lib/toaster/bldcontrol/migrations/0008_models_bigautofield.py
>  create mode 100755 bitbake/lib/toaster/orm/fixtures/gen_fixtures.py
>  create mode 100644
> bitbake/lib/toaster/orm/migrations/0020_models_bigautofield.py
>  delete mode 100644
> bitbake/lib/toaster/toastergui/templates/landing_not_managed.html
>  create mode 100644 scripts/contrib/convert-overrides.py
> 
> --
> 2.17.1
> 
> --
> You received this message because you are subscribed to the Google Groups
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/isar-users/20220715060442.18063-1-
> amikan%40ilbers.de.

  parent reply	other threads:[~2022-07-19 11:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-15  6:04 Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 01/18] meta: change deprecated parse calls Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 02/18] scripts/contrib: Add override conversion script Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 03/18] scripts/contrib: configure " Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 04/18] meta-isar: set default branch names Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 05/18] meta: remove non recommended syntax Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 06/18] bitbake: Update to Bitbake 2.0.1 Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 07/18] doc: require zstd tool Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 08/18] meta: update bitbake variables Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 09/18] bitbake.conf: align hash vars with openembedded Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 10/18] meta: mark network and sudo tasks Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 11/18] meta: update overrides syntax Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 12/18] sstate: update bbclass Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 13/18] bitbake.conf: declare default XZ and ZSTD options Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 14/18] Revert "devshell: Use different termination test to avoid warnings" Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 15/18] meta: align with OE-core libraries update Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 16/18] Revert "Revert "devshell: Use different termination test to avoid warnings"" Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 17/18] CI: Adopt tests to syntax change Anton Mikanovich
2022-07-15  6:04 ` [PATCH v2 18/18] isar-sstate: adopt sstate maintenance script Anton Mikanovich
2022-07-19 11:36 ` Schmidt, Adriaan [this message]
2022-07-19 13:09   ` [PATCH v2 00/18] Migrate to Bitbake 2.0 Anton Mikanovich
2022-07-20  5:26     ` Schmidt, Adriaan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS4PR10MB53186729487A5C0ACD0EBD6AED8F9@AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM \
    --to=adriaan.schmidt@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox