public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Schmidt, Adriaan" <adriaan.schmidt@siemens.com>
To: Srinuvasan Arjunan <srinuvasanasv@gmail.com>,
	isar-users <isar-users@googlegroups.com>
Subject: RE: [PATCH] meta/classes/sdk.bbclass: add --transform in TAR_OPTIONS
Date: Wed, 5 Apr 2023 10:40:26 +0000	[thread overview]
Message-ID: <AS4PR10MB53186A6486653A68A596BD8AED909@AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <06e04599-5749-418f-a162-2e3a9b019150n@googlegroups.com>

[-- Attachment #1: Type: text/plain, Size: 2198 bytes --]

Hi,
Yes, looks better now. This limits the change to the SDK tarball only.
However, I did not test the result, as I don’t really use the Isar SDK Feature.
Maybe someone else can comment whether this change in the SDK tarball could have impact somewhere else.
Thanks,
Adriaan

From: isar-users@googlegroups.com <isar-users@googlegroups.com> On Behalf Of Srinuvasan Arjunan
Sent: Montag, 3. April 2023 12:01
To: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] meta/classes/sdk.bbclass: add --transform in TAR_OPTIONS

   Hi adriaan,

                    Can you please have a look, addressed your comments.

  Thanks,
  Srinuvasan.A
On Friday, March 31, 2023 at 4:03:49 PM UTC+5:30 Srinuvasan Arjunan wrote:
From: Srinuvasan A <srinuv...@mentor.com>

When we untar the SDK rootfs archive file, all the contents are extracted
into the current directory, not a folder, this looks ugly hence fixed
it with the file name transformations option.

Signed-off-by: Srinuvasan A <srinuv...@mentor.com>
---
meta/classes/sdk.bbclass | 1 +
1 file changed, 1 insertion(+)

diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
index 06cae02..50f718c 100644
--- a/meta/classes/sdk.bbclass
+++ b/meta/classes/sdk.bbclass
@@ -53,6 +53,7 @@ ROOTFS_MANIFEST_DEPLOY_DIR:class-sdk = "${DEPLOY_DIR_SDKCHROOT}"
ROOTFS_DPKGSTATUS_DEPLOY_DIR:class-sdk = "${DEPLOY_DIR_SDKCHROOT}"

IMAGE_FSTYPES:class-sdk = "${SDK_FORMATS}"
+TAR_OPTIONS:append:class-sdk = " --transform="s|.|$(basename ${PP_DEPLOY}/${IMAGE_FULLNAME})|""

# bitbake dependencies
SDKDEPENDS += "sdk-files ${SDK_INSTALL}"
--
2.34.1
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com<mailto:isar-users+unsubscribe@googlegroups.com>.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/06e04599-5749-418f-a162-2e3a9b019150n%40googlegroups.com<https://groups.google.com/d/msgid/isar-users/06e04599-5749-418f-a162-2e3a9b019150n%40googlegroups.com?utm_medium=email&utm_source=footer>.

[-- Attachment #2: Type: text/html, Size: 5210 bytes --]

  reply	other threads:[~2023-04-05 10:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31  8:49 Srinuvasan Arjunan
2023-03-31  9:06 ` Schmidt, Adriaan
2023-03-31 10:33   ` Srinuvasan Arjunan
2023-04-03 10:01     ` Srinuvasan Arjunan
2023-04-05 10:40       ` Schmidt, Adriaan [this message]
2023-04-05 10:57     ` Jan Kiszka
2023-04-12 13:38       ` Srinuvasan Arjunan
2023-04-19 14:09         ` [PATCH v2] " Srinuvasan Arjunan
2023-04-24 10:43           ` Srinuvasan Arjunan
2023-05-08 17:57           ` Anton Mikanovich
2023-09-25 10:55           ` Jan Kiszka
2023-09-28  8:26             ` Gylstorff Quirin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS4PR10MB53186A6486653A68A596BD8AED909@AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM \
    --to=adriaan.schmidt@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=srinuvasanasv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox