RE: [PATCH v4 09/21] bitbake.conf: align hash vars with openembedded

["Schmidt, Adriaan" <adriaan.schmidt@siemens.com>]

Anton Mikanovich <amikan@ilbers.de>, Freitag, 5. August 2022 15:21:
> 05.08.2022 16:10, Anton Mikanovich wrote:
> > Restructure and update hash-related variables to be compatible with
> > current Bitbake/Openembedded versions.
> >
> > Based on OE 4.0.1 commit cb8647c08959abb1d6b7c2b3a34b4b415f66d7ee
> >
> > Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> 
> Hello Adriaan,
> 
> Can you please check this patch for signature calculation issues?

The current variables in your patch are identical to OE, except:
- added DEPLOY_DIR, which we currently have in Isar, but which is not necessary (already covered by TMPDIR, and I guess I should have included its removal from the list in 9b52b059)
- added CCACHE_DEBUG, which is Isar-specific (7956c4c63)

Current Isar also has in BB_HASHBASE_WHITELIST:
- LAYERDIR_core
- SCRIPTSDIR
- TOPDIR
- ISAR_BUILD_UUID

I think we still need those.

For easier maintenance in the future I would suggest introducing a new variable:

BB_HASHEXCLUDE_ISAR ?= "CCACHE_DEBUG LAYERDIR_core SCRIPTSDIR TOPDIR ISAR_BUILD_UUID"
BB_HASHEXCLUDE_COMMON ?= "<unmodified list from OE> ${BB_HASHEXCLUDE_ISAR}"
BB_BASEHASH_IGNORE_VARS ?= "<unmodified list from OE>"
BB_HASHCONFIG_IGNORE_VARS ?= "<unmodified list from OE>"

Or:

BB_HASHEXCLUDE_COMMON ?= "<unmodified list from OE>"
BB_HASHEXCLUDE_ISAR ?= "CCACHE_DEBUG LAYERDIR_core SCRIPTSDIR TOPDIR ISAR_BUILD_UUID"
BB_BASEHASH_IGNORE_VARS ?= "${BB_HASHEXCLUDE_COMMON} ${BB_HASHEXCLUDE_ISAR} <rest of the list from OE>"
BB_HASHCONFIG_IGNORE_VARS ?= "${BB_HASHEXCLUDE_COMMON} ${BB_HASHEXCLUDE_ISAR} <rest of the list from OE>"

Not sure which of the two I like better...

Adriaan