From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7057983066489225216 X-Received: by 2002:a05:6214:e68:: with SMTP id jz8mr6386940qvb.124.1643353054275; Thu, 27 Jan 2022 22:57:34 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac8:440e:: with SMTP id j14ls662778qtn.8.gmail; Thu, 27 Jan 2022 22:57:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJwELlCPObE469s9K4ee+fajxFnxCwsCBYTWBDuGaLOlF/CpL/ZIgjrsXh22l/ePC/ZsLTrP X-Received: by 2002:a05:622a:188f:: with SMTP id v15mr5124062qtc.525.1643353053868; Thu, 27 Jan 2022 22:57:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1643353053; cv=pass; d=google.com; s=arc-20160816; b=H7v5bktlVo6rf/t2i27fFCOR1jqWXKfosYlA5cX6DyFkfUTh473KRrKLduS3zf2ire b7OpKELlGGHQunqSTFlLC42WhD+NAHxi674RtgPR/sQGtJHK4hT7Vvn6Q9q7jmXhGJ9r 5vgCQzNi23QXclX7atYhcscjo6v18+9OgKu99546rZRPvRTxxdEconwBuGhPLyn6I0Jg 4kgh5BHg1selxs95TtgLMcSI1lPVXep+a5FAOyOwgQxpq6Y8J36jzqZygO1cPtSXd8Kl iEIR2EMBC4LqiMp0e+Fut265XVLSKR1QllThWzbAOMb2p6wQKt4GSU7QF28QVFBmGaCi daZQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:document_confidentiality :msip_labels:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=Wv4ufX0e6j00cuACIdQWwMjwJAyqKudycEs8gIUfsWs=; b=GmolKUfbHPXFMn+VPrug2FhKC/IUneeG/Ncb7aWI8dHK0gO9IxKvNUKg8qQDWY3RFh 1Ko2mD9AECO2VGDqB0E1pq/58a0m6JMRUFDQjwr48t1575YApJzAfatTlaaD/tZEWEpw 3KvDVl+kVde8m37iQSkvk3Mh3vA3bC4ZI3NyCu/Pslvdm04p6UNhas3cXXER6CycVqZQ hMtxwktC7Tx2WRCcMwodHWKvq+6UkkR6kx0Ff3cLkbc1/31XDQrATrUTxmzyYSes4QiZ pWg/09RwYHlNOS5xyXWjXnGTmoL2Es8tha1i4gdPHCtYq3z/ppPspkaQ5VttkVdFBsI0 Knpg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=j5XUTxhn; arc=pass (i=1); spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 40.107.21.77 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2077.outbound.protection.outlook.com. [40.107.21.77]) by gmr-mx.google.com with ESMTPS id i7si2944392qko.1.2022.01.27.22.57.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jan 2022 22:57:33 -0800 (PST) Received-SPF: pass (google.com: domain of adriaan.schmidt@siemens.com designates 40.107.21.77 as permitted sender) client-ip=40.107.21.77; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=j5XUTxhn; arc=pass (i=1); spf=pass (google.com: domain of adriaan.schmidt@siemens.com designates 40.107.21.77 as permitted sender) smtp.mailfrom=adriaan.schmidt@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i7uCiLdLskNjKAk3baoMO503XaZ7TOO9RV3mR31ODt39v+vyDp5ntVOfqBdDG1J8glrikdw11yM0ncQPhSBgcvTC20/yxQnNl56duZW34LA5pzpPtF4+24rNOXwKuOnQQPw+84EsxHrmj0OCYxBRU17TcPHPR87oiaTV8zB4kGWyYiodBEd81GHmgZ3Ol53+NCpBju1NVL6WW+kIDViDh0Vvu132SvtsLi0flFPMBqBqudDN+nxZgPLw3YmR5cJEnPnP2R8UQF+pTd3UiBjxPjky9wEjNsHnqhnrKHV9F063fWP5skDGn5naKLVCq/QCHd37B8boLFja9o19FAaEdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wv4ufX0e6j00cuACIdQWwMjwJAyqKudycEs8gIUfsWs=; b=WnHrXBNY7LaNAWw24F3winDHO13k8VUmqiNhzuy1SRagaQTjXrCrUfhDXQUvQ1Mcu+EPRBJ66OShWoAg9UvNmz31DqHzv+7t7MOLH2gIp41DpAX6fxWEhPWIJ4K/0X33d0deQIhZHn87ww6TxFdQM6NzJvZNTPkiPqINc5lZ9VVsabmznwAQOIofxDilPy8OAGU/v4IBmd4JjqfCGfm2KECdG2Gv/q/xlM9VL8TCZk+IDn5i8zWkaclzwytFdtBxSxWRQji7cp/6oKnYgESNYnh49Klr6VSHeW6ooXdHiNZ/Hl4kVytZp666/vx7N2K8KzjI/54khAlHPGXKfmF3tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wv4ufX0e6j00cuACIdQWwMjwJAyqKudycEs8gIUfsWs=; b=j5XUTxhnZWZvlmDk6EHkJfLdcLg1NRQbaSfxakOT0kgK770YcA+jmm+6viX+/uSLbTfRdrUk1TuYZn9edQ+6bmET6PjGYL8Ohlc2DVD7KAxUjZSkf/5DjG+tptQF7k7XXvaHfp4WA265ZI3aY6uxKmeFA6V6l0c1Mr2on+tsk7D5i42LKNdiDLg/9meG/Wii5a/52fcyziLo2EkTPoxFvpW9sypQNfyv2svmjHDJhZ16HynNI24D1IyxiyGmJqs6py0BWpZgZg8eg8MeNblygDL8VCeBQXKf70JvCjf1bwKLx2oJklE5aFS+N8NABEz04+WBh89sElfcmCM+skNWLw== Received: from AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:4b8::15) by DB8PR10MB3002.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:38::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.13; Fri, 28 Jan 2022 06:57:31 +0000 Received: from AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM ([fe80::84c:ef9e:baa8:5ab8]) by AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM ([fe80::84c:ef9e:baa8:5ab8%8]) with mapi id 15.20.4909.017; Fri, 28 Jan 2022 06:57:31 +0000 From: "Schmidt, Adriaan" To: "Schild, Henning" , "isar-users@googlegroups.com" CC: "Moessbauer, Felix" Subject: RE: [PATCH 1/1] sttate: change rootfs task to cache Thread-Topic: [PATCH 1/1] sttate: change rootfs task to cache Thread-Index: AQHYE7sdBCmo23t1yUqitbKFZwf8n6x3+BQQ Date: Fri, 28 Jan 2022 06:57:31 +0000 Message-ID: References: <20220127201845.19319-1-henning.schild@siemens.com> <20220127201845.19319-2-henning.schild@siemens.com> In-Reply-To: <20220127201845.19319-2-henning.schild@siemens.com> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Enabled=true; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SetDate=2022-01-28T06:57:29Z; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Method=Standard; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Name=restricted-default; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SiteId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ActionId=40ebf535-90c9-4f6d-b98f-225ec3a8a831; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ContentBits=0 document_confidentiality: Restricted authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f576c808-a7c9-40cd-47b1-08d9e22b7455 x-ms-traffictypediagnostic: DB8PR10MB3002:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OqFvqmXkp26XEqWuAYrT29QUc55dcOhQQArv3k1W7HeSuevNmrofvCqnVGmCiGeu16j3P3NM18Lb2WwFebwRH1g4NZqlqt8cTIvxs/wfZTrYG0E+BUC7SC9L8LVTrNPtKZdRbAEYMUWTT1Y2WFEKNoyfPZwCZxh/M4/UH1W6ksfNxymZHuBfFUTn57DBpEE5y9lOO3BMF/pfobaBOceEH3zfGsI+JocBYdxM+jAJwVmJ8sBlQk2HjH3IKLOnbYEkfaMWG/COv5sERWbAK9HLM8HeTB3CPt363WiBa3eI4NZB5MF5hXZ3iXv0r5NBBmrOt/9kIk14i7ak8odrrAnJtwdc2RVCXGaN7VVrUbDYbuEXyHrEHv7kWOf6UPP5VQDFl1q4FwMr1Gk3dDDAxvVM809GE0Zs3J/FIOOgCkCcQCDRgrtOu3F0e/3+TNhh65BQJp4ooKyN1WKtOJY7wRexMBe7Png5eDkrWXdHTjqoM4DnHGm9eKYHDNIczTQgg8wFweqWBV9RlLKsxLkcJuemGvPIckzFDfB5BWWDV4X2F7/746iGuA6u/La43+buXRtzSOK/cslDyFp4Ct+Bh9ZYvNmbWavFrBCALdAfxYh3XEg4cgmAe0HO/WayJCoVbrSPK3n1Uuk55GYA0IsmaVFuHPJT79gFBqXpRMObYSbBq1j8zaD+X7DHofxqoJXWcAytNw8ufhc4aPVxNXeaDM6IjQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(4636009)(366004)(107886003)(110136005)(82960400001)(8936002)(64756008)(66446008)(66556008)(66476007)(6506007)(66946007)(38070700005)(76116006)(7696005)(38100700002)(316002)(186003)(8676002)(55016003)(83380400001)(2906002)(71200400001)(4326008)(122000001)(33656002)(52536014)(508600001)(5660300002)(9686003)(86362001)(55236004)(26005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?i2/DGfZ/p5Nfh/3BWlCUEgZZC3DNUhi7yN/BLLwwYcmSUztvdgfAcx0piVbf?= =?us-ascii?Q?i3lswf+p2CbAhxcIzmxyyQpJ2vgBtG8V5by0gnblt/M1mYSxc7NTWqvTr+j1?= =?us-ascii?Q?BNR47/rnhy0tnaRD8eKaOvDgQAX8oYWMXQZS72zped8yo+8sg3Vh0COfhPJp?= =?us-ascii?Q?nddWbU2Q17YVNTsxJYVVP9goBGj94et3y4WYXp+ngzLLdib3VtjmJvrC4dBK?= =?us-ascii?Q?xWluWYl7IcLz5+aefY0bG+RiZcjjzh/L3GTeSLQAG8w88pxMeOe5d3CYTC5o?= =?us-ascii?Q?En9VASKuydWivjANYXqM5ZpI7MQKgw7LvLPFebr1jIjaqkmlwhr999jW4qyU?= =?us-ascii?Q?VaRl4PdkrFfndnRqoe4O5K9/gUj2JXQMzK9N7DKFhm3syQRZsGLqO/Z8a4+e?= =?us-ascii?Q?D4tijIWdYh/HhcnJnt3QtDRjk1Wxu73ApU1Oa3Fv9RPkk5Fj2r5qUAoT6dD6?= =?us-ascii?Q?7H0k8zQfbuns6I6lMLK85gCdAR5RS/gmfjg8WaW6VK/y8hQH98llfdi6Wp1r?= =?us-ascii?Q?uUexRMFHsqHCe5Mr492BuTCgLXuRWCOyAIfjuIa9pq6TOjvHdhuoFHAx5+AY?= =?us-ascii?Q?OyT6hTCoBpcw6ESH+NBPv6ORMy4u85YDSB0IFeb4nLDt9oC275jKo5+SriUS?= =?us-ascii?Q?RS2DuFzxG0OQZoezjomKv/3di01z7TmT/xCpq9N4YLX2Tw3A4KEhnq+unxMb?= =?us-ascii?Q?VdLaA7U+K3PxA0Sb41qDUI53zd/y0AgpnTHNMsnj5r8FLznM0+2LeDyZefyC?= =?us-ascii?Q?s7z2VTaPm5RRufD42iStseUlm1VnLS6Ze40/dGzQrfvll1Bh0Dx1i78gVS6E?= =?us-ascii?Q?DDXWqUwy7jsuCM4drLel+makOIQ7fZtpqgVrUihrpGPbry8kihXQNIYx4bbd?= =?us-ascii?Q?nTlUlEI+Vb5V6Mb8fhZLicpZqpFrKS06VOnl5o9PeSW60ZcXQk/SWaLhu+9b?= =?us-ascii?Q?xRc9QW7nlqS4wa+niSeyPwH1soxzZjt/bvqCv4gT4jmBZPZ/sWvPIocvK/2Q?= =?us-ascii?Q?7Ug68E/Ptyl9W8t0w6cT/uD+ywC7XxyQtipVhO2wd4RRA9ghXpio4DygQArl?= =?us-ascii?Q?0FV//WVkl/KlRxCrqV1oIreu4PQJSlggHoI0hh3oZEZHL8gtNYVI1IAqoyg5?= =?us-ascii?Q?M0mMPJ1I2PZG3c2x+bLoVg7SmZM2iXGjsheMAghMSS+UAvov98q2gLsqJe32?= =?us-ascii?Q?VlV1Fc6GUUK8ZNQK4MfVZCiyFzdYKcAIe4PSmit0HsTaaFfgntnowbmfZR8v?= =?us-ascii?Q?UeTKBheX4zHZYOkSk6wK3Ad6oNJhn2zPNYwwxhSUwgNfrFgLUVKVIcT5NPB+?= =?us-ascii?Q?HD4nvPZEra+gkwcjCLsYMansYYHvRi7UkC266Rl5N6pitgUXJRi4BrD/XAm3?= =?us-ascii?Q?O1yBBzYhqxxsrMfvWGMuh8ONkwpmfQA1c3c4olU/E3UF/Fc9ONniyWvsHWF2?= =?us-ascii?Q?ulmRBGl5eDmB+YRwNy6tXzZEtdKLzEDQa/tVICI+L+Dr9EGkwJ2qRLCwoVg5?= =?us-ascii?Q?Lo2AyjnTgSwZzpfuu4PoRM/lv7cdzjIO2MgSjx0gv7vrnYr37eTl+8j8GrhN?= =?us-ascii?Q?XHuED0ebQJGa6xpeMjKyHTA18uZnj1MJaO4FnSC72QGAQU54Iflz+vVNsjLZ?= =?us-ascii?Q?DEI1LoJllWdzPZ5LO89rE5VA642+eJZcdadytzykkUuwAhtxU5ZYHn0o8wTV?= =?us-ascii?Q?64NgoA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: f576c808-a7c9-40cd-47b1-08d9e22b7455 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2022 06:57:31.1915 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PBnxds3S2cvtr//QLCsNe+H6FTr4lawNMeCQa7Kc0C2GNjND1j0XzWrwCW08PqVckRyg09f5uvOZ+m4QRjRJK2PtiIXxGP/oGEIIbIVqAoY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3002 X-TUID: spJvxu7yRwQ7 Schild, Henning (T CED SES-DE), 27. Januar 2022 21:19: > Subject: [PATCH 1/1] sttate: change rootfs task to cache Typo in commit msg -----^ > This patch moves sstate caching from the task "do_rootfs" to > "do_rootfs_install". Which is earlier in the task chain. >=20 > There are two "bugs" that we fix by doing so, while hopefully not > giving up on too much caching speed. > - rootfs_postprocess: > - image_postprocess_mark: potentially outdated BUILD_ID and friends > - rootfs_generate_manifest: manifest file gone missing in DEPLOY_DIR >=20 > Since rootfs_postprocess is kind of an open field it might also fix > issues in ROOTFS_POSTPROCESS_COMMAND functions in layers. Any function > deriving stuff (like a manifest) or changing stuff (like the mark) could > potentially benefit from "not caching". >=20 > Signed-off-by: Henning Schild > --- > meta/classes/rootfs.bbclass | 25 ++++++++++++------------- > 1 file changed, 12 insertions(+), 13 deletions(-) >=20 > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index 1fc487896f4d..e368244ce1ca 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -157,6 +157,7 @@ rootfs_install_pkgs_install() { > do_rootfs_install[root_cleandirs] =3D "${ROOTFSDIR}" > do_rootfs_install[vardeps] +=3D "${ROOTFS_CONFIGURE_COMMAND} > ${ROOTFS_INSTALL_COMMAND}" > do_rootfs_install[depends] =3D "isar-bootstrap-${@'target' if > d.getVar('ROOTFS_ARCH') =3D=3D d.getVar('DISTRO_ARCH') else 'host'}:do_bu= ild" > +do_rootfs_install[depends] +=3D " base-apt:do_cache isar-apt:do_cache_co= nfig" > do_rootfs_install[recrdeptask] =3D "do_deploy_deb" > python do_rootfs_install() { > configure_cmds =3D (d.getVar("ROOTFS_CONFIGURE_COMMAND", True) or > "").split() > @@ -270,29 +271,27 @@ python do_rootfs() { > } > addtask rootfs before do_build >=20 > -do_rootfs[depends] =3D "base-apt:do_cache isar-apt:do_cache_config" You removed that line. I don't remember all of the details, but there were some cases where this explicit dependency was needed when restoring from cache to an empty tmp/ dir. Might need some testing... Adriaan > - > -SSTATETASKS +=3D "do_rootfs" > +SSTATETASKS +=3D "do_rootfs_install" > ROOTFS_SSTATE =3D "${WORKDIR}/rootfs-sstate" > -do_rootfs[dirs] +=3D "${ROOTFS_SSTATE} ${WORKDIR}/mnt/rootfs" > -do_rootfs[cleandirs] +=3D "${ROOTFS_SSTATE}" > -do_rootfs[sstate-plaindirs] =3D "${ROOTFS_SSTATE}" > -do_rootfs[sstate-interceptfuncs] =3D "rootfs_sstate_prepare" > +do_rootfs_install[dirs] +=3D "${ROOTFS_SSTATE} ${WORKDIR}/mnt/rootfs" > +do_rootfs_install[cleandirs] +=3D "${ROOTFS_SSTATE}" > +do_rootfs_install[sstate-plaindirs] =3D "${ROOTFS_SSTATE}" > +do_rootfs_install[sstate-interceptfuncs] =3D "rootfs_install_sstate_prep= are" >=20 > # the buildchroot is owned by root, so we need some sudoing to pack and > unpack > -rootfs_sstate_prepare() { > +rootfs_install_sstate_prepare() { > sudo mount --bind ${WORKDIR}/rootfs ${WORKDIR}/mnt/rootfs -o ro > sudo tar -C ${WORKDIR}/mnt -cpf ${ROOTFS_SSTATE}/rootfs.tar --one-fi= le- > system rootfs > sudo umount ${WORKDIR}/mnt/rootfs > } > -do_rootfs_sstate_prepare[lockfiles] =3D "${REPO_ISAR_DIR}/isar.lock" > +do_rootfs_install_sstate_prepare[lockfiles] =3D "${REPO_ISAR_DIR}/isar.l= ock" >=20 > -rootfs_sstate_finalize() { > +rootfs_install_sstate_finalize() { > sudo tar -C ${WORKDIR} -xpf ${ROOTFS_SSTATE}/rootfs.tar > } >=20 > -python do_rootfs_setscene() { > +python do_rootfs_install_setscene() { > sstate_setscene(d) > - bb.build.exec_func('rootfs_sstate_finalize', d) > + bb.build.exec_func('rootfs_install_sstate_finalize', d) > } > -addtask do_rootfs_setscene > +addtask do_rootfs_install_setscene > -- > 2.34.1