From: "Schmidt, Adriaan" <adriaan.schmidt@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>,
"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: RE: [PATCH] tar: remove duplicated compressing
Date: Wed, 18 May 2022 12:23:26 +0000 [thread overview]
Message-ID: <AS4PR10MB5318B271B21357ACFB6A3349EDD19@AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20220516145733.32589-1-amikan@ilbers.de>
Anton Mikanovic, 16. Mai 2022 16:58:
> If using -z option in IMAGE_CMD_tar call archive will be gzipped and
> then gzipped again after direct gzip run. This will result in wrong
> double-gzipped output file for tar.gz. So remove -z to have correct
> output image.
Nice catch! Yes, this is of course a bug.
Thanks,
Adriaan
>
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
> meta/classes/imagetypes.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/imagetypes.bbclass
> b/meta/classes/imagetypes.bbclass
> index 2838c96..bea5af5 100644
> --- a/meta/classes/imagetypes.bbclass
> +++ b/meta/classes/imagetypes.bbclass
> @@ -8,7 +8,7 @@ IMAGER_INSTALL_tar = "tar"
> TAR_OPTIIONS ?= ""
>
> IMAGE_CMD_tar() {
> - ${SUDO_CHROOT} tar ${TAR_OPTIONS} -cvzf \
> + ${SUDO_CHROOT} tar ${TAR_OPTIONS} -cvf \
> ${IMAGE_FILE_CHROOT} --one-file-system -C ${PP_ROOTFS} .
> }
>
> --
> 2.17.1
next prev parent reply other threads:[~2022-05-18 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 14:57 Anton Mikanovich
2022-05-18 12:23 ` Schmidt, Adriaan [this message]
2022-05-23 14:27 ` Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS4PR10MB5318B271B21357ACFB6A3349EDD19@AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM \
--to=adriaan.schmidt@siemens.com \
--cc=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox