public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Schmidt, Adriaan" <adriaan.schmidt@siemens.com>
To: Srinuvasan Arjunan <srinuvasan_a@mentor.com>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Cc: "amikan@ilbers.de" <amikan@ilbers.de>
Subject: RE: [PATCH] meta/classes/sdk.bbclass: add --transform in TAR_OPTIONS
Date: Fri, 31 Mar 2023 09:06:48 +0000	[thread overview]
Message-ID: <AS4PR10MB5318E440FE0951D717BDEEAFED8F9@AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20230331084952.414690-1-srinuvasan_a@mentor.com>

Srinuvasan Arjunan, Freitag, 31. März 2023 10:50:
> From: Srinuvasan A <srinuvasan_a@mentor.com>
> 
> When we untar the SDK rootfs archive file, all the contents are extracted
> into the current directory, not a folder, this looks ugly hence fixed
> it with the file name transformations option.
> 
> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> ---
>  meta/classes/sdk.bbclass | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
> index 06cae02..56b650a 100644
> --- a/meta/classes/sdk.bbclass
> +++ b/meta/classes/sdk.bbclass
> @@ -11,6 +11,8 @@ inherit crossvars
>  BBCLASSEXTEND = "sdk"
>  BPN = "${PN}"
> 
> +TAR_OPTIONS = "--transform="s|.|$(basename ${PP_DEPLOY}/${IMAGE_FULLNAME})|""
> +

Hi Arjunan,

this will change the tar options globally for all images, not only the SDKs.
You probably want to:
TAR_OPTIONS:class-sdk = "..."

Or even:
TAR_OPTIONS:append:class-sdk = " ..."
                                ^- important space here

The latter would allow other options to be set via configs.

Regards,
Adriaan

>  python sdk_virtclass_handler() {
>      pn = e.data.getVar('PN')
>      if pn.endswith('-sdk'):
> --
> 2.34.1
> 
> --
> You received this message because you are subscribed to the Google Groups
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/isar-users/20230331084952.414690-1-
> srinuvasan_a%40mentor.com.

  reply	other threads:[~2023-03-31  9:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31  8:49 Srinuvasan Arjunan
2023-03-31  9:06 ` Schmidt, Adriaan [this message]
2023-03-31 10:33   ` Srinuvasan Arjunan
2023-04-03 10:01     ` Srinuvasan Arjunan
2023-04-05 10:40       ` Schmidt, Adriaan
2023-04-05 10:57     ` Jan Kiszka
2023-04-12 13:38       ` Srinuvasan Arjunan
2023-04-19 14:09         ` [PATCH v2] " Srinuvasan Arjunan
2023-04-24 10:43           ` Srinuvasan Arjunan
2023-05-08 17:57           ` Anton Mikanovich
2023-09-25 10:55           ` Jan Kiszka
2023-09-28  8:26             ` Gylstorff Quirin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS4PR10MB5318E440FE0951D717BDEEAFED8F9@AS4PR10MB5318.EURPRD10.PROD.OUTLOOK.COM \
    --to=adriaan.schmidt@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    --cc=srinuvasan_a@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox