RE: [RFC PATCH] testsuite: refactor

["Schmidt, Adriaan" <adriaan.schmidt@siemens.com>]

Hi Anton,

Thanks for the feedback.

Anton Mikanovich, 9. Dezember 2021 13:40:
> Test logic itself was moved to cibase to make build_test.py looks pretty
> much like the list of tests and targets.
> It makes target list maintaining much easier and avoid from searching
> though the logic if any target changes needed.
> So it's better to move existing logic from build_test.py to cibase.py,
> but not vice versa.

I get your point, although I don't fully agree.
It adds a layer of abstraction that all arguments must be passed through,
And most of the perform_* functions are only called by one test case.
But I will make another proposal, keeping the original structure.

> Moreover your patch introduce a lot of code duplication. Current
> implementation is also not ideal with it, but it's not a good idea to
> make things even worse.

The only real duplication I introduced was in the repro signed/unsigned
test, which I find hard to read (one condition "if signed", the next
"if not signed", and somehow the gpg key import happens unconditionally,
but could also be that I don't fully understand what the test wants
to do...)

> The user should be able to add any simple new test case without
> copy-pasting, but with inherit some base test classes.
> 
> I also see you've reverted 94e8d23c 'CI: Fix paths for the latest
> Avocado version' which probably will not work with the latest Avocado
> versions.

That was by accident (while removing that --build switch).
Next proposal will preserve that, but rename it to --base, to make the
difference "avocado output base dir" and "bitbake build dir" clear.

Best,
Adriaan