RE: [PATCH 7/9] cibuilder.py: add -S support to the bitbake method

["Larson, Chris" <chris.larson@siemens.com>]

No real reason, I'll update it. Thanks!

-----Original Message-----
From: Moessbauer, Felix (T CED OES-DE) <felix.moessbauer@siemens.com> 
Sent: Wednesday, April 3, 2024 12:13 AM
To: kergoth@gmail.com; isar-users@googlegroups.com
Cc: Larson, Chris (DI CTO FDS CES LX MEL) <chris.larson@siemens.com>; chris.larson@seimens.com
Subject: Re: [PATCH 7/9] cibuilder.py: add -S support to the bitbake method

On Tue, 2024-04-02 at 17:28 +0000, kergoth@gmail.com wrote:
> From: Christopher Larson <chris.larson@seimens.com>
> 
> This allows a test writer to call `bitbake -S none`, to generate 
> signature data in tmp/stamps.

Is there a particular reason why we don't use the long version of the parameters? In case this parameter ever changes, it is much easier to find all locations if the long form is used.

Felix

> 
> Signed-off-by: Christopher Larson <chris.larson@siemens.com>
> ---
>  testsuite/cibuilder.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py index 
> fa30c2f5..e968d14d 100755
> --- a/testsuite/cibuilder.py
> +++ b/testsuite/cibuilder.py
> @@ -188,7 +188,7 @@ def move_in_build_dir(self, src, dst):
>          if os.path.exists(self.build_dir + '/' + src):
>              shutil.move(self.build_dir + '/' + src, self.build_dir + 
> '/' + dst)
>  
> -    def bitbake(self, target, bitbake_cmd=None, **kwargs):
> +    def bitbake(self, target, bitbake_cmd=None, sig_handler=None,
> **kwargs):
>          self.check_init()
>         
> self.log.info('===================================================')
>          self.log.info('Building ' + str(target)) @@ -200,6 +200,9 @@ 
> def bitbake(self, target, bitbake_cmd=None,
> **kwargs):
>          if bitbake_cmd:
>              cmdline.append('-c')
>              cmdline.append(bitbake_cmd)
> +        if sig_handler:
> +            cmdline.append('-S')
> +            cmdline.append(sig_handler)
>          if isinstance(target, list):
>              cmdline.extend(target)
>          else:
> --
> 2.39.2
> 

-- 
Siemens AG, Technology
Linux Expert Center