From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6592507174472122368 X-Received: by 2002:a1c:487:: with SMTP id 129-v6mr28127wme.22.1535791498588; Sat, 01 Sep 2018 01:44:58 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:afda:: with SMTP id y26-v6ls3534268wrd.3.gmail; Sat, 01 Sep 2018 01:44:58 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaeHo0bm0sQlsvmzOGzzck38PvqbiVRWeRnNaZJLn6QTJ0y0dMvrqii4Z26Ih04RNMUfv9p X-Received: by 2002:a5d:52c1:: with SMTP id r1-v6mr1663622wrv.0.1535791498237; Sat, 01 Sep 2018 01:44:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535791498; cv=none; d=google.com; s=arc-20160816; b=vt2cY6B+j4PLfdPdei5haYZKnLELKrYKFxOTDrtz6KZPbz1MDLyWY1k3bB+Pt0gGhk 4kLPGvfLEI+oIc4hGDxwtonAszwgWVmBlLsj9gYiCIgvXwkg8Eo/nMf0mP0HkDpymmAb kf2JiMKiQVNq01Zrz5/JPqy9tk4+SscV9heGObWK1EXU6uTUcC7BeejxBquZFpyzbPDA KPuL0Wzj1Jabhyes7Nk6Qtt9yZX43MgWRpbRyARZeZsjiqKVs/ZNbIXYZQJsA+ado+Tu MfIl5QJEpL1hjafnLCpmb1l7vmWRv8X15nbfN20JkJf4LZpt0zzKV8zU1ijsVABqMfyn C9lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:dkim-signature:arc-authentication-results; bh=rCHIalhtuc2dr3gTh+mo5gGcSoamP/GOVZzQDQWUwss=; b=ZJGoU9BorXmijiT+PNC5DT56xUVgp/+0v34qifXKTZZk2+7mvBRT5XMgBy74q7g8kQ Hi7Slb7kpEWPqJXrW29VQPw7NI/9l3ww2EK9H8sXuJL8QyVuzIIZdlojqsJc/wDTANzz 4LJieqYv+s6ZD6ug3eNC2xiXqFh057/j/g4692tNaYsiKd5j/Ha+a+Z18w/aRXx1HGkL xCQao5VSYlq6LF4GTIXwfcPoo9aCXgoOwlpU19k8m3+/CNifMKB4fOS1rqdQf8VM0xiV yvpimXQlUFNhw2TDlP+bqys0a1vCZHwsHmaRb9YY608C9lNOmexftA5OsVzgfXCO0obJ KCKA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DaG1PuSL; spf=pass (google.com: domain of chombourger@gmail.com designates 2a00:1450:4864:20::42b as permitted sender) smtp.mailfrom=chombourger@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com. [2a00:1450:4864:20::42b]) by gmr-mx.google.com with ESMTPS id x7-v6si208677wmh.0.2018.09.01.01.44.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Sep 2018 01:44:58 -0700 (PDT) Received-SPF: pass (google.com: domain of chombourger@gmail.com designates 2a00:1450:4864:20::42b as permitted sender) client-ip=2a00:1450:4864:20::42b; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DaG1PuSL; spf=pass (google.com: domain of chombourger@gmail.com designates 2a00:1450:4864:20::42b as permitted sender) smtp.mailfrom=chombourger@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-wr1-x42b.google.com with SMTP id v90-v6so13215482wrc.0 for ; Sat, 01 Sep 2018 01:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=rCHIalhtuc2dr3gTh+mo5gGcSoamP/GOVZzQDQWUwss=; b=DaG1PuSLN+alY1LYknQHbDpob/5wzz4fDXAciA88MCcVTo/gCZ6CXXntAfEaW7doDB /9NTVJCBL4v0nsIUPhL57tRIJbQSjcbDP6EZF3c5J1JBsOqhK60QQ6MLGRwjY7IR9NpA VPPkeKFkZK1MUqvQ0KPG2O6zkJ9GDmFwi2bSVSqRkrZOnZrEz79qcr+QOr/U4CRB0vwJ t7upJIbWCCVt5X7Q1rlunavV1dtskRvWUa77zJNp4UFzwc31HpYa7fi6paP+hMwGBRL4 8UcAaOmhAimlMo+KzrMnnDE+qQmAtIF4dXrr28zqDK+VbRfI64erXjHSIEdFTJxIvN2x Hv8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=rCHIalhtuc2dr3gTh+mo5gGcSoamP/GOVZzQDQWUwss=; b=YyVgQb01by+V+mCmBlPMOio8q2coGexit6DUu4XBIRrHYyrCuiedBkWkOSVA3AOwYv hRNtw02ABJHgyCtTnu/2umK9CrbH1P1swLPyEh2ZSq7HO81QErebyRgifVw7FSuRfxXY cZAOiHzv6bzNy44k6cVh2gMQyg5EzU/pjzCrysU6HxZ+E/2QmHOD9I+aBwhJ4nAR4tk/ XpbKETW8bZ0JQ6ZnCwsq1TYyWw4pPASx/Fp8suU1LVTxIXBbs1uLPXwx1/Mb1sbGAJxh a2FMx3OX3e6AvPXFiMD/uEegWsHHmVnd1awiSqVQ1PwLwAKAP59HTLQsLHyNI7Ug7dyy 2FqQ== X-Gm-Message-State: APzg51CHj54qm2R9KWlSM95tmw0mafEzLxhgL6i2CDO8eyGl9HoZ3qCb 8vUtgxGnZAX61CE7Fj8xdRw= X-Received: by 2002:adf:c890:: with SMTP id k16-v6mr13645189wrh.6.1535791497844; Sat, 01 Sep 2018 01:44:57 -0700 (PDT) Return-Path: Received: from cedric-mbp.lan (59.33.14.81.rev.sfr.net. [81.14.33.59]) by smtp.gmail.com with ESMTPSA id 139-v6sm10643502wmp.4.2018.09.01.01.44.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Sep 2018 01:44:56 -0700 (PDT) From: Cedric Hombourger Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_787E4CE9-0D4F-49EF-856D-BFB401F47D13" Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [PATCH v3 1/3] dpkg: move installation of dependencies into dpkg_prepare Date: Sat, 1 Sep 2018 10:44:51 +0200 In-Reply-To: <5dcaa3ae-76be-b3b5-e1b5-926783bf9808@web.de> Cc: isar-users , Maksim Osipov To: Jan Kiszka References: <20180822154145.07d4a2ca@md1pvb1c.ad001.siemens.net> <1535264488-128-1-git-send-email-Cedric_Hombourger@mentor.com> <3681e5f1-6401-4453-980b-585049d14329@googlegroups.com> <1e560261-edee-203b-db74-4ed5d1a35541@siemens.com> <78c2e4d4-6fff-c312-323e-582b961460d5@siemens.com> <5dcaa3ae-76be-b3b5-e1b5-926783bf9808@web.de> X-Mailer: Apple Mail (2.3445.9.1) X-TUID: SmAO/GQkA7su --Apple-Mail=_787E4CE9-0D4F-49EF-856D-BFB401F47D13 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi Jan, Please let me know if there is anything that I can help you with I was going to review existing documentation and propose updates around = recipe creation / APIs Cedric > On Sep 1, 2018, at 8:58 AM, Jan Kiszka wrote: >=20 > On 2018-08-31 11:05, [ext] Jan Kiszka wrote: >> On 2018-08-31 10:41, Jan Kiszka wrote: >>> On 2018-08-31 10:33, chombourger@gmail.com wrote: >>>>=20 >>>>=20 >>>> On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan Kiszka wrote: >>>>=20 >>>> Re-reading the patch with my new knowledge: >>>>=20 >>>> On 2018-08-26 08:21, Cedric Hombourger wrote: >>>> > diff --git a/meta/recipes-kernel/linux-module/module.inc >>>> b/meta/recipes-kernel/linux-module/module.inc >>>> > index 3075f44..3a3cab1 100644 >>>> > --- a/meta/recipes-kernel/linux-module/module.inc >>>> > +++ b/meta/recipes-kernel/linux-module/module.inc >>>> > @@ -17,7 +17,7 @@ AUTOLOAD ?=3D "0" >>>> > >>>> > inherit dpkg >>>> > >>>> > -dpkg_runbuild_prepend() { >>>> > +do_prepare_prepend() { >>>>=20 >>>> Shouldn't that be dpgk_prepare_append()? >>>>=20 >>>>=20 >>>> Wouldn't it be too late? >>>> I am afraid that debian/control wouldn't be complete and prevent = installation of build dependencies >>>>=20 >>>=20 >>> Right, we need that for the installation... >>>=20 >>> I was wondering, though, if it wouldn't be cleaner to hook additions = to the inner handler. >>>=20 >>> Anyway, all this is not mature yet: >>>=20 >>> - debianization does not require locking, only the dependency >>> installation does >>>=20 >>> - I'm quite sure something is broken now with dpkg-raw, because = there is >>> no lock involved, but we can pull packages that way as well >>>=20 >> Yep, confirmed: We so far installed the dependencies of both regular = and raw packages in the build script under the lock. Now you pulled that = installation into deps.sh, but that script is not executed by dpkg-raw, = nor is there any lock on the related prepare step. >> Can we fix this quickly? Or better revert and redo the series (given = the other issues)? >=20 > I have to correct myself: dpkg-raw packages only have runtime = dependencies, no Build-Depends. Thus they never installed anything into = the buildchroot and also never used the build script - we are fine in = this regard. >=20 > I'll write a few patches to address the other issues. >=20 > Jan >=20 >> Jan >>> - we should cleanly name the steps, as you suggested, so that users = know >>> what to overwrite / append /prepend >>>=20 >>> Jan --Apple-Mail=_787E4CE9-0D4F-49EF-856D-BFB401F47D13 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Hi = Jan,

Please let me = know if there is anything that I can help you with
I = was going to review existing documentation and propose updates around = recipe creation / APIs

Cedric

On Sep 1, 2018, at 8:58 AM, Jan = Kiszka <jan.kiszka@web.de> wrote:

On 2018-08-31 11:05, [ext] Jan = Kiszka wrote:
On = 2018-08-31 10:41, Jan Kiszka wrote:
On 2018-08-31 10:33, chombourger@gmail.com= wrote:


On Friday, August 31, 2018 at 10:28:51 AM = UTC+2, Jan Kiszka wrote:

    Re-reading the patch with = my new knowledge:

    On 2018-08-26 08:21, Cedric = Hombourger wrote:
     > diff --git = a/meta/recipes-kernel/linux-module/module.inc
    b/meta/recipes-kernel/linux-m= odule/module.inc
     > index 3075f44..3a3cab1 = 100644
     > --- = a/meta/recipes-kernel/linux-module/module.inc
     > +++ = b/meta/recipes-kernel/linux-module/module.inc
     > @@ -17,7 +17,7 @@ = AUTOLOAD ?=3D "0"
     >
     >   inherit dpkg
     >
     > = -dpkg_runbuild_prepend() {
     > +do_prepare_prepend() = {

    Shouldn't that be = dpgk_prepare_append()?


Wouldn't it be too late?
I am afraid that = debian/control wouldn't be complete and prevent installation of build = dependencies


Right, we need that for the installation...

I was wondering, though, if it wouldn't be cleaner to hook = additions to the inner handler.

Anyway, all = this is not mature yet:

- debianization = does not require locking, only the dependency
   installation does

- I'm quite sure something is broken now with = dpkg-raw, because there is
   no lock involved, but we = can pull packages that way as well

Yep, confirmed: We so far installed the = dependencies of both regular and raw packages in the build script under = the lock. Now you pulled that installation into deps.sh, but that script = is not executed by dpkg-raw, nor is there any lock on the related = prepare step.
Can we fix this quickly? Or better revert = and redo the series (given the other issues)?

I have to correct myself: dpkg-raw packages only have runtime = dependencies, no Build-Depends. Thus they never installed anything into = the buildchroot and also never used the build script - we are fine in = this regard.

I'll write a = few patches to address the other issues.

Jan

Jan
- we should cleanly name the steps, as you = suggested, so that users know
   what to overwrite / append = /prepend

Jan

= --Apple-Mail=_787E4CE9-0D4F-49EF-856D-BFB401F47D13--