From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7221105623410147328 X-Received: by 2002:a92:4b0e:0:b0:316:ff39:6bbf with SMTP id m14-20020a924b0e000000b00316ff396bbfmr412809ilg.6.1681369761965; Thu, 13 Apr 2023 00:09:21 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6e02:1101:b0:317:97e2:9054 with SMTP id u1-20020a056e02110100b0031797e29054ls12460852ilk.4.-pod-prod-gmail; Thu, 13 Apr 2023 00:09:21 -0700 (PDT) X-Google-Smtp-Source: AKy350YnYBsGLiqiEQv5K1VUORqpQCwWD8X76E6GF8GwIUeDks3hpXaGQJvsBd0XwL13RQpV/wrf X-Received: by 2002:a92:c80d:0:b0:326:2c59:276b with SMTP id v13-20020a92c80d000000b003262c59276bmr602014iln.15.1681369761420; Thu, 13 Apr 2023 00:09:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681369761; cv=none; d=google.com; s=arc-20160816; b=nas+TtgXqr70umdYKnAgVyAP+/Fco/gnht9WE7iAJmZVeUN+uZ87kmngrAeNWVep38 /tGnKwHKb72CjQLH9m+4g4rZQQiceRQ6C0CStWnj8gZm9hAl56AnYyQR8Ycwfr6DP9O9 EQiIm19FCAN2H+n/5qJu+WzCeyBQn4SHKc8GWWYBeO8sZgc6Irex47zudQxrNQ64uBPl toZ7Bm9CoX1UHEw4bX4zFh136bLqZSDyHMeYS6DzTMz9Cln/cV3vZwBcWB6Kfb1fFIea n6BSd7sY+dgyyfFgnAhxrygJ4J1LRResNa/ROsMEglpQT1wgq9GSoDvAlV04CXw/Qe+9 JK9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=lZgKopX5dfaA5JMA5u7sqmIs1gIKo7jKtSH1rHwxN+c=; b=mRJd7GJ3D1hl0rNbyZ3mJTcCPbz3SD840197E6WX+Nar8Rw7HJOcRApCxTO3sAyNbw EC/evaWY5r5RadumEPTDQH9bToSH/TWRxKBgaJ1y1luNN1oDMK8eE4KXLqU9L9ooAmwS OQubo3Qn7uQkb8jZcT4j/MDgzOC0Kn37bx6thA0graIs7P690Kz7CoytZSdQhZjwVkI/ KfvBT/zNJ1+CAAtDkjb4T99wp85ZWgUqRvbE1UzCaPaVegHWFdEShec0nYe30WPlcJ5X Ii1+llrPNiulFyNSMhXLkEKUeHWU6sanSaX2D9GnNRUEORjQYpx1v6ueNbJJmBiF2pG7 t13A== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="GW5/UYEE"; spf=pass (google.com: domain of srinuvasanasv@gmail.com designates 2607:f8b0:4864:20::934 as permitted sender) smtp.mailfrom=srinuvasanasv@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com. [2607:f8b0:4864:20::934]) by gmr-mx.google.com with ESMTPS id 10-20020a056e0211aa00b0032654420073si57612ilj.1.2023.04.13.00.09.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Apr 2023 00:09:21 -0700 (PDT) Received-SPF: pass (google.com: domain of srinuvasanasv@gmail.com designates 2607:f8b0:4864:20::934 as permitted sender) client-ip=2607:f8b0:4864:20::934; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="GW5/UYEE"; spf=pass (google.com: domain of srinuvasanasv@gmail.com designates 2607:f8b0:4864:20::934 as permitted sender) smtp.mailfrom=srinuvasanasv@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-ua1-x934.google.com with SMTP id r10so1169447uat.6 for ; Thu, 13 Apr 2023 00:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681369761; x=1683961761; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lZgKopX5dfaA5JMA5u7sqmIs1gIKo7jKtSH1rHwxN+c=; b=GW5/UYEEKA6oiAqGA9ZhcbicAVTZmiQZxmX1gOL/xKurBLYqqTSVGOB11Y3Y8YpPNE UspIrXpxtDIcbYxjcQs4hEEWJUAL0IQ5+vHull/8XxZsMoHAYWcxVY9HYaczdQ0TMXnw 46LvOgUnK6PN10waCSS5q9vGJGU9Ixa6RNXJ4Ey12eMvHKLwLbu2cI0N60YW+AyaOoy7 mHjMMguZF3GRA6jTSsbo/e0ehglY41kxLsyMC9SciYcd2BAPoIzso2siiNaif+niToov 5NzDCEBqp+EIcvORHFdAUfndBhXG78oMoIIg5+O2IsIc0xNsE7aYolpJYDKZU4cZ6RpA LgXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681369761; x=1683961761; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lZgKopX5dfaA5JMA5u7sqmIs1gIKo7jKtSH1rHwxN+c=; b=HxJeTpCkiYpF3ZPkb4aA1Bc7URGnhT0HStkRjejARAyhwkC4y6RWuuZR3UToSBrcMX gThiZ2gLswwqiZiw3dFCMlDqi/78UtA0v5Po6Odyqbpg1m3oKD23N3RVWro15x3PpYiZ dCGYT/GKYrhuyzgk05AGuwV4EFyvDqaXGt9aP9khw0pLMKS7pXYfAZ90kOpcMwlVxZ2t a0riEkKpyWAJDFa6RRzUbDd/MOD5X5RS3hC43WSLee/NsNe65Rv7Kia+QeiSO2IYsN7s JwZQ8/ZS/skOI8P/gqK7A71wZWrI0U+14/fa5JycubZn8ovU5JOQFAeQ15vdpwoVHbsR 0/zA== X-Gm-Message-State: AAQBX9eeSWQ3R8wCXHo+KDDct5/wbUBQRToifVQSyiB9gTPrKki8FMOI lJbJklZtFMWYsG5+u9L2HbnotYF0i+soPPdsjH+kMv8lot0= X-Received: by 2002:ab0:5b54:0:b0:772:4a2:62af with SMTP id v20-20020ab05b54000000b0077204a262afmr585869uae.1.1681369760789; Thu, 13 Apr 2023 00:09:20 -0700 (PDT) MIME-Version: 1.0 References: <20230412101721.682675-1-srinuvasan_a@mentor.com> <1e8a8cb1-68e6-be14-0d42-13a8a5ff1dea@siemens.com> In-Reply-To: <1e8a8cb1-68e6-be14-0d42-13a8a5ff1dea@siemens.com> From: Srinuvasan Arjunan Date: Thu, 13 Apr 2023 12:39:09 +0530 Message-ID: Subject: Re: [PATCH] meta/conf/bitbake.conf: enable SRCPV support for AUTOREV To: Jan Kiszka Cc: Srinuvasan Arjunan , isar-users@googlegroups.com Content-Type: multipart/alternative; boundary="00000000000053f82205f9326768" X-TUID: WdbELWDT7f5g --00000000000053f82205f9326768 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 13, 2023 at 12:32=E2=80=AFPM 'Jan Kiszka' via isar-users < isar-users@googlegroups.com> wrote: > On 12.04.23 12:17, Srinuvasan Arjunan wrote: > > From: Srinuvasan A > > > > One of our downstream project recipe uses `SRCREV =3D "${AUTOREV}"` to = get > > the latest changes always, but this not works after bitbake 2 migration= , > > it throws the below error. > > > > do_fetch: Fetcher failure: Recipe uses a floating tag/branch without a > fixed SRCREV yet doesn't call bb.fetch2.get_srcrev() (use SRCPV in PV for > OE). > > > > Till now we don't have support for SRCPV in ISAR, hence add this suppor= t > > as like OE. > > > > Signed-off-by: Srinuvasan A > > --- > > meta/classes/base.bbclass | 2 ++ > > meta/conf/bitbake.conf | 4 ++++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass > > index 53550ae..cc2b195 100644 > > --- a/meta/classes/base.bbclass > > +++ b/meta/classes/base.bbclass > > @@ -120,6 +120,8 @@ root_cleandirs() { > > python() { > > import re > > > > + d.setVar("SRCPV", "${@bb.fetch2.get_srcrev(d)}") > > + > > This is likely not correct. OE upstream checks if there is any SCM in > the SRC_URI entries and only then adds this. I've played with > unconditionally adding SRCPV (though via bitbake.conf), and I got errors. > > Jan > Sure jan, will check and send the next version. > > > for e in d.keys(): > > flags =3D d.getVarFlags(e) > > if flags and flags.get('task'): > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > > index f421050..124bf49 100644 > > --- a/meta/conf/bitbake.conf > > +++ b/meta/conf/bitbake.conf > > @@ -36,6 +36,10 @@ PR =3D "${@bb.parse.vars_from_file(d.getVar('FILE', > False),d)[2] or 'r0'}" > > PROVIDES =3D "" > > S =3D "${WORKDIR}/${P}" > > AUTOREV =3D "${@bb.fetch2.get_autorev(d)}" > > +AUTOREV[vardepvalue] =3D "${SRCPV}" > > +# Set Dynamically in base.bbclass > > +# SRCPV =3D "${@bb.fetch2.get_srcrev(d)}" > > +SRCPV[vardepvalue] =3D "${SRCPV}" > > SRC_URI =3D "" > > STAMPS_DIR ?=3D "${TMPDIR}/stamps" > > STAMP =3D "${STAMPS_DIR}/${DISTRO}-${DISTRO_ARCH}/${PN}/${PV}-${PR}" > > -- > Siemens AG, Technology > Competence Center Embedded Linux > > -- > You received this message because you are subscribed to the Google Groups > "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to isar-users+unsubscribe@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/isar-users/1e8a8cb1-68e6-be14-0d42-13a8= a5ff1dea%40siemens.com > . > --00000000000053f82205f9326768 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Apr 13, 2023 at 12:32=E2=80= =AFPM 'Jan Kiszka' via isar-users <isar-users@googlegroups.com> wrote:
On 12.04.23 12:17, Srinuvasan = Arjunan wrote:
> From: Srinuvasan A <srinuvasan_a@mentor.com>
>
> One of our downstream project recipe uses `SRCREV =3D "${AUTOREV}= "` to get
> the latest changes always, but this not works after bitbake 2 migratio= n,
> it throws the below error.
>
> do_fetch: Fetcher failure: Recipe uses a floating tag/branch without a= fixed SRCREV yet doesn't call bb.fetch2.get_srcrev() (use SRCPV in PV = for OE).
>
> Till now we don't have support for SRCPV in ISAR, hence add this s= upport
> as like OE.
>
> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> ---
>=C2=A0 meta/classes/base.bbclass | 2 ++
>=C2=A0 meta/conf/bitbake.conf=C2=A0 =C2=A0 | 4 ++++
>=C2=A0 2 files changed, 6 insertions(+)
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index 53550ae..cc2b195 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -120,6 +120,8 @@ root_cleandirs() {
>=C2=A0 python() {
>=C2=A0 =C2=A0 =C2=A0 import re
>=C2=A0
> +=C2=A0 =C2=A0 d.setVar("SRCPV", "${@bb.fetch2.get_srcr= ev(d)}")
> +

This is likely not correct. OE upstream checks if there is any SCM in
the SRC_URI entries and only then adds this. I've played with
unconditionally adding SRCPV (though via bitbake.conf), and I got errors.
Jan

=C2=A0 =C2=A0 Sure jan, will check = and send the next version.=C2=A0

>=C2=A0 =C2=A0 =C2=A0 for e in d.keys():
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 flags =3D d.getVarFlags(e)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if flags and flags.get('task'= ;):
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index f421050..124bf49 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -36,6 +36,10 @@ PR =3D "${@bb.parse.vars_from_file(d.getVar(&#= 39;FILE', False),d)[2] or 'r0'}"
>=C2=A0 PROVIDES =3D ""
>=C2=A0 S =3D "${WORKDIR}/${P}"
>=C2=A0 AUTOREV =3D "${@bb.fetch2.get_autorev(d)}"
> +AUTOREV[vardepvalue] =3D "${SRCPV}"
> +# Set Dynamically in base.bbclass
> +# SRCPV =3D "${@bb.fetch2.get_srcrev(d)}"
> +SRCPV[vardepvalue] =3D "${SRCPV}"
>=C2=A0 SRC_URI =3D ""
>=C2=A0 STAMPS_DIR ?=3D "${TMPDIR}/stamps"
>=C2=A0 STAMP =3D "${STAMPS_DIR}/${DISTRO}-${DISTRO_ARCH}/${PN}/${P= V}-${PR}"

--
Siemens AG, Technology
Competence Center Embedded Linux

--
You received this message because you are subscribed to the Google Groups &= quot;isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-= users/1e8a8cb1-68e6-be14-0d42-13a8a5ff1dea%40siemens.com.
--00000000000053f82205f9326768--