From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7221105623410147328 X-Received: by 2002:a1f:ac0e:0:b0:43f:e092:93b6 with SMTP id v14-20020a1fac0e000000b0043fe09293b6mr2740720vke.1.1681463545782; Fri, 14 Apr 2023 02:12:25 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1f:9884:0:b0:43c:4909:450 with SMTP id a126-20020a1f9884000000b0043c49090450ls4604670vke.9.-pod-prod-gmail; Fri, 14 Apr 2023 02:12:25 -0700 (PDT) X-Google-Smtp-Source: AKy350Z1elBWwYs4asV1qotkxnRf5BxnaEAiZ18g7qjjPBcGW0kXk8Wweroy8OPvcK1iHfyOLKq3 X-Received: by 2002:a1f:4106:0:b0:43f:e323:88f9 with SMTP id o6-20020a1f4106000000b0043fe32388f9mr1701998vka.0.1681463545057; Fri, 14 Apr 2023 02:12:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681463545; cv=none; d=google.com; s=arc-20160816; b=en37t9/7Roqo0xdNCb5WaH3K/Pl1rZvMnauAehZA22KRvmckgmMilOS4mq3Sxpn01F bZ1ts/5V8P5Fn4HuyXkN6cTSPRJnfB9Fi2Z53rN4tyF6n2P8NPFzZkqZQZgX7FeUl81f ly36j2XT9sBwxnEoB/pE6Qhl1IRew0fUbaHqgeRDKPnOubyFmyyZUpptOOabonWOMsjc aenMniiDL+RGD1OFOQVNv5Lg4iaEBvOZTPnQte04kk6bTXCdvIO5GhSmFehGlXx0d3+z hWsDyLAZtr+EIJ+zPUMGOzhQO6zboha35m/oEiHEsbgLzYtE8tNDJGuya8jFvZcV0eBu GGXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=XQWifgnfDS8xB/cXRUZhezpyRzzFgyWWplfKeXJAZPs=; b=QxAarOl5va9aZZlb0C7hbLJnmDrbD+hXaowgVNNRIGo06TW9dOXg4c6SDxD2sXv3ie /yyhtLOJ9j34jlVkycgNQBL19MFRy8ZAo1YI1B49rg4f7imVNHBVxCcZdtZog2gUCf8i 6f5bZ/gI0tA8ekreXdV+W/jlg9ZiFmnBLFoVJ6Y5eKRaqKJLRonMAIFM4ZWzJ3n6Odyg gyKWWqJrNasd7USpEtXjYyvkgyYJqIWpVqen31YFCpTjkITpuEmgquzTIoyVpGm9ML2i elCkAq/SDirgx9YDGFzDbW8jRKqRqCh3TL02vl0LyigaLckznVPKL2YziWb6ytg8scxm W6ig== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=MG4aE71h; spf=pass (google.com: domain of srinuvasanasv@gmail.com designates 2607:f8b0:4864:20::931 as permitted sender) smtp.mailfrom=srinuvasanasv@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-ua1-x931.google.com (mail-ua1-x931.google.com. [2607:f8b0:4864:20::931]) by gmr-mx.google.com with ESMTPS id l24-20020ac5cdb8000000b0043fa939cd42si250081vka.0.2023.04.14.02.12.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 02:12:25 -0700 (PDT) Received-SPF: pass (google.com: domain of srinuvasanasv@gmail.com designates 2607:f8b0:4864:20::931 as permitted sender) client-ip=2607:f8b0:4864:20::931; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=MG4aE71h; spf=pass (google.com: domain of srinuvasanasv@gmail.com designates 2607:f8b0:4864:20::931 as permitted sender) smtp.mailfrom=srinuvasanasv@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-ua1-x931.google.com with SMTP id x8so3957215uau.9 for ; Fri, 14 Apr 2023 02:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681463545; x=1684055545; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XQWifgnfDS8xB/cXRUZhezpyRzzFgyWWplfKeXJAZPs=; b=MG4aE71hOF/vMHOfoKm62CB0mswiFZqkOC9GzJmhMl2zWPLgeDs2lvA8OMqFwenlGv ApGJWN37EtN1HTB6pb54IacJuiSJW9fkB6XmVN/BG4ewH8Om+lR6azRB0+xLUMIZH09E HfsI1B4W2PDS9nbDoHPc1vjortbsdy+H7AHfe/yaV7e2qWxO97a+fcc+QsdvH5tR5avm 4lVBpQtSdrxwSxBlzcYCqdkx3z5EOxGrciL5rNXw/re5m+o4H/EofGQ3ZSBvuhLpJk+g 9hLc80Qi7pOBywBddwYGl16s0Pk2uu3oJqaW//SeFqGMzK1OFfb/3hWZpTtrAzf6QAMu RVWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681463545; x=1684055545; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XQWifgnfDS8xB/cXRUZhezpyRzzFgyWWplfKeXJAZPs=; b=ZI6ZvUDR25drotuYxleBpvsy7xZWPrvSrJ2S+LJQA3FZdXBX1u3fKqvyE3nEvMCvTe Th/8o1olDpKwptc2Jo5HUeZxQVIDudkRbshqU73uog91u+g0CrP8APqOo0zpHW97rlqg VUA6sqrPHukHpDJuixejPDI+L9A/zHYxtQF9MmNtySBL091nE5ha6nI9TKB517oAuP27 dYhdW0ETjpVM+Wy1OqXqAI/E35HR95UY3iz89+Tl/ZLeyMCpKJqEYkQigboDqoODsGrn B/u2tADjIEiF7t4uXIX5Aq4PU+ygTX0Jt9aa13CVeWi1otu6e01h31Vr9LKxLIXBxP81 XsTQ== X-Gm-Message-State: AAQBX9cMAD0bPnbx2UOiF8ljS6At0wdtq/c+CT9w5BsGuB+TcTOAkdg8 1bcmFHmaC9k8vkAANwk9bDfzL4buY65mBWE3FlUw6Hx9V38= X-Received: by 2002:a1f:ad91:0:b0:43f:df8d:cfe2 with SMTP id w139-20020a1fad91000000b0043fdf8dcfe2mr2546633vke.2.1681463544394; Fri, 14 Apr 2023 02:12:24 -0700 (PDT) MIME-Version: 1.0 References: <20230414085742.844733-1-srinuvasan_a@mentor.com> In-Reply-To: From: Srinuvasan Arjunan Date: Fri, 14 Apr 2023 14:42:13 +0530 Message-ID: Subject: Re: [PATCH] meta/conf/bitbake.conf: enable SRCPV support for AUTOREV To: Jan Kiszka Cc: Srinuvasan Arjunan , isar-users@googlegroups.com Content-Type: multipart/alternative; boundary="00000000000044370905f9483d5d" X-TUID: 4cmvRp6PE1ba --00000000000044370905f9483d5d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 14, 2023 at 2:30=E2=80=AFPM 'Jan Kiszka' via isar-users < isar-users@googlegroups.com> wrote: > On 14.04.23 10:57, Srinuvasan Arjunan wrote: > > From: Srinuvasan A > > > > One of our downstream project recipe uses `SRCREV =3D "${AUTOREV}"` to = get > > the latest changes always, but this not works after bitbake 2 migration= , > > it throws the below error. > > > > do_fetch: Fetcher failure: Recipe uses a floating tag/branch without a > fixed SRCREV yet doesn't call bb.fetch2.get_srcrev() (use SRCPV in PV for > OE). > > > > Till now we don't have support for SRCPV in ISAR, hence add this suppor= t > > as like OE. > > > > Signed-off-by: Srinuvasan A > > --- > > meta/classes/base.bbclass | 4 ++++ > > meta/conf/bitbake.conf | 4 ++++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass > > index 53550ae..819f8a2 100644 > > --- a/meta/classes/base.bbclass > > +++ b/meta/classes/base.bbclass > > @@ -120,6 +120,10 @@ root_cleandirs() { > > python() { > > import re > > > > + srcuri =3D d.getVar('SRC_URI') > > + if srcuri: > > + d.setVar("SRCPV", "${@bb.fetch2.get_srcrev(d)}") > > + > > Still not the logic that OE uses - why? > > Jan > I thought it would be enable when SRC_URI contains any SCM They have a logic like get the uri and validating the uri.scheme against with many SCM , and set the needsrcrev variable if needed f.e : git if uri.scheme in ("git", "gitsm"): needsrcrev =3D True Would we need to check like this? > > -- > Siemens AG, Technology > Competence Center Embedded Linux > > -- > You received this message because you are subscribed to the Google Groups > "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to isar-users+unsubscribe@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/isar-users/b58e37e2-00db-d2db-9955-cdcc= e8ae3f26%40siemens.com > . > --00000000000044370905f9483d5d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Apr 14, 2023 at 2:30=E2=80=AF= PM 'Jan Kiszka' via isar-users <isar-users@googlegroups.com> wrote:
On 14.04.23 10:57, Srinuvasan Arj= unan wrote:
> From: Srinuvasan A <srinuvasan_a@mentor.com>
>
> One of our downstream project recipe uses `SRCREV =3D "${AUTOREV}= "` to get
> the latest changes always, but this not works after bitbake 2 migratio= n,
> it throws the below error.
>
> do_fetch: Fetcher failure: Recipe uses a floating tag/branch without a= fixed SRCREV yet doesn't call bb.fetch2.get_srcrev() (use SRCPV in PV = for OE).
>
> Till now we don't have support for SRCPV in ISAR, hence add this s= upport
> as like OE.
>
> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> ---
>=C2=A0 meta/classes/base.bbclass | 4 ++++
>=C2=A0 meta/conf/bitbake.conf=C2=A0 =C2=A0 | 4 ++++
>=C2=A0 2 files changed, 8 insertions(+)
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index 53550ae..819f8a2 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -120,6 +120,10 @@ root_cleandirs() {
>=C2=A0 python() {
>=C2=A0 =C2=A0 =C2=A0 import re
>=C2=A0
> +=C2=A0 =C2=A0 srcuri =3D d.getVar('SRC_URI')
> +=C2=A0 =C2=A0 if srcuri:
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 d.setVar("SRCPV", "${@bb.f= etch2.get_srcrev(d)}")
> +

Still not the logic that OE uses - why?

Jan
=C2=A0
=C2=A0 I thought it would be enab= le when SRC_URI contains any SCM
=C2=A0 They have a logic like ge= t the uri and validating the uri.scheme against with many SCM , and set the= needsrcrev=C2=A0variable if needed
=C2=A0 f.e : git
= =C2=A0
=
if uri.scheme in ("git", "gitsm"):
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 needsrcrev =3D True

=C2=A0Would we need to check like this?<= /div>

--
Siemens AG, Technology
Competence Center Embedded Linux

--
You received this message because you are subscribed to the Google Groups &= quot;isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-= users/b58e37e2-00db-d2db-9955-cdcce8ae3f26%40siemens.com.
--00000000000044370905f9483d5d--