On Mon, 4 Oct, 2021, 4:15 pm Henning Schild, wrote: > Hi Srinuvasan, > > my suggestion would in fact be the same. The layer that brings the wic > plugin should extend the list of variables. I removed them because they > are in fact "bad style". For the upstream plugins i decided to follow > the symlinks to find the actual filenames, something the efibootguard > plugin might also want to consider. > > The variables are in fact nasty hacks for the isar testsuite to start > qemu and should have never been used in wic plugins (imho). > > So you have the following options: > 1. extend wicvars in your layer > 2. extend wicvars in the layer with the custom plugin > 3. upstream that plugin into isar > Thanks henning I will add those required wic variables in downstream layer. > > Order is ascending in quality/effort/sustainability of such custom > plugins. > > Henning > > Am Thu, 30 Sep 2021 21:49:57 -0700 (PDT) > schrieb Srinuvasan A : > > > Hi Florian Bezdeka, > > > > Thanks for your suggestion to fix it > > locally, Let's wait for henning reply on this. > > > > Thanks, > > Srinuvasan.A > > > > On Thursday, September 30, 2021 at 7:12:06 PM UTC+5:30 Florian > > Bezdeka wrote: > > > > > On 30.09.21 12:50, Srinuvasan A wrote: > > > > Hi All and Henning, > > > > > > if you need feedback from Henning you should add him at least to CC > > > or even better TO in this case. Otherwise he just might not read > > > this mail. > > > > > > > > Our downstream project isar-siemens SLLL and isar-cip-core get > > > > build failure when we include this commit 6fa0197 > > > > < > > > > https://github.com/ilbers/isar/commit/6fa0197ac36a86b2ae5c27f5b7804dd9a46d3c0b > > > > > > >. > > > > The build get fails when we append SWUPDATE yml file. > > > > this will add the KERNEL_IMAGE and INITRD_IMAGE variable, this > > > > will defined in sw-description.tmpl file > > > > > > > > TEMPLATE_VARS += "PN ROOTFS_PARTITION_NAME KERNEL_IMAGE > > > > INITRD_IMAGE" SWU_ADDITIONAL_FILES += "${INITRD_IMAGE} > > > > ${KERNEL_IMAGE} ${ROOTFS_PARTITION_NAME}" > > > > > > Henning removed KERNEL_IMAGE and INITRD_IMAGE from the list of > > > variables available in wic files, that might be a breaking change, > > > but it seems ISAR itself (the ISAR layer) never used it, so it's > > > kind of OK but remains a breaking change. > > > > > > You should be able to add something like "WICVARS += KERNEL_IMAGE > > > INITRD_IMAGE" to your layers (as temporary workaround) > > > > > > > > > > > when we add kas/opt/ebg-swu.yml file this will take the > > > > " > > > > https://gitlab.com/cip-project/cip-core/isar-cip-core/-/blob/next/wic/simatic-ipc227e-efibootguard.wks > > > > > > > < > > > > https://gitlab.com/cip-project/cip-core/isar-cip-core/-/blob/next/wic/simatic-ipc227e-efibootguard.wks > > > > > > >" > > > > file. > > > > this will configure the wic pulgin as "part --source > > > > efibootguard-boot", in this script it is expecting those > > > > KERNEL_IMAGE and INITRD_IMAGE or otherwise it throws the error. > > > > > > > > Failure logs below: > > > > > > > > `DEBUG: Executing python function do_wic_image > > > > DEBUG: Executing shell function generate_wic_image > > > > INFO: Creating image(s)... > > > > > > > > WARNING: KERNEL_IMAGE not set. Use default: > > > > WARNING: INITRD_IMAGE not set > > > > > > > > ERROR: file vmlinuz not found in directory > > > > /build/tmp/deploy/images/simatic-ipc227e > > > > WARNING: exit code 1 from a shell command. > > > > ERROR: Error executing a python function in exec_python_func() > > > > autogenerated: > > > > > > > > The stack trace of python calls that resulted in this > > > > exception/failure > > > was: > > > > File: 'exec_python_func() autogenerated', lineno: 2, function: > > > > 0001: > > > > *** 0002:do_wic_image(d) > > > > 0003: > > > > File: '/work/isar/meta/classes/wic-img.bbclass', lineno: 141, > > > > function: do_wic_image > > > > 0137:} > > > > 0138: > > > > 0139:do_wic_image[file-checksums] += "${WKS_FILE_CHECKSUM}" > > > > 0140:python do_wic_image() { > > > > *** 0141: bb.build.exec_func("generate_wic_image", d) > > > > 0142: bb.build.exec_func("check_for_wic_warnings", d) > > > > 0143:} > > > > 0144:addtask wic_image before do_image after do_image_tools > > > > 0145: > > > > File: '/work/isar/bitbake/lib/bb/build.py', lineno: 251, > > > > function: > > > exec_func > > > > 0247: with bb.utils.fileslocked(lockfiles): > > > > 0248: if ispython: > > > > 0249: exec_func_python(func, d, runfile, cwd=adir) > > > > 0250: else: > > > > *** 0251: exec_func_shell(func, d, runfile, cwd=adir) > > > > 0252: > > > > 0253: try: > > > > 0254: curcwd = os.getcwd() > > > > 0255: except: > > > > File: '/work/isar/bitbake/lib/bb/build.py', lineno: 452, function: > > > > exec_func_shell > > > > 0448: with open(fifopath, 'r+b', buffering=0) as fifo: > > > > 0449: try: > > > > 0450: bb.debug(2, "Executing shell function %s" % func) > > > > 0451: with open(os.devnull, 'r+') as stdin, logfile: > > > > *** 0452: bb.process.run(cmd, shell=False, stdin=stdin, > > > > log=logfile, extrafiles=[(fifo,readfifo)]) > > > > 0453: finally: > > > > 0454: os.unlink(fifopath) > > > > 0455: > > > > 0456: bb.debug(2, "Shell function %s finished" % func) > > > > File: '/work/isar/bitbake/lib/bb/process.py', lineno: 182, > > > > function: run 0178: if not stderr is None: > > > > 0179: stderr = stderr.decode("utf-8") > > > > 0180: > > > > 0181: if pipe.returncode != 0: > > > > *** 0182: raise ExecutionError(cmd, pipe.returncode, stdout, > > > > stderr) 0183: return stdout, stderr > > > > Exception: bb.process.ExecutionError: Execution of > > > > > > > > '/build/tmp/work/ebsy-buster-amd64/ebsy-image-reference-simatic-ipc227e-wic-swu-img/1.0-r0/temp/run.generate_wic_image.157804' > > > > > > > failed with exit code 1: > > > > INFO: Creating image(s)... > > > > > > > > WARNING: KERNEL_IMAGE not set. Use default: > > > > WARNING: INITRD_IMAGE not set > > > > > > > > ERROR: file vmlinuz not found in directory > > > > /build/tmp/deploy/images/simatic-ipc227e > > > > WARNING: exit code 1 from a shell command. > > > > > > > > DEBUG: Python function do_wic_image finished > > > > ` > > > > > > > > Please revert back this commit. > > > > > > As the affected commit is not in master yet we have all > > > possibilities. Reverting is one of them, but we could also consider > > > adding that to the release notes for the next release. That > > > decision is up to the maintainers I guess. > > > > > > > > > > > Thanks, > > > > Srinuvasan.A > > > > > > > > -- > > > > You received this message because you are subscribed to the Google > > > > Groups "isar-users" group. > > > > To unsubscribe from this group and stop receiving emails from it, > > > > send an email to isar-users+...@googlegroups.com > > > > . > > > > To view this discussion on the web visit > > > > > > > > https://groups.google.com/d/msgid/isar-users/5ed36530-f7d3-4672-96ce-479f68d00b96n%40googlegroups.com > > > > > > > < > > > > https://groups.google.com/d/msgid/isar-users/5ed36530-f7d3-4672-96ce-479f68d00b96n%40googlegroups.com?utm_medium=email&utm_source=footer > > > > > > >. > > > > > > > > > -- > > > Siemens AG, T RDA IOT > > > Corporate Competence Center Embedded Linux > > > > > > > -- > You received this message because you are subscribed to the Google Groups > "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to isar-users+unsubscribe@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/isar-users/20211004124544.02bc943b%40md1za8fc.ad001.siemens.net > . >