Re: [PATCH] meta/classes/sdk.bbclass: add --transform in TAR_OPTIONS

[Srinuvasan Arjunan <srinuvasanasv@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2251 bytes --]

On Wed, Apr 5, 2023 at 4:27 PM 'Jan Kiszka' via isar-users <
isar-users@googlegroups.com> wrote:

> On 31.03.23 12:33, Srinuvasan Arjunan wrote:
> > From: Srinuvasan A <srinuvasan_a@mentor.com>
> >
> > When we untar the SDK rootfs archive file, all the contents are extracted
> > into the current directory, not a folder, this looks ugly hence fixed
> > it with the file name transformations option.
> >
> > Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> > ---
> >  meta/classes/sdk.bbclass | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
> > index 06cae02..50f718c 100644
> > --- a/meta/classes/sdk.bbclass
> > +++ b/meta/classes/sdk.bbclass
> > @@ -53,6 +53,7 @@ ROOTFS_MANIFEST_DEPLOY_DIR:class-sdk =
> "${DEPLOY_DIR_SDKCHROOT}"
> >  ROOTFS_DPKGSTATUS_DEPLOY_DIR:class-sdk = "${DEPLOY_DIR_SDKCHROOT}"
> >
> >  IMAGE_FSTYPES:class-sdk = "${SDK_FORMATS}"
> > +TAR_OPTIONS:append:class-sdk = " --transform="s|.|$(basename
> ${PP_DEPLOY}/${IMAGE_FULLNAME})|""
> >
> >  # bitbake dependencies
> >  SDKDEPENDS += "sdk-files ${SDK_INSTALL}"
>
> To my understanding, this will move the content of the SDK tarball into
> a subfolder. What will that name be? ${IMAGE_FULLNAME}? And isn't
> $(basename ${PP_DEPLOY}/${IMAGE_FULLNAME}) the same as just
> ${IMAGE_FULLNAME}?
>

    Tested, yes ${IMAGE_FULLNAME} works here instead of $(basename
${PP_DEPLOY}/${IMAGE_FULLNAME})

>
> I'm fine with the relocation per se, I'm just wondering if we documented
> or otherwise referred to the structure of an unpacked SDK somewhere, in
> the user manual eg., and if that then also needs updating.
>

     Yes we have gap in the document, will update and send next version

>
> Jan
>
> --
> Siemens AG, Technology
> Competence Center Embedded Linux
>
> --
> You received this message because you are subscribed to the Google Groups
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/isar-users/b460e006-136e-9c4f-311a-edfa724c32e2%40siemens.com
> .
>

[-- Attachment #2: Type: text/html, Size: 3474 bytes --]