* [PATCH v2 1/2] isar-bootstrap: debootstrap https support
2018-12-17 11:45 [PATCH v2 0/2] isar-bootstrap: debootstrap https support Hosgor, Tolga (CT RDA DS EU TR MTS)
@ 2018-12-17 11:45 ` Hosgor, Tolga (CT RDA DS EU TR MTS)
2018-12-18 13:20 ` Claudius Heine
2018-12-17 11:45 ` [PATCH v2 2/2] isar-bootstrap: simplified distro source functions Hosgor, Tolga (CT RDA DS EU TR MTS)
` (2 subsequent siblings)
3 siblings, 1 reply; 11+ messages in thread
From: Hosgor, Tolga (CT RDA DS EU TR MTS) @ 2018-12-17 11:45 UTC (permalink / raw)
To: isar-users
Building 'isar-bootstrap-target' fails when there are HTTPS URIs in
the distro APT sources and the first URI is not HTTPS.
The first URI in the APT sources is passed to 'debootstrap' and
the distro APT sources file is written to the isar bootstrap rootfs.
Then, following 'apt-get update' fails due to apt-transport-https,
ca-certificates being missing.
This patch allows a distro to specify 'DISTRO_BOOTSTRAP_BASE_PACKAGES'
and introduces 'https-support' concept using bitbake OVERRIDES.
An example usage is specifying the necessary packages for http support
via 'DISTRO_BOOTSTRAP_BASE_PACKAGES_append_https-support' in distro
configuration.
Signed-off-by: Hosgor, Tolga (CT RDA DS EU TR MTS) <tolga.hosgor@siemens.com>
---
meta-isar/conf/distro/debian-buster.list | 1 +
meta-isar/conf/distro/debian-jessie.list | 1 +
.../conf/multiconfig/qemuamd64-buster.conf | 2 ++
.../conf/multiconfig/qemuamd64-jessie.conf | 2 ++
.../isar-bootstrap/isar-bootstrap-host.bb | 2 ++
.../isar-bootstrap/isar-bootstrap-target.bb | 2 ++
.../isar-bootstrap/isar-bootstrap.inc | 29 +++++++++++++++++--
7 files changed, 36 insertions(+), 3 deletions(-)
diff --git a/meta-isar/conf/distro/debian-buster.list b/meta-isar/conf/distro/debian-buster.list
index 18311d8..92d20e1 100644
--- a/meta-isar/conf/distro/debian-buster.list
+++ b/meta-isar/conf/distro/debian-buster.list
@@ -1,3 +1,4 @@
deb http://ftp.de.debian.org/debian buster main contrib non-free
+deb https://debian.inf.tu-dresden.de/debian buster main contrib non-free
deb http://ftp.de.debian.org/debian buster-updates main contrib non-free
deb http://security.debian.org buster/updates main contrib non-free
diff --git a/meta-isar/conf/distro/debian-jessie.list b/meta-isar/conf/distro/debian-jessie.list
index be46a57..2471402 100644
--- a/meta-isar/conf/distro/debian-jessie.list
+++ b/meta-isar/conf/distro/debian-jessie.list
@@ -1,3 +1,4 @@
+deb https://debian.inf.tu-dresden.de/debian jessie main contrib non-free
deb http://ftp.de.debian.org/debian jessie main contrib non-free
deb http://ftp.de.debian.org/debian jessie-updates main contrib non-free
deb http://security.debian.org jessie/updates main contrib non-free
diff --git a/meta-isar/conf/multiconfig/qemuamd64-buster.conf b/meta-isar/conf/multiconfig/qemuamd64-buster.conf
index 059ea00..394d76b 100644
--- a/meta-isar/conf/multiconfig/qemuamd64-buster.conf
+++ b/meta-isar/conf/multiconfig/qemuamd64-buster.conf
@@ -15,3 +15,5 @@ QEMU_ARCH ?= "x86_64"
QEMU_MACHINE ?= "q35"
QEMU_CPU ?= ""
QEMU_DISK_ARGS ?= "-hda ##ROOTFS_IMAGE## -bios /usr/local/share/ovmf/OVMF.fd"
+
+DISTRO_BOOTSTRAP_BASE_PACKAGES_append_https-support = " apt-transport-https ca-certificates"
diff --git a/meta-isar/conf/multiconfig/qemuamd64-jessie.conf b/meta-isar/conf/multiconfig/qemuamd64-jessie.conf
index ca00e15..d1335ff 100644
--- a/meta-isar/conf/multiconfig/qemuamd64-jessie.conf
+++ b/meta-isar/conf/multiconfig/qemuamd64-jessie.conf
@@ -14,3 +14,5 @@ QEMU_ARCH ?= "x86_64"
QEMU_MACHINE ?= "pc"
QEMU_CPU ?= ""
QEMU_DISK_ARGS ?= "-hda ##ROOTFS_IMAGE##"
+
+DISTRO_BOOTSTRAP_BASE_PACKAGES_append_https-support = " apt-transport-https ca-certificates"
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
index 55696ea..47cff63 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
@@ -40,6 +40,8 @@ python do_apt_config_prepare() {
}
addtask apt_config_prepare before do_bootstrap after do_unpack
+OVERRIDES_append = ":${@get_distro_needs_https_support(d, True)}"
+
do_bootstrap[stamp-extra-info] = "${HOST_DISTRO}-${HOST_ARCH}"
do_bootstrap[vardeps] += "HOST_DISTRO_APT_SOURCES"
do_bootstrap() {
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb
index 5752b14..57b607f 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb
@@ -39,6 +39,8 @@ python do_apt_config_prepare() {
}
addtask apt_config_prepare before do_bootstrap after do_unpack
+OVERRIDES_append = ":${@get_distro_needs_https_support(d, False)}"
+
do_bootstrap[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
do_bootstrap[vardeps] += "DISTRO_APT_SOURCES"
do_bootstrap() {
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
index cfad136..d868bb6 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
@@ -23,6 +23,7 @@ APTKEYFILES = ""
APTKEYRING = "${WORKDIR}/apt-keyring.gpg"
DEBOOTSTRAP_KEYRING = ""
DEPLOY_ISAR_BOOTSTRAP ?= ""
+DISTRO_BOOTSTRAP_BASE_PACKAGES = "locales"
python () {
from urllib.parse import urlparse
@@ -109,11 +110,15 @@ def aggregate_aptsources_list(d, file_list, file_out):
out_fd.write("\n".encode())
out_fd.write("\n".encode())
-def get_distro_primary_source_entry(d, is_host=False):
+def get_aptsources_list(d, is_host=False):
if is_host:
apt_sources_list = (d.getVar("HOST_DISTRO_APT_SOURCES", True) or "").split()
else:
apt_sources_list = (d.getVar("DISTRO_APT_SOURCES", True) or "").split()
+ return apt_sources_list
+
+def get_distro_primary_source_entry(d, is_host=False):
+ apt_sources_list = get_aptsources_list(d, is_host)
for entry in apt_sources_list:
entry_real = bb.parse.resolve_file(entry, d)
with open(entry_real, "r") as in_fd:
@@ -125,6 +130,24 @@ def get_distro_primary_source_entry(d, is_host=False):
return parsed[2:]
return ["", "", ""]
+def get_distro_have_https_source(d, is_host=False):
+ for entry in get_aptsources_list(d, is_host):
+ entry_real = bb.parse.resolve_file(entry, d)
+ with open(entry_real, "r") as in_fd:
+ for line in in_fd:
+ parsed = parse_aptsources_list_line(line)
+ if parsed:
+ parsed = get_apt_source_mirror(d, parsed)
+ if parsed[2].startswith("https://"):
+ return True
+ return False
+
+def get_distro_needs_https_support(d, is_host=False):
+ if get_distro_have_https_source(d, is_host):
+ return "https-support"
+ else:
+ return ""
+
def get_distro_source(d, is_host):
return get_distro_primary_source_entry(d, is_host)[0]
@@ -183,7 +206,7 @@ isar_bootstrap() {
if [ ${IS_HOST} ]; then
${DEBOOTSTRAP} --verbose \
--variant=minbase \
- --include=locales \
+ --include='${DISTRO_BOOTSTRAP_BASE_PACKAGES}' \
${@get_distro_components_argument(d, True)} \
${DEBOOTSTRAP_KEYRING} \
"${@get_distro_suite(d, True)}" \
@@ -194,7 +217,7 @@ isar_bootstrap() {
"${DEBOOTSTRAP}" --verbose \
--variant=minbase \
--arch="${DISTRO_ARCH}" \
- --include=locales \
+ --include='${DISTRO_BOOTSTRAP_BASE_PACKAGES}' \
${@get_distro_components_argument(d, False)} \
${DEBOOTSTRAP_KEYRING} \
"${@get_distro_suite(d, False)}" \
--
2.19.2
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 1/2] isar-bootstrap: debootstrap https support
2018-12-17 11:45 ` [PATCH v2 1/2] " Hosgor, Tolga (CT RDA DS EU TR MTS)
@ 2018-12-18 13:20 ` Claudius Heine
2018-12-19 6:52 ` Tolga Hoşgör
0 siblings, 1 reply; 11+ messages in thread
From: Claudius Heine @ 2018-12-18 13:20 UTC (permalink / raw)
To: Hosgor, Tolga (CT RDA DS EU TR MTS), isar-users
Hi again,
On 17/12/2018 12.45, Hosgor, Tolga (CT RDA DS EU TR MTS) wrote:
> Building 'isar-bootstrap-target' fails when there are HTTPS URIs in
> the distro APT sources and the first URI is not HTTPS.
> The first URI in the APT sources is passed to 'debootstrap' and
> the distro APT sources file is written to the isar bootstrap rootfs.
> Then, following 'apt-get update' fails due to apt-transport-https,
> ca-certificates being missing.
>
> This patch allows a distro to specify 'DISTRO_BOOTSTRAP_BASE_PACKAGES'
> and introduces 'https-support' concept using bitbake OVERRIDES.
> An example usage is specifying the necessary packages for http support
> via 'DISTRO_BOOTSTRAP_BASE_PACKAGES_append_https-support' in distro
> configuration.
>
> Signed-off-by: Hosgor, Tolga (CT RDA DS EU TR MTS) <tolga.hosgor@siemens.com>
> ---
> meta-isar/conf/distro/debian-buster.list | 1 +
> meta-isar/conf/distro/debian-jessie.list | 1 +
> .../conf/multiconfig/qemuamd64-buster.conf | 2 ++
> .../conf/multiconfig/qemuamd64-jessie.conf | 2 ++
> .../isar-bootstrap/isar-bootstrap-host.bb | 2 ++
> .../isar-bootstrap/isar-bootstrap-target.bb | 2 ++
> .../isar-bootstrap/isar-bootstrap.inc | 29 +++++++++++++++++--
> 7 files changed, 36 insertions(+), 3 deletions(-)
>
> diff --git a/meta-isar/conf/distro/debian-buster.list b/meta-isar/conf/distro/debian-buster.list
> index 18311d8..92d20e1 100644
> --- a/meta-isar/conf/distro/debian-buster.list
> +++ b/meta-isar/conf/distro/debian-buster.list
> @@ -1,3 +1,4 @@
> deb http://ftp.de.debian.org/debian buster main contrib non-free
> +deb https://debian.inf.tu-dresden.de/debian buster main contrib non-free
> deb http://ftp.de.debian.org/debian buster-updates main contrib non-free
> deb http://security.debian.org buster/updates main contrib non-free
> diff --git a/meta-isar/conf/distro/debian-jessie.list b/meta-isar/conf/distro/debian-jessie.list
> index be46a57..2471402 100644
> --- a/meta-isar/conf/distro/debian-jessie.list
> +++ b/meta-isar/conf/distro/debian-jessie.list
> @@ -1,3 +1,4 @@
> +deb https://debian.inf.tu-dresden.de/debian jessie main contrib non-free
> deb http://ftp.de.debian.org/debian jessie main contrib non-free
> deb http://ftp.de.debian.org/debian jessie-updates main contrib non-free
> deb http://security.debian.org jessie/updates main contrib non-free
> diff --git a/meta-isar/conf/multiconfig/qemuamd64-buster.conf b/meta-isar/conf/multiconfig/qemuamd64-buster.conf
> index 059ea00..394d76b 100644
> --- a/meta-isar/conf/multiconfig/qemuamd64-buster.conf
> +++ b/meta-isar/conf/multiconfig/qemuamd64-buster.conf
> @@ -15,3 +15,5 @@ QEMU_ARCH ?= "x86_64"
> QEMU_MACHINE ?= "q35"
> QEMU_CPU ?= ""
> QEMU_DISK_ARGS ?= "-hda ##ROOTFS_IMAGE## -bios /usr/local/share/ovmf/OVMF.fd"
> +
> +DISTRO_BOOTSTRAP_BASE_PACKAGES_append_https-support = " apt-transport-https ca-certificates"
> diff --git a/meta-isar/conf/multiconfig/qemuamd64-jessie.conf b/meta-isar/conf/multiconfig/qemuamd64-jessie.conf
> index ca00e15..d1335ff 100644
> --- a/meta-isar/conf/multiconfig/qemuamd64-jessie.conf
> +++ b/meta-isar/conf/multiconfig/qemuamd64-jessie.conf
> @@ -14,3 +14,5 @@ QEMU_ARCH ?= "x86_64"
> QEMU_MACHINE ?= "pc"
> QEMU_CPU ?= ""
> QEMU_DISK_ARGS ?= "-hda ##ROOTFS_IMAGE##"
> +
> +DISTRO_BOOTSTRAP_BASE_PACKAGES_append_https-support = " apt-transport-https ca-certificates"
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> index 55696ea..47cff63 100644
> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> @@ -40,6 +40,8 @@ python do_apt_config_prepare() {
> }
> addtask apt_config_prepare before do_bootstrap after do_unpack
>
> +OVERRIDES_append = ":${@get_distro_needs_https_support(d, True)}"
> +
> do_bootstrap[stamp-extra-info] = "${HOST_DISTRO}-${HOST_ARCH}"
> do_bootstrap[vardeps] += "HOST_DISTRO_APT_SOURCES"
> do_bootstrap() {
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb
> index 5752b14..57b607f 100644
> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb
> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb
> @@ -39,6 +39,8 @@ python do_apt_config_prepare() {
> }
> addtask apt_config_prepare before do_bootstrap after do_unpack
>
> +OVERRIDES_append = ":${@get_distro_needs_https_support(d, False)}"
> +
> do_bootstrap[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
> do_bootstrap[vardeps] += "DISTRO_APT_SOURCES"
> do_bootstrap() {
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> index cfad136..d868bb6 100644
> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> @@ -23,6 +23,7 @@ APTKEYFILES = ""
> APTKEYRING = "${WORKDIR}/apt-keyring.gpg"
> DEBOOTSTRAP_KEYRING = ""
> DEPLOY_ISAR_BOOTSTRAP ?= ""
> +DISTRO_BOOTSTRAP_BASE_PACKAGES = "locales"
>
> python () {
> from urllib.parse import urlparse
> @@ -109,11 +110,15 @@ def aggregate_aptsources_list(d, file_list, file_out):
> out_fd.write("\n".encode())
> out_fd.write("\n".encode())
>
> -def get_distro_primary_source_entry(d, is_host=False):
> +def get_aptsources_list(d, is_host=False):
> if is_host:
> apt_sources_list = (d.getVar("HOST_DISTRO_APT_SOURCES", True) or "").split()
> else:
> apt_sources_list = (d.getVar("DISTRO_APT_SOURCES", True) or "").split()
> + return apt_sources_list
After some thought really don't like this `is_host` parameter...
For me that looks like some kind of backwards approach. First you have
the difference between target and host, when you use in the different
files `isar-bootstrap-target.bb` and `isar-bootstrap-host.bb` and then,
because you use common functionality from `isar-bootstrap.inc` you need
to put this difference into a boolean and pass that to all of those
functions.
IMO the right solutions would have been, to do it like this:
isar-bootstrap.inc:
OVERRIDES_append = ":${@get_distro_needs_https_support(d)}"
def get_aptsources_list(d):
return (d.getVar("BOOTSTRAP_DISTRO_APT_SOURCES", True) or
"").split()
isar-bootstrap-target.bb:
BOOTSTRAP_DISTRO_APT_SOURCE = "${DISTRO_APT_SOURCES}"
isar-bootstrap-host.bb:
BOOTSTRAP_DISTRO_APT_SOURCE = "${HOST_DISTRO_APT_SOURCES}"
Of course that is not in scope of your patch, but your patch
demonstrates that weakness nicely by splitting up that function.
Claudius
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 1/2] isar-bootstrap: debootstrap https support
2018-12-18 13:20 ` Claudius Heine
@ 2018-12-19 6:52 ` Tolga Hoşgör
0 siblings, 0 replies; 11+ messages in thread
From: Tolga Hoşgör @ 2018-12-19 6:52 UTC (permalink / raw)
To: Claudius Heine; +Cc: Tolga Hoşgör, isar-users
Hello,
On Tue, Dec 18, 2018 at 4:20 PM Claudius Heine
<claudius.heine.ext@siemens.com> wrote:
>
> Hi again,
>
> On 17/12/2018 12.45, Hosgor, Tolga (CT RDA DS EU TR MTS) wrote:
> > Building 'isar-bootstrap-target' fails when there are HTTPS URIs in
> > the distro APT sources and the first URI is not HTTPS.
> > The first URI in the APT sources is passed to 'debootstrap' and
> > the distro APT sources file is written to the isar bootstrap rootfs.
> > Then, following 'apt-get update' fails due to apt-transport-https,
> > ca-certificates being missing.
> >
> > This patch allows a distro to specify 'DISTRO_BOOTSTRAP_BASE_PACKAGES'
> > and introduces 'https-support' concept using bitbake OVERRIDES.
> > An example usage is specifying the necessary packages for http support
> > via 'DISTRO_BOOTSTRAP_BASE_PACKAGES_append_https-support' in distro
> > configuration.
> >
> > Signed-off-by: Hosgor, Tolga (CT RDA DS EU TR MTS) <tolga.hosgor@siemens.com>
> > ---
> > meta-isar/conf/distro/debian-buster.list | 1 +
> > meta-isar/conf/distro/debian-jessie.list | 1 +
> > .../conf/multiconfig/qemuamd64-buster.conf | 2 ++
> > .../conf/multiconfig/qemuamd64-jessie.conf | 2 ++
> > .../isar-bootstrap/isar-bootstrap-host.bb | 2 ++
> > .../isar-bootstrap/isar-bootstrap-target.bb | 2 ++
> > .../isar-bootstrap/isar-bootstrap.inc | 29 +++++++++++++++++--
> > 7 files changed, 36 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta-isar/conf/distro/debian-buster.list b/meta-isar/conf/distro/debian-buster.list
> > index 18311d8..92d20e1 100644
> > --- a/meta-isar/conf/distro/debian-buster.list
> > +++ b/meta-isar/conf/distro/debian-buster.list
> > @@ -1,3 +1,4 @@
> > deb http://ftp.de.debian.org/debian buster main contrib non-free
> > +deb https://debian.inf.tu-dresden.de/debian buster main contrib non-free
> > deb http://ftp.de.debian.org/debian buster-updates main contrib non-free
> > deb http://security.debian.org buster/updates main contrib non-free
> > diff --git a/meta-isar/conf/distro/debian-jessie.list b/meta-isar/conf/distro/debian-jessie.list
> > index be46a57..2471402 100644
> > --- a/meta-isar/conf/distro/debian-jessie.list
> > +++ b/meta-isar/conf/distro/debian-jessie.list
> > @@ -1,3 +1,4 @@
> > +deb https://debian.inf.tu-dresden.de/debian jessie main contrib non-free
> > deb http://ftp.de.debian.org/debian jessie main contrib non-free
> > deb http://ftp.de.debian.org/debian jessie-updates main contrib non-free
> > deb http://security.debian.org jessie/updates main contrib non-free
> > diff --git a/meta-isar/conf/multiconfig/qemuamd64-buster.conf b/meta-isar/conf/multiconfig/qemuamd64-buster.conf
> > index 059ea00..394d76b 100644
> > --- a/meta-isar/conf/multiconfig/qemuamd64-buster.conf
> > +++ b/meta-isar/conf/multiconfig/qemuamd64-buster.conf
> > @@ -15,3 +15,5 @@ QEMU_ARCH ?= "x86_64"
> > QEMU_MACHINE ?= "q35"
> > QEMU_CPU ?= ""
> > QEMU_DISK_ARGS ?= "-hda ##ROOTFS_IMAGE## -bios /usr/local/share/ovmf/OVMF.fd"
> > +
> > +DISTRO_BOOTSTRAP_BASE_PACKAGES_append_https-support = " apt-transport-https ca-certificates"
> > diff --git a/meta-isar/conf/multiconfig/qemuamd64-jessie.conf b/meta-isar/conf/multiconfig/qemuamd64-jessie.conf
> > index ca00e15..d1335ff 100644
> > --- a/meta-isar/conf/multiconfig/qemuamd64-jessie.conf
> > +++ b/meta-isar/conf/multiconfig/qemuamd64-jessie.conf
> > @@ -14,3 +14,5 @@ QEMU_ARCH ?= "x86_64"
> > QEMU_MACHINE ?= "pc"
> > QEMU_CPU ?= ""
> > QEMU_DISK_ARGS ?= "-hda ##ROOTFS_IMAGE##"
> > +
> > +DISTRO_BOOTSTRAP_BASE_PACKAGES_append_https-support = " apt-transport-https ca-certificates"
> > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > index 55696ea..47cff63 100644
> > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > @@ -40,6 +40,8 @@ python do_apt_config_prepare() {
> > }
> > addtask apt_config_prepare before do_bootstrap after do_unpack
> >
> > +OVERRIDES_append = ":${@get_distro_needs_https_support(d, True)}"
> > +
> > do_bootstrap[stamp-extra-info] = "${HOST_DISTRO}-${HOST_ARCH}"
> > do_bootstrap[vardeps] += "HOST_DISTRO_APT_SOURCES"
> > do_bootstrap() {
> > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb
> > index 5752b14..57b607f 100644
> > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb
> > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-target.bb
> > @@ -39,6 +39,8 @@ python do_apt_config_prepare() {
> > }
> > addtask apt_config_prepare before do_bootstrap after do_unpack
> >
> > +OVERRIDES_append = ":${@get_distro_needs_https_support(d, False)}"
> > +
> > do_bootstrap[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
> > do_bootstrap[vardeps] += "DISTRO_APT_SOURCES"
> > do_bootstrap() {
> > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> > index cfad136..d868bb6 100644
> > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> > @@ -23,6 +23,7 @@ APTKEYFILES = ""
> > APTKEYRING = "${WORKDIR}/apt-keyring.gpg"
> > DEBOOTSTRAP_KEYRING = ""
> > DEPLOY_ISAR_BOOTSTRAP ?= ""
> > +DISTRO_BOOTSTRAP_BASE_PACKAGES = "locales"
> >
> > python () {
> > from urllib.parse import urlparse
> > @@ -109,11 +110,15 @@ def aggregate_aptsources_list(d, file_list, file_out):
> > out_fd.write("\n".encode())
> > out_fd.write("\n".encode())
> >
> > -def get_distro_primary_source_entry(d, is_host=False):
> > +def get_aptsources_list(d, is_host=False):
> > if is_host:
> > apt_sources_list = (d.getVar("HOST_DISTRO_APT_SOURCES", True) or "").split()
> > else:
> > apt_sources_list = (d.getVar("DISTRO_APT_SOURCES", True) or "").split()
> > + return apt_sources_list
>
> After some thought really don't like this `is_host` parameter...
>
> For me that looks like some kind of backwards approach. First you have
> the difference between target and host, when you use in the different
> files `isar-bootstrap-target.bb` and `isar-bootstrap-host.bb` and then,
> because you use common functionality from `isar-bootstrap.inc` you need
> to put this difference into a boolean and pass that to all of those
> functions.
Yeah it is really counter-intuitive. I would expect a variable to be
filled with the distro
source decision at some point and go on with it. This also applies to
the rest of the
code (the two "debootstrap" calls with True/False parameters to functions).
>
> IMO the right solutions would have been, to do it like this:
>
> isar-bootstrap.inc:
> OVERRIDES_append = ":${@get_distro_needs_https_support(d)}"
> def get_aptsources_list(d):
> return (d.getVar("BOOTSTRAP_DISTRO_APT_SOURCES", True) or
> "").split()
>
> isar-bootstrap-target.bb:
> BOOTSTRAP_DISTRO_APT_SOURCE = "${DISTRO_APT_SOURCES}"
>
> isar-bootstrap-host.bb:
> BOOTSTRAP_DISTRO_APT_SOURCE = "${HOST_DISTRO_APT_SOURCES}"
Exactly.
>
> Of course that is not in scope of your patch, but your patch
> demonstrates that weakness nicely by splitting up that function.
>
> Claudius
>
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 2/2] isar-bootstrap: simplified distro source functions
2018-12-17 11:45 [PATCH v2 0/2] isar-bootstrap: debootstrap https support Hosgor, Tolga (CT RDA DS EU TR MTS)
2018-12-17 11:45 ` [PATCH v2 1/2] " Hosgor, Tolga (CT RDA DS EU TR MTS)
@ 2018-12-17 11:45 ` Hosgor, Tolga (CT RDA DS EU TR MTS)
2018-12-17 11:55 ` Claudius Heine
2019-01-17 14:08 ` [PATCH v2 0/2] isar-bootstrap: debootstrap https support Henning Schild
2019-01-23 13:39 ` Maxim Yu. Osipov
3 siblings, 1 reply; 11+ messages in thread
From: Hosgor, Tolga (CT RDA DS EU TR MTS) @ 2018-12-17 11:45 UTC (permalink / raw)
To: isar-users
- distro sources are created with a generator
- debian-buster.list begins with a 'deb-src' to test
the parser works correctly
Signed-off-by: Hosgor, Tolga (CT RDA DS EU TR MTS) <tolga.hosgor@siemens.com>
---
meta-isar/conf/distro/debian-buster.list | 1 +
.../isar-bootstrap/isar-bootstrap.inc | 22 ++++++++-----------
2 files changed, 10 insertions(+), 13 deletions(-)
diff --git a/meta-isar/conf/distro/debian-buster.list b/meta-isar/conf/distro/debian-buster.list
index 92d20e1..7828671 100644
--- a/meta-isar/conf/distro/debian-buster.list
+++ b/meta-isar/conf/distro/debian-buster.list
@@ -1,3 +1,4 @@
+deb-src http://ftp.de.debian.org/debian buster main contrib non-free
deb http://ftp.de.debian.org/debian buster main contrib non-free
deb https://debian.inf.tu-dresden.de/debian buster main contrib non-free
deb http://ftp.de.debian.org/debian buster-updates main contrib non-free
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
index d868bb6..6dc1888 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
@@ -117,7 +117,7 @@ def get_aptsources_list(d, is_host=False):
apt_sources_list = (d.getVar("DISTRO_APT_SOURCES", True) or "").split()
return apt_sources_list
-def get_distro_primary_source_entry(d, is_host=False):
+def generate_distro_sources(d, is_host=False):
apt_sources_list = get_aptsources_list(d, is_host)
for entry in apt_sources_list:
entry_real = bb.parse.resolve_file(entry, d)
@@ -126,21 +126,17 @@ def get_distro_primary_source_entry(d, is_host=False):
parsed = parse_aptsources_list_line(line)
if parsed:
parsed = get_apt_source_mirror(d, parsed)
- if parsed[0] == "deb":
- return parsed[2:]
+ yield parsed
+
+def get_distro_primary_source_entry(d, is_host=False):
+ apt_sources_list = get_aptsources_list(d, is_host)
+ for source in generate_distro_sources(d, is_host):
+ if source[0] == "deb":
+ return source[2:]
return ["", "", ""]
def get_distro_have_https_source(d, is_host=False):
- for entry in get_aptsources_list(d, is_host):
- entry_real = bb.parse.resolve_file(entry, d)
- with open(entry_real, "r") as in_fd:
- for line in in_fd:
- parsed = parse_aptsources_list_line(line)
- if parsed:
- parsed = get_apt_source_mirror(d, parsed)
- if parsed[2].startswith("https://"):
- return True
- return False
+ return any(source[2].startswith("https://") for source in generate_distro_sources(d, is_host))
def get_distro_needs_https_support(d, is_host=False):
if get_distro_have_https_source(d, is_host):
--
2.19.2
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 2/2] isar-bootstrap: simplified distro source functions
2018-12-17 11:45 ` [PATCH v2 2/2] isar-bootstrap: simplified distro source functions Hosgor, Tolga (CT RDA DS EU TR MTS)
@ 2018-12-17 11:55 ` Claudius Heine
2018-12-17 18:11 ` Tolga Hoşgör
0 siblings, 1 reply; 11+ messages in thread
From: Claudius Heine @ 2018-12-17 11:55 UTC (permalink / raw)
To: Hosgor, Tolga (CT RDA DS EU TR MTS), isar-users
Hi Tolga,
On 17/12/2018 12.45, Hosgor, Tolga (CT RDA DS EU TR MTS) wrote:
> - distro sources are created with a generator
> - debian-buster.list begins with a 'deb-src' to test
> the parser works correctly
>
> Signed-off-by: Hosgor, Tolga (CT RDA DS EU TR MTS) <tolga.hosgor@siemens.com>
> ---
> meta-isar/conf/distro/debian-buster.list | 1 +
> .../isar-bootstrap/isar-bootstrap.inc | 22 ++++++++-----------
> 2 files changed, 10 insertions(+), 13 deletions(-)
>
> diff --git a/meta-isar/conf/distro/debian-buster.list b/meta-isar/conf/distro/debian-buster.list
> index 92d20e1..7828671 100644
> --- a/meta-isar/conf/distro/debian-buster.list
> +++ b/meta-isar/conf/distro/debian-buster.list
> @@ -1,3 +1,4 @@
> +deb-src http://ftp.de.debian.org/debian buster main contrib non-free
> deb http://ftp.de.debian.org/debian buster main contrib non-free
> deb https://debian.inf.tu-dresden.de/debian buster main contrib non-free
> deb http://ftp.de.debian.org/debian buster-updates main contrib non-free
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> index d868bb6..6dc1888 100644
> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> @@ -117,7 +117,7 @@ def get_aptsources_list(d, is_host=False):
> apt_sources_list = (d.getVar("DISTRO_APT_SOURCES", True) or "").split()
> return apt_sources_list
>
> -def get_distro_primary_source_entry(d, is_host=False):
> +def generate_distro_sources(d, is_host=False):
> apt_sources_list = get_aptsources_list(d, is_host)
> for entry in apt_sources_list:
> entry_real = bb.parse.resolve_file(entry, d)
> @@ -126,21 +126,17 @@ def get_distro_primary_source_entry(d, is_host=False):
> parsed = parse_aptsources_list_line(line)
> if parsed:
> parsed = get_apt_source_mirror(d, parsed)
> - if parsed[0] == "deb":
> - return parsed[2:]
> + yield parsed
> +
> +def get_distro_primary_source_entry(d, is_host=False):
> + apt_sources_list = get_aptsources_list(d, is_host)
> + for source in generate_distro_sources(d, is_host):
> + if source[0] == "deb":
> + return source[2:]
> return ["", "", ""]
>
> def get_distro_have_https_source(d, is_host=False):
> - for entry in get_aptsources_list(d, is_host):
> - entry_real = bb.parse.resolve_file(entry, d)
> - with open(entry_real, "r") as in_fd:
> - for line in in_fd:
> - parsed = parse_aptsources_list_line(line)
> - if parsed:
> - parsed = get_apt_source_mirror(d, parsed)
> - if parsed[2].startswith("https://"):
> - return True
> - return False
> + return any(source[2].startswith("https://") for source in generate_distro_sources(d, is_host))
Maybe you should merge those changes into the first patch?
Changing the same code in one patchset makes the review more difficult,
also I don't really see a reason for this split here.
Cheers,
Claudius
>
> def get_distro_needs_https_support(d, is_host=False):
> if get_distro_have_https_source(d, is_host):
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 2/2] isar-bootstrap: simplified distro source functions
2018-12-17 11:55 ` Claudius Heine
@ 2018-12-17 18:11 ` Tolga Hoşgör
2018-12-18 8:20 ` Claudius Heine
0 siblings, 1 reply; 11+ messages in thread
From: Tolga Hoşgör @ 2018-12-17 18:11 UTC (permalink / raw)
To: Claudius Heine; +Cc: Tolga Hoşgör, isar-users
[-- Attachment #1: Type: text/plain, Size: 4054 bytes --]
Hi,
The second patch is kind of an unrelated clean up that does a relatively
big change to other parts of the code (get_distro_primary_source_entry to
be exact). I believe it is better off as a separate commit that is
revertible on its own.
On Mon, Dec 17, 2018, 14:55 Claudius Heine <claudius.heine.ext@siemens.com
wrote:
> Hi Tolga,
>
> On 17/12/2018 12.45, Hosgor, Tolga (CT RDA DS EU TR MTS) wrote:
> > - distro sources are created with a generator
> > - debian-buster.list begins with a 'deb-src' to test
> > the parser works correctly
> >
> > Signed-off-by: Hosgor, Tolga (CT RDA DS EU TR MTS) <
> tolga.hosgor@siemens.com>
> > ---
> > meta-isar/conf/distro/debian-buster.list | 1 +
> > .../isar-bootstrap/isar-bootstrap.inc | 22 ++++++++-----------
> > 2 files changed, 10 insertions(+), 13 deletions(-)
> >
> > diff --git a/meta-isar/conf/distro/debian-buster.list
> b/meta-isar/conf/distro/debian-buster.list
> > index 92d20e1..7828671 100644
> > --- a/meta-isar/conf/distro/debian-buster.list
> > +++ b/meta-isar/conf/distro/debian-buster.list
> > @@ -1,3 +1,4 @@
> > +deb-src http://ftp.de.debian.org/debian buster main contrib
> non-free
> > deb http://ftp.de.debian.org/debian buster main contrib non-free
> > deb https://debian.inf.tu-dresden.de/debian buster main contrib
> non-free
> > deb http://ftp.de.debian.org/debian buster-updates main contrib
> non-free
> > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> > index d868bb6..6dc1888 100644
> > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> > @@ -117,7 +117,7 @@ def get_aptsources_list(d, is_host=False):
> > apt_sources_list = (d.getVar("DISTRO_APT_SOURCES", True) or
> "").split()
> > return apt_sources_list
> >
> > -def get_distro_primary_source_entry(d, is_host=False):
> > +def generate_distro_sources(d, is_host=False):
> > apt_sources_list = get_aptsources_list(d, is_host)
> > for entry in apt_sources_list:
> > entry_real = bb.parse.resolve_file(entry, d)
> > @@ -126,21 +126,17 @@ def get_distro_primary_source_entry(d,
> is_host=False):
> > parsed = parse_aptsources_list_line(line)
> > if parsed:
> > parsed = get_apt_source_mirror(d, parsed)
> > - if parsed[0] == "deb":
> > - return parsed[2:]
> > + yield parsed
> > +
> > +def get_distro_primary_source_entry(d, is_host=False):
> > + apt_sources_list = get_aptsources_list(d, is_host)
> > + for source in generate_distro_sources(d, is_host):
> > + if source[0] == "deb":
> > + return source[2:]
> > return ["", "", ""]
> >
> > def get_distro_have_https_source(d, is_host=False):
> > - for entry in get_aptsources_list(d, is_host):
> > - entry_real = bb.parse.resolve_file(entry, d)
> > - with open(entry_real, "r") as in_fd:
> > - for line in in_fd:
> > - parsed = parse_aptsources_list_line(line)
> > - if parsed:
> > - parsed = get_apt_source_mirror(d, parsed)
> > - if parsed[2].startswith("https://"):
> > - return True
> > - return False
> > + return any(source[2].startswith("https://") for source in
> generate_distro_sources(d, is_host))
>
> Maybe you should merge those changes into the first patch?
>
> Changing the same code in one patchset makes the review more difficult,
> also I don't really see a reason for this split here.
>
> Cheers,
> Claudius
>
> >
> > def get_distro_needs_https_support(d, is_host=False):
> > if get_distro_have_https_source(d, is_host):
> >
>
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
>
[-- Attachment #2: Type: text/html, Size: 5726 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 2/2] isar-bootstrap: simplified distro source functions
2018-12-17 18:11 ` Tolga Hoşgör
@ 2018-12-18 8:20 ` Claudius Heine
0 siblings, 0 replies; 11+ messages in thread
From: Claudius Heine @ 2018-12-18 8:20 UTC (permalink / raw)
To: Tolga Hoşgör; +Cc: isar-users
Hi Tolga,
On 17/12/2018 19.11, Tolga Hoşgör wrote:
> Hi,
>
> The second patch is kind of an unrelated clean up that does a relatively
> big change to other parts of the code (get_distro_primary_source_entry to
> be exact). I believe it is better off as a separate commit that is
> revertible on its own.
But I pointed out the changes to get_distro_have_https_source specifically.
If you feel that refactoring of your just introduced
`get_distro_primary_source_entry` function should be handled separately,
then OK. I sort of see where you are coming from here. Since you just
split a function before and then change it in the next patch.
Also please avoid top-posting in mailing lists.
Cheers,
Claudius
>
> On Mon, Dec 17, 2018, 14:55 Claudius Heine <claudius.heine.ext@siemens.com
> wrote:
>
>> Hi Tolga,
>>
>> On 17/12/2018 12.45, Hosgor, Tolga (CT RDA DS EU TR MTS) wrote:
>>> - distro sources are created with a generator
>>> - debian-buster.list begins with a 'deb-src' to test
>>> the parser works correctly
>>>
>>> Signed-off-by: Hosgor, Tolga (CT RDA DS EU TR MTS) <
>> tolga.hosgor@siemens.com>
>>> ---
>>> meta-isar/conf/distro/debian-buster.list | 1 +
>>> .../isar-bootstrap/isar-bootstrap.inc | 22 ++++++++-----------
>>> 2 files changed, 10 insertions(+), 13 deletions(-)
>>>
>>> diff --git a/meta-isar/conf/distro/debian-buster.list
>> b/meta-isar/conf/distro/debian-buster.list
>>> index 92d20e1..7828671 100644
>>> --- a/meta-isar/conf/distro/debian-buster.list
>>> +++ b/meta-isar/conf/distro/debian-buster.list
>>> @@ -1,3 +1,4 @@
>>> +deb-src http://ftp.de.debian.org/debian buster main contrib
>> non-free
>>> deb http://ftp.de.debian.org/debian buster main contrib non-free
>>> deb https://debian.inf.tu-dresden.de/debian buster main contrib
>> non-free
>>> deb http://ftp.de.debian.org/debian buster-updates main contrib
>> non-free
>>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
>> b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
>>> index d868bb6..6dc1888 100644
>>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
>>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
>>> @@ -117,7 +117,7 @@ def get_aptsources_list(d, is_host=False):
>>> apt_sources_list = (d.getVar("DISTRO_APT_SOURCES", True) or
>> "").split()
>>> return apt_sources_list
>>>
>>> -def get_distro_primary_source_entry(d, is_host=False):
>>> +def generate_distro_sources(d, is_host=False):
>>> apt_sources_list = get_aptsources_list(d, is_host)
>>> for entry in apt_sources_list:
>>> entry_real = bb.parse.resolve_file(entry, d)
>>> @@ -126,21 +126,17 @@ def get_distro_primary_source_entry(d,
>> is_host=False):
>>> parsed = parse_aptsources_list_line(line)
>>> if parsed:
>>> parsed = get_apt_source_mirror(d, parsed)
>>> - if parsed[0] == "deb":
>>> - return parsed[2:]
>>> + yield parsed
>>> +
>>> +def get_distro_primary_source_entry(d, is_host=False):
>>> + apt_sources_list = get_aptsources_list(d, is_host)
>>> + for source in generate_distro_sources(d, is_host):
>>> + if source[0] == "deb":
>>> + return source[2:]
>>> return ["", "", ""]
>>>
>>> def get_distro_have_https_source(d, is_host=False):
>>> - for entry in get_aptsources_list(d, is_host):
>>> - entry_real = bb.parse.resolve_file(entry, d)
>>> - with open(entry_real, "r") as in_fd:
>>> - for line in in_fd:
>>> - parsed = parse_aptsources_list_line(line)
>>> - if parsed:
>>> - parsed = get_apt_source_mirror(d, parsed)
>>> - if parsed[2].startswith("https://"):
>>> - return True
>>> - return False
>>> + return any(source[2].startswith("https://") for source in
>> generate_distro_sources(d, is_host))
>>
>> Maybe you should merge those changes into the first patch?
>>
>> Changing the same code in one patchset makes the review more difficult,
>> also I don't really see a reason for this split here.
>>
>> Cheers,
>> Claudius
>>
>>>
>>> def get_distro_needs_https_support(d, is_host=False):
>>> if get_distro_have_https_source(d, is_host):
>>>
>>
>> --
>> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>> Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
>>
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 0/2] isar-bootstrap: debootstrap https support
2018-12-17 11:45 [PATCH v2 0/2] isar-bootstrap: debootstrap https support Hosgor, Tolga (CT RDA DS EU TR MTS)
2018-12-17 11:45 ` [PATCH v2 1/2] " Hosgor, Tolga (CT RDA DS EU TR MTS)
2018-12-17 11:45 ` [PATCH v2 2/2] isar-bootstrap: simplified distro source functions Hosgor, Tolga (CT RDA DS EU TR MTS)
@ 2019-01-17 14:08 ` Henning Schild
2019-01-17 14:21 ` Claudius Heine
2019-01-23 13:39 ` Maxim Yu. Osipov
3 siblings, 1 reply; 11+ messages in thread
From: Henning Schild @ 2019-01-17 14:08 UTC (permalink / raw)
To: Hosgor, Tolga (CT RDA DS EU TR MTS), Maxim Yu. Osipov
Cc: isar-users, [ext] Claudius Heine
Hi,
i guess the comments from Claudius are nitpicky and can be ignored?
Claudius, if you feel strong please speak up again. If not i would like
to see that being merged.
Henning
Am Mon, 17 Dec 2018 14:45:16 +0300
schrieb "Hosgor, Tolga (CT RDA DS EU TR MTS)" <tlghosgor@gmail.com>:
> From: Hosgor, Tolga (CT RDA DS EU TR MTS) <tolga.hosgor@siemens.com>
>
> This patchset is the updated version of https support with
> the OVERRIDE approach. It also simplifies the code using a generator
> for distro apt sources and does some changes for testing.
>
> Hosgor, Tolga (CT RDA DS EU TR MTS) (2):
> isar-bootstrap: debootstrap https support
> isar-bootstrap: simplified distro source functions
>
> meta-isar/conf/distro/debian-buster.list | 2 ++
> meta-isar/conf/distro/debian-jessie.list | 1 +
> .../conf/multiconfig/qemuamd64-buster.conf | 2 ++
> .../conf/multiconfig/qemuamd64-jessie.conf | 2 ++
> .../isar-bootstrap/isar-bootstrap-host.bb | 2 ++
> .../isar-bootstrap/isar-bootstrap-target.bb | 2 ++
> .../isar-bootstrap/isar-bootstrap.inc | 29
> +++++++++++++++---- 7 files changed, 35 insertions(+), 5 deletions(-)
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 0/2] isar-bootstrap: debootstrap https support
2019-01-17 14:08 ` [PATCH v2 0/2] isar-bootstrap: debootstrap https support Henning Schild
@ 2019-01-17 14:21 ` Claudius Heine
0 siblings, 0 replies; 11+ messages in thread
From: Claudius Heine @ 2019-01-17 14:21 UTC (permalink / raw)
To: Henning Schild, Hosgor, Tolga (CT RDA DS EU TR MTS), Maxim Yu. Osipov
Cc: isar-users
Hi Henning,
On 17/01/2019 15.08, Henning Schild wrote:
> Hi,
>
> i guess the comments from Claudius are nitpicky and can be ignored?
> Claudius, if you feel strong please speak up again. If not i would like
> to see that being merged.
No, I don't feel very strongly about this. If the maintainer doesn't
care about this, then I don't care about this.
Claudius
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 0/2] isar-bootstrap: debootstrap https support
2018-12-17 11:45 [PATCH v2 0/2] isar-bootstrap: debootstrap https support Hosgor, Tolga (CT RDA DS EU TR MTS)
` (2 preceding siblings ...)
2019-01-17 14:08 ` [PATCH v2 0/2] isar-bootstrap: debootstrap https support Henning Schild
@ 2019-01-23 13:39 ` Maxim Yu. Osipov
3 siblings, 0 replies; 11+ messages in thread
From: Maxim Yu. Osipov @ 2019-01-23 13:39 UTC (permalink / raw)
To: Hosgor, Tolga (CT RDA DS EU TR MTS), isar-users
On 12/17/18 12:45 PM, Hosgor, Tolga (CT RDA DS EU TR MTS) wrote:
> From: Hosgor, Tolga (CT RDA DS EU TR MTS) <tolga.hosgor@siemens.com>
>
> This patchset is the updated version of https support with
> the OVERRIDE approach. It also simplifies the code using a generator
> for distro apt sources and does some changes for testing.
Hi Tolga,
Rebased to the current 'next' (original patchset was based on 'master'
branch - when submitting the patches next time please base on the 'next'
branch).
Note:
modifications in debian-buster.list and debian-jessie.list
(which demonstrated that feature works fine) were dropped to keep
them generic.
Thanks,
Maxim.
> Hosgor, Tolga (CT RDA DS EU TR MTS) (2):
> isar-bootstrap: debootstrap https support
> isar-bootstrap: simplified distro source functions
>
> meta-isar/conf/distro/debian-buster.list | 2 ++
> meta-isar/conf/distro/debian-jessie.list | 1 +
> .../conf/multiconfig/qemuamd64-buster.conf | 2 ++
> .../conf/multiconfig/qemuamd64-jessie.conf | 2 ++
> .../isar-bootstrap/isar-bootstrap-host.bb | 2 ++
> .../isar-bootstrap/isar-bootstrap-target.bb | 2 ++
> .../isar-bootstrap/isar-bootstrap.inc | 29 +++++++++++++++----
> 7 files changed, 35 insertions(+), 5 deletions(-)
>
--
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
^ permalink raw reply [flat|nested] 11+ messages in thread