From: Ben Brenson <benbrenson89@googlemail.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: "[ext] Claudius Heine" <claudius.heine.ext@siemens.com>,
isar-users <isar-users@googlegroups.com>
Subject: Re: Introducing chroot tasks
Date: Thu, 19 Oct 2017 12:24:19 +0200 [thread overview]
Message-ID: <CAF5832UZdNAaJT5R-LS=U08DBuqbPFBOVm=bzzpERWd5Oz1U5w@mail.gmail.com> (raw)
In-Reply-To: <20171019111500.44f150f0@md1em3qc>
[-- Attachment #1: Type: text/plain, Size: 2305 bytes --]
Yeah I know, but using chroot tasks was never a use case for bitbake and
maybe will never be, I think.
I've never thought about using chroot tasks when running Yocto builds, but
that has changed very fast when switching to Isar.
So maybe within Isar we have a more reasoned use case for chroot tasks, and
if this feature works in isar, may be I have more chances to get those
changes upstream to bitbake?
I can try to get those changes upstream first....
Regards,
Benedikt
2017-10-19 11:15 GMT+02:00 Henning Schild <henning.schild@siemens.com>:
> On Thu, 19 Oct 2017 11:01:28 +0200
> "[ext] Claudius Heine" <claudius.heine.ext@siemens.com> wrote:
>
> > Hi Ben,
> >
> > On 10/19/2017 10:38 AM, 'Ben Brenson' via isar-users wrote:
> > > Hi,
> > >
> > > I want to submit some patches for defining and running chroot tasks
> > > within bitbake recipes.
> > > The following short example should show what I mean:
> > >
> > > Exampe recipe.bb:
> > >
> > > do_foo() {
> > > # Do something within chroot
> > > }
> > > do_foo[chroot] = "1"
> > > do_foo[id] = "${BUILDCHROOT_ID}"
> > > addtask do_foo after ... before ...
> > >
> > >
> > > By setting the chroot flag the task automatically will be executed
> > > within the chroot specified by the id flag.
> > > My isar (https://github.com/benbrenson/isar) fork already supports
> > > this feature, by using schroot.
> > >
> > > This will give much more flexibility and modularity to Isar. You
> > > will be able to append/prepend things to those tasks
> > > between layers easily.
> > >
> > > I have already seen, that there is another and better approach than
> > > schroot -> proot.
> > > I saw Alexander has already experimented with this feature, which
> > > seems to work.
> > >
> > > So before posting some patches here, maybe changing this feature to
> > > proot first would a better first-step?
> >
> > Yes. Since proot solves some more problems than schroot.
> >
> > Your implementation requires patching the bitbake code, so maybe we
> > should try to get those changes upstream to bitbake?
>
> IMHO, touching our copy of bitbake is an absolute NoGo! Such changes
> need to go upstream first.
>
> Henning
>
> > Isar has currently has no own changes to upstream bitbake and I am
> > not in favor of forking bitbake.
> >
> > Claudius
> >
>
>
[-- Attachment #2: Type: text/html, Size: 3769 bytes --]
next prev parent reply other threads:[~2017-10-19 10:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 8:38 Ben Brenson
2017-10-19 9:01 ` Claudius Heine
2017-10-19 9:08 ` Jan Kiszka
2017-10-19 9:15 ` Henning Schild
2017-10-19 10:24 ` Ben Brenson [this message]
2017-10-19 12:00 ` Claudius Heine
2017-10-20 8:51 ` Ben Brenson
2017-10-19 9:11 ` Henning Schild
2017-10-19 9:12 ` Henning Schild
2017-10-25 7:49 Benedikt Niedermayr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF5832UZdNAaJT5R-LS=U08DBuqbPFBOVm=bzzpERWd5Oz1U5w@mail.gmail.com' \
--to=benbrenson89@googlemail.com \
--cc=claudius.heine.ext@siemens.com \
--cc=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox