From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7186869599348981760 X-Received: by 2002:a1f:b402:0:b0:3d5:621c:a662 with SMTP id d2-20020a1fb402000000b003d5621ca662mr6698808vkf.16.1673348982738; Tue, 10 Jan 2023 03:09:42 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a67:c48d:0:b0:3cb:9ab3:81b0 with SMTP id d13-20020a67c48d000000b003cb9ab381b0ls2348967vsk.7.-pod-prod-gmail; Tue, 10 Jan 2023 03:09:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXt//ptc/KRyv8otLG9dRjm+SYIKqKSF+BYgKn0NEPbh8aflpN6gByX5WRwkyFZciBVfuD6N X-Received: by 2002:a67:e899:0:b0:3ce:f7e9:62c6 with SMTP id x25-20020a67e899000000b003cef7e962c6mr5702931vsn.2.1673348981911; Tue, 10 Jan 2023 03:09:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673348981; cv=none; d=google.com; s=arc-20160816; b=07FxKCXxcKgQiz0yXod4LYo+8ng1/UoYfouNMqLhNTxJ8WNsMhwqe/LxxIP39zPQH8 PqT5UjCxhN1msCzh/mha0hReLemtmH2YDTGv8dugBO165pd6B8PJGh8sD/2eRdOf3w+H Qf1yJvCIL/kVev/QF1EG9nrZNz7Ti5ktpJDVi/hMWaU6oO/xmpx5BneGCrk8heG9AwWn QuEaMqLffQ2XrXb4l2gwVGRDnVWpO4dvwzNh2PByAzv6dOVl3WjO4po9wQISH8pIR2VC zgLE7wkXV5uhUk73saVo6DCbi9pigygoCV2VS1rUeOE4O8ENENeHXYsv3y7r/ZjHnGzA fA+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=L78E/1MnxD1hBP1t+WS4DRhsaOoQm0Wht6rAauydaTo=; b=n89TA4EcYShd0Ma5SylMnW3mtcIo8/uyhd0y55NJsuKgx8YC+y9esFEHkBnYgD8Lwq Y1U/Goo+qK3+xPrQU1w4Em7IO3qajlhmUC1igpjDH/o4FNlA+YJo0LRgVrN8DygY8PU0 +bv1gHXpPsU/169bE/bZGQ5QKz1rdvCGCodKqjej/qfIeCeUQ4Qd9lznnvfsIxFjcCTU +JaKNerIgw3FTCPC3MIDa1px0M2ze6fCOJQwIntRYb75J4U0rELD0ADBOFbGBeLvRwfh WPTIH6qqZEajkUubCZt9DL5VZaGo2RJ04xniZQeYP5Z9LimHRyZSMfOZdIm3nSF2GuKv E6+Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=p0Fx1rgR; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::729 as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com. [2607:f8b0:4864:20::729]) by gmr-mx.google.com with ESMTPS id v5-20020a056102302500b003b06d9dca0bsi688454vsa.1.2023.01.10.03.09.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 03:09:41 -0800 (PST) Received-SPF: pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::729 as permitted sender) client-ip=2607:f8b0:4864:20::729; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=p0Fx1rgR; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::729 as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-qk1-x729.google.com with SMTP id k2so5720068qkk.7 for ; Tue, 10 Jan 2023 03:09:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=L78E/1MnxD1hBP1t+WS4DRhsaOoQm0Wht6rAauydaTo=; b=p0Fx1rgRfV+vouSmqGGbtPYa7oYM7IdkcyzDY7CRjyDyESPFE0m4fULS8guYWQfdJ5 gD7UVJ/Qxp1TdFew2GPV6lugyaLcow5cZjuiP0Ood8AMbAWhpryCGU7b2nsKBCXum70P SuL7+iLWxl8yYfLY04sKDtdc4GnUJq5csDbJED7R1EjQdmiXkCC/5bfjTWY80XVM5qyI RbPrIuFuc5nA9BDptpk9w1QoB0Mt/hu4h2iUsFSmZay9taM1jSzKL8WgXRbbYO1l5vgB BZa9ylxgoRPq/HtqNSLOhOmnABcWU+01pCVojGEWFSi42Orq7HyT+5xbXcbluAh70GvO 8Y1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L78E/1MnxD1hBP1t+WS4DRhsaOoQm0Wht6rAauydaTo=; b=mYiAN7IuDrlkaXQLOhKumRNyshH5bOIN1UY7pX+XddGYiqguspQRIk27khAYp0adl7 Az6vGgj00VptzYsQZ3wD6u4uSmcJyQlxq+0/vI8uRsw8D2aAnmZKFRHQ79jVzZ6YDyD5 gwffEmkGamlIEp1mGLKtdlCeBa3g5AmkHNUxFsSyOJ/I3n81UpdP3LwQzOGtnn0d7S2E A8VUCYWxJhDrX7d4LyTgEzkaHZvAug2X7wQX64k+NzwQdhyI+sC87hr8Sy/V2gl0Vsoq jvjm8OiBLGiizHbAuwCGFPEHojdEiFB/QMPI3O5nGiIDJjUOm6TA19lXzDB3NCHv0BT7 lgbg== X-Gm-Message-State: AFqh2ko4gOv31CTkINlabJyIFfDiZEvqlGuhfd5Nr9JVgGMz1iroTib6 ZU5N2OhjiRJX5gyYhBO+jlItpcq3BELNzhFfNDjqnf8U0WF7 X-Received: by 2002:ae9:f106:0:b0:705:28bf:f040 with SMTP id k6-20020ae9f106000000b0070528bff040mr2537205qkg.203.1673348981418; Tue, 10 Jan 2023 03:09:41 -0800 (PST) MIME-Version: 1.0 References: <20230110040427.1177958-1-roberto.foglietta@linuxteam.org> In-Reply-To: From: "Roberto A. Foglietta" Date: Tue, 10 Jan 2023 12:09:04 +0100 Message-ID: Subject: Re: [PATCH v2] dpkg: schroot migration then buildchroot references removed, v2 To: Jan Kiszka Cc: roberto.foglietta@linuxteam.org, isar-users@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-TUID: lYvc+S9/t/s7 On Tue, 10 Jan 2023 at 07:59, Jan Kiszka wrote: > > On 10.01.23 05:04, roberto.foglietta@linuxteam.org wrote: > > From: "Roberto A. Foglietta" > > > > dpkg, adding feature: migration to schroot > > > > I've only dropped this bit in > https://patchwork.isar-build.org/project/isar/patch/4a89ddd8-5be1-9aff-ab5c-579ecda50b8f@siemens.com/, > wasn't sure about the rest. How did you validate your cleanup? > > > # Add dependency from the correct schroot: host or target > > do_apt_fetch[depends] += "${SCHROOT_DEP}" > >> > The patchset v.2 by Anton Mikanovich to migrate buildchroot to schroot is not > > complete because the buildchroot is still used by the dpkg base class which can > > be freed by buildchroot with this patch which applies on the top of these four: > > > > * events: Cleanup lost schroot sessions if any, v2 > > * imager: Move image types to schroot, v2 > > * imager: Migrate from buildchroot to schroot, v2 > > * sbuild: Allow setting custom config paths, v2 > > > > v2: remove the lines instead of commenting them, better description > > > > Signed-off-by: Roberto A. Foglietta > > --- > > Patch version changes and dependencies generally go here, not above. > > > meta/classes/dpkg-base.bbclass | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass > > index 260aa73..ce150b3 100644 > > --- a/meta/classes/dpkg-base.bbclass > > +++ b/meta/classes/dpkg-base.bbclass > > @@ -5,7 +5,6 @@ > > # SPDX-License-Identifier: MIT > > > > inherit sbuild > > -inherit buildchroot > > inherit debianize > > inherit terminal > > inherit repository > > @@ -123,9 +122,6 @@ do_apt_fetch() { > > addtask apt_fetch > > do_apt_fetch[lockfiles] += "${REPO_ISAR_DIR}/isar.lock" > > > > -# Add dependency from the correct buildchroot: host or target > > -do_apt_fetch[depends] += "${BUILDCHROOT_DEP}" > > - > > @@ -193,8 +189,6 @@ BUILDROOT = "${BUILDCHROOT_DIR}/${PP}" > > dpkg_do_mounts() { > > mkdir -p ${BUILDROOT} > > sudo mount --bind ${WORKDIR} ${BUILDROOT} > > - > > - buildchroot_do_mounts > > } > > > > dpkg_undo_mounts() { > > Isn't there is more to clean up then? Are we still using BUILDROOT in > the end? In fact: Are we still calling dpkg_do_mounts at all?? your own patch tell me that your questions found an answer: dpkg-base: Drop dependency on buildchroot v2 > I don't > find references in the tree, today. Which tree? Of which repository? Best regards, R-