From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7021952409904611328 X-Received: by 2002:a05:6870:6c02:b0:148:1bb0:50 with SMTP id na2-20020a0568706c0200b001481bb00050mr579249oab.200.1670867345193; Mon, 12 Dec 2022 09:49:05 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6808:553:b0:35a:f69:4b04 with SMTP id i19-20020a056808055300b0035a0f694b04ls253723oig.6.-pod-prod-gmail; Mon, 12 Dec 2022 09:49:04 -0800 (PST) X-Google-Smtp-Source: AA0mqf4ZDdU690UFwBYYJNy/sV9eCR76hyYHl2rKJlpywq2wY9VEA/EplxUxsoDPAZJfFD+Lil5R X-Received: by 2002:a05:6808:30a9:b0:355:1deb:10a5 with SMTP id bl41-20020a05680830a900b003551deb10a5mr9821082oib.47.1670867344735; Mon, 12 Dec 2022 09:49:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670867344; cv=none; d=google.com; s=arc-20160816; b=0AIolzPK2TGxCC+Um3mvc2MzpDQB5+/xM5V1Hesx8C6VFjqNps+aU9mVAv7JrGNFT7 ODhgo0Z7mU4VV03WAxZOOfcH6U5xKJW8FcVyru7WWH9C91D92lBN41f/Kp4yDCnTUrDV vG41poYcOL+XsClSGHxVE8JPp0+bOS1559/CROF7H3b0wiqsAKwoVaW293XLG3lPLySP NaRPPfzpJ2OZ7KM+0hevMAz0CZ9mVESveJvlto6GjZWjQKGdMadC9BODNN+5OsMxpK17 M9YhgCn7lFA+YMUHlZOkTNfJ14t9I+GEdWD+B4UCCrs/4zUHQOUUw4EJnMbmwZnYmIP/ fcOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=/++hBMUSTLI942f2ffcTlomkgPigSznhKC9nR9/IJJs=; b=bDk71MQE0/kZfU6hlkg0u1egJco4Rlm4iCAfEbUtET5o0+1Z9ux8+NEYuRXhZUSaHa bmHIAMdaizcw/qQntsKFGBpMSrwggm4LQN1d2jcRIdBRJePjtW+Lyy7yLk+bjCpEzOJY EDTmsg9c75pFiENfi8L0N70HjVwpSj3qAfMmkUpupiiLbitFppUMcmQ5E+Q4cTyzPcFl X33QaYRT4LXgo1jDRA+ublkolC5s9r4HvbSk+Rk1CkaX+XW/cXwpaq9o+qz1ftetbFGV eW+jBZwM7EcexUocSsp04H0ZtEh76La1ClTMLGg6TIjESdp82UnbFtH7BK9Ajg2x87g8 48KQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lGPs89U1; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::82e as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com. [2607:f8b0:4864:20::82e]) by gmr-mx.google.com with ESMTPS id g84-20020acab657000000b00353e4e7f335si842552oif.4.2022.12.12.09.49.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 09:49:04 -0800 (PST) Received-SPF: pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::82e as permitted sender) client-ip=2607:f8b0:4864:20::82e; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lGPs89U1; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::82e as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-qt1-x82e.google.com with SMTP id x11so4229906qtv.13 for ; Mon, 12 Dec 2022 09:49:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/++hBMUSTLI942f2ffcTlomkgPigSznhKC9nR9/IJJs=; b=lGPs89U1DGrAZ94SbIwifeUMlN3q7FW031AwLR5agJ/gjCqhrZZFOrRKrMDQfPN2bf TBqT7Hi3jGwoBUk/zF16+aoPIGmxSY+Kafrvo49j9qKOYQ6h7u1o5gbd5SqBbw/V8DGn oBD5YbJbvYoLAIVrD0EIy/jHZVyqerL7G1B9aKpCtkf+rHIgNmulunBdjRs3atbvJhso W8L7QpY6eiOeupOX+vs9NB5vfbjzYLPKHRC+EaGP7JX9h/TT40y3o8I4YrGAfZ4/H6XQ Se1OtNoMZHFr/IoCCKZ4CeBmEd+sAzhfsJ9YtCBXdrUtbBghNY2byxNbdQe/8JL7IkpL y88Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/++hBMUSTLI942f2ffcTlomkgPigSznhKC9nR9/IJJs=; b=hcE5XX3g8wynglxKcWZztzzog+luzTm2qNSHE0iiA1BBv3taZnjNKcFFMeztEQwRAP Ms0U4U2JeT5IVtx2J/g/eqqzy9aWf/4LQnnDSpZoD7yiFmDDaTaI+iFhDavdRlPlqrCi SR1gopyTfECzBlmbiLdoma/CbPRT8Am+iRpAHDhbGnN/azhv8q+V/A5yB+VsUUgin+DE WJDjM7NaQIqOeLz2c5nGDw1JEKuH0wBitzATyNZCrx68lmQKyBVNV44YkjuJOolImWzy QMIjYs06DZs9ZEwVRv9lgtWbtBLdlnJgTf78bKq7D05z356rkEPMcLoQJx/5wAwgp4J/ HiaQ== X-Gm-Message-State: ANoB5pnDvVcU7fEcrk8pCVLstR991/fW3GDjQ0wYzdKh5ycRTCItspBf c7S/s7DTIpUiuISZKfCD3VyG316XHnfqT9V7JttUtWK9/qOY X-Received: by 2002:a05:622a:258a:b0:3a8:199d:48ee with SMTP id cj10-20020a05622a258a00b003a8199d48eemr154895qtb.461.1670867344128; Mon, 12 Dec 2022 09:49:04 -0800 (PST) MIME-Version: 1.0 References: <18299964-6809-d6a0-0f90-3ec6a785695c@siemens.com> <20211022195047.262589-1-joe_macdonald@mentor.com> <20221212162419.2760544e@md1za8fc.ad001.siemens.net> In-Reply-To: <20221212162419.2760544e@md1za8fc.ad001.siemens.net> From: "Roberto A. Foglietta" Date: Mon, 12 Dec 2022 18:48:25 +0100 Message-ID: Subject: Re: [PATCH v2] expand-on-first-boot: support resizing a btrfs root To: Henning Schild Cc: Joe MacDonald , isar-users@googlegroups.com, joe.macdonald@siemens.com Content-Type: text/plain; charset="UTF-8" X-TUID: Wyoz3TxB4sQM On Mon, 12 Dec 2022 at 16:24, Henning Schild wrote: > > Joe, i had to rewrite your patch considerably. So i think i will change > the authorship to myself. I would really like to give you the credits > but am afraid to give you blame ... this whole expand story seems never > ending ... > So the patch will mention you, but likely not as author. > Thank you in advance for the mention. I wish to point out to you the fact that supporting the btrfs is completely another issue than triggering the udev to link the device and frankly speaking I do not see the reason to keep the two things together. So, my ancestor patch and the following development correctly address the btrfs support but inherit the problem of failing when "${LAST_PART}" == "" which is a completely another story because it depends on udev. Also the code to trigger udev in order to create the devices links has been presented here from another project of mine. So, the mention makes sense. As a mere recap, this story should never have started at all. Because there were two separate problems, no one of them was my duty to solve. Moreover, the team got stuck into the idea of supporting every filesystem on every platform: wrong approach. First separate legacy from development, second fix a problem at time, third follows a continuous improvement and continuous delivery model. The btrfs support was not mandatory but suggested for the future due to its intrinsic characteristics and the performance improvements delivered into kernel v6.1. Your mandatory problem was to deal with udev on a specific hardware platform and this was confused with a ext4 resizing failure - sometimes fails sometimes not depending the udev timings (as far as I can remember) - so the btrfs got into the scene as a suggestion to discard a software failure in resizing. If both fail the problem is somewhere, in fact. > but am afraid to give you blame The only blame you can give to me is not being in charge of this at no any time but trying to help without even having a piece of hardware to make a test. In fact, the udev tests/code I did - I did on my Christmas present for my nephew! Best regards, R-