Re: [PATCH v2] dpkg: schroot migration then buildchroot references removed, v2

["Roberto A. Foglietta" <roberto.foglietta@gmail.com>]

On Tue, 10 Jan 2023 at 05:04, <roberto.foglietta@linuxteam.org> wrote:
>
> From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
>
> dpkg, adding feature: migration to schroot
>
> The patchset v.2 by Anton Mikanovich to migrate buildchroot to schroot is not
> complete because the buildchroot is still used by the dpkg base class which can
> be freed by buildchroot with this patch which applies on the top of these four:
>
>     * events: Cleanup lost schroot sessions if any, v2
>     * imager: Move image types to schroot, v2
>     * imager: Migrate from buildchroot to schroot, v2
>     * sbuild: Allow setting custom config paths, v2
>
> v2: remove the lines instead of commenting them, better description
>
> Signed-off-by: Roberto A. Foglietta <roberto.foglietta@gmail.com>
> ---
>  meta/classes/dpkg-base.bbclass | 6 ------
>  1 file changed, 6 deletions(-)


Hi all,

to complete the migration to schroot the patch above should be applied.

I also suggest to review the code in these two files and three functions:

meta/classes/image-tools-extension.bbclass

do_start_imager_session()
do_stop_imager_session()

b/meta/classes/isar-events.bbclass

stop_schroot_session()

In particular in this function stop_schroot_session() the code could
be factorized in common with do_stop_imager_session() using a function
like stop_schroot_session() to use everywhere is necessary.

About this, I am going to send the following patch

v7-0001-image-tools-ext.-start_imager_session-not-break-t.patch

Best regards, R-