From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7186869599348981760 X-Received: by 2002:a0c:d80a:0:b0:4c7:9c7:e6a4 with SMTP id h10-20020a0cd80a000000b004c709c7e6a4mr3963502qvj.105.1673324699106; Mon, 09 Jan 2023 20:24:59 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:622a:4889:b0:397:ab6a:3f0 with SMTP id fc9-20020a05622a488900b00397ab6a03f0ls5272188qtb.0.-pod-prod-gmail; Mon, 09 Jan 2023 20:24:58 -0800 (PST) X-Google-Smtp-Source: AMrXdXs9lB+8OyGKA3FTZhN5HakB/RR/tP1CJFRA0qyY762IF3VU6bdb4b1asKVMueBWcxyV3V5d X-Received: by 2002:a05:622a:a0b:b0:3a6:a7f6:701d with SMTP id bv11-20020a05622a0a0b00b003a6a7f6701dmr107486652qtb.36.1673324698412; Mon, 09 Jan 2023 20:24:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673324698; cv=none; d=google.com; s=arc-20160816; b=HSfo4LNIprGdGpSz9Xte5C0PCHMP8bU78N6lRF/sjLP0eoCqMn+hZQbUqqWrkwcrDX IUIrQ6xhQQcrDf4zYsIkzn3Bz1M/dBpJCpo/af/Mcfk4JJZLL+qLIbJjuOFhYV2svAYR /mXTJWJvQAiQ9hx8VkpOlP+sfp18bGQp5rUSu5ArAhna+WOhhFPNxGSEqJdM8L2tR4QE /e+Cz3823jBK6G+P4gjZbcOlT6XUtYnvYVU1ZyCFIptCzrvljHDA0DYhu0DO2EdX8DwT a8rB7aBAm0l+MSe8KtTDAvYJNeD9DJAYTPx3y+OnN4ZPb5zoJ426mgwWO0i5ZQWZoYSd 5e7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=DP4I2WLvnvY4JaZi5JCERsdQ8cviNzhYo5RorCA7ZB0=; b=gNfpuG2KC3ud12ANYkww2bgv2MIJgohF6li0SRFaCJtU1FdokPSa8lP4EZsYggrWHC 27yUXLJ4YwLw98VA7EINBOOfTDG5CZVgruH5FsWaEXGzcvZV+9u7ESi644oGkiyLUsLw 3XzNskGEsZyGBM2mkwohANcy7vv2GR9KJqwFhKjOqiS8+TwlNMZpTIjz5YcA635VUYTW ImtVIbas523Wac12XZX2YEK8butLRzK7CXsEf3XEaqDxQJ299b6YT0GoUl4s4by7JrCq 4LY/DP2C/XWBI+xsPd5HISYALRxR6KICdRWbwmM90f8S5RV9JCtQhfcNQXSd6UX+LuhM 6edQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=nLj4rOg1; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::730 as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com. [2607:f8b0:4864:20::730]) by gmr-mx.google.com with ESMTPS id l27-20020ac84cdb000000b003a577449007si735676qtv.2.2023.01.09.20.24.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 20:24:58 -0800 (PST) Received-SPF: pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::730 as permitted sender) client-ip=2607:f8b0:4864:20::730; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=nLj4rOg1; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::730 as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-qk1-x730.google.com with SMTP id g8so5311868qkl.2 for ; Mon, 09 Jan 2023 20:24:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DP4I2WLvnvY4JaZi5JCERsdQ8cviNzhYo5RorCA7ZB0=; b=nLj4rOg1I4ELVczWYHe3yPtCe/MuOQU808OkvKHYVQryDrTdeRuKYZbAM3gixxKBrr KyGRhkjfqxlx8plmk5kN/upSca5jiqEpAy4zyt0ofFbrp4NnrRkCZtmuw6LvQXijubai z4Aj1V7/2LcxS0ST19OojmlCdEyP5lXmlfJOwegX29EJNjnabYWpsfHQvrTWu2lyd1JD UCmwF7KFdBwHg8apzwkg0OY30iHHNgoKdabnUdld6l0+qUC93vjlSLyebTLrwh+CeofG c4yhZP48AD+HlUb+jiljA6k5Z/maLqDkTc8QZVR9LomJT3gmD+GgCEFrzOl8IxwYoyae /Img== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DP4I2WLvnvY4JaZi5JCERsdQ8cviNzhYo5RorCA7ZB0=; b=BIORhIJbeuKaVxLD/38GLSvOHn0JC8Su+vFiu42bhezV0+lLADKSyqRGtmTs68E32e /6mfKQ0TfW8TSUB53U9mXAH3si3zEai6cH1i37MadHwK/fwDSnTEWGNL9N1QwCpFqW29 8PTMvRHG0laLusVF7wNyskchV5EPlKjoPPjFqdj7ZZwP11TIjtuXBi+xdBctgjgenRA9 +53kc1Dtrm5xGMUPX1iFa5J6Veuvv2jwtFk0yZQwvIlu3T6AAC9A5IslhF6bXcxMiUH5 AyH8NyicJVQoE9Ke9bPRI/RPalnIbpLIYAqYoEoOCPuVgYBAYtZsrDsZaxNexBgyZFPq w9vw== X-Gm-Message-State: AFqh2kpmLySIaeOnQrQH9dNfc37HQPhvBG3Zjf3Iy7mPAnnIKxBPWAcB +CLuKF/wyn1NBaVbShBWE9PvQRMYyOaRfsNaWDhvituCmVL4 X-Received: by 2002:a05:620a:1a9c:b0:6fc:9680:fd44 with SMTP id bl28-20020a05620a1a9c00b006fc9680fd44mr4008666qkb.223.1673324698048; Mon, 09 Jan 2023 20:24:58 -0800 (PST) MIME-Version: 1.0 References: <20230110040427.1177958-1-roberto.foglietta@linuxteam.org> In-Reply-To: <20230110040427.1177958-1-roberto.foglietta@linuxteam.org> From: "Roberto A. Foglietta" Date: Tue, 10 Jan 2023 05:24:21 +0100 Message-ID: Subject: Re: [PATCH v2] dpkg: schroot migration then buildchroot references removed, v2 To: roberto.foglietta@linuxteam.org Cc: isar-users@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-TUID: U2A2pRfYph2y On Tue, 10 Jan 2023 at 05:04, wrote: > > From: "Roberto A. Foglietta" > > dpkg, adding feature: migration to schroot > > The patchset v.2 by Anton Mikanovich to migrate buildchroot to schroot is not > complete because the buildchroot is still used by the dpkg base class which can > be freed by buildchroot with this patch which applies on the top of these four: > > * events: Cleanup lost schroot sessions if any, v2 > * imager: Move image types to schroot, v2 > * imager: Migrate from buildchroot to schroot, v2 > * sbuild: Allow setting custom config paths, v2 > > v2: remove the lines instead of commenting them, better description > > Signed-off-by: Roberto A. Foglietta > --- > meta/classes/dpkg-base.bbclass | 6 ------ > 1 file changed, 6 deletions(-) Hi all, to complete the migration to schroot the patch above should be applied. I also suggest to review the code in these two files and three functions: meta/classes/image-tools-extension.bbclass do_start_imager_session() do_stop_imager_session() b/meta/classes/isar-events.bbclass stop_schroot_session() In particular in this function stop_schroot_session() the code could be factorized in common with do_stop_imager_session() using a function like stop_schroot_session() to use everywhere is necessary. About this, I am going to send the following patch v7-0001-image-tools-ext.-start_imager_session-not-break-t.patch Best regards, R-