From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7176514492887465984 X-Received: by 2002:a05:6808:2086:b0:35b:f424:9b3b with SMTP id s6-20020a056808208600b0035bf4249b3bmr87882oiw.28.1671004358095; Tue, 13 Dec 2022 23:52:38 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:aca:1906:0:b0:345:9a88:c799 with SMTP id l6-20020aca1906000000b003459a88c799ls1056321oii.5.-pod-prod-gmail; Tue, 13 Dec 2022 23:52:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf4mklcLsa+SY1zVE+TmO1fXjQANsdBxpMW8X5aQztlFwVAj6iRfIfd6z7A8YOqRhsAlQymO X-Received: by 2002:a05:6808:2d8:b0:35e:5b18:2ad1 with SMTP id a24-20020a05680802d800b0035e5b182ad1mr8717832oid.55.1671004357424; Tue, 13 Dec 2022 23:52:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671004357; cv=none; d=google.com; s=arc-20160816; b=Z/hen8reAqpTuhnfbvhBHhp8xWy9euh8RxEbc86cfY0uji+yNRcMrzxjutQMUda8RH +hYCygkpA+nL+LEofxjv0e8NzEWCfCXZ1T+eFGg1hyn9j0Z7lD2Fi+oLbrKaoZ8uFk8r VsMkQEIdHD8Gwpc9tfUrmMer4TnM8OHJXLNm8/gGhvBjdIZBI3m+4oe/liAo0uyYmgfH fPvhauWs5rn+oAq1IWZ6/CwquqHEEcmVGEpgytHR/Hsnxt+ZZVzIFm0qiSXk1QJ0vg9t qhmV3sWp2+kZOBbzVAw7/D+zVT6aHgjLI62pXmVJjS5AmQbmFwOPH0nqCuyx9y+ZWZ1Y MAAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:subject:message-id:date:from:mime-version:dkim-signature; bh=GzVCme8a/4P33eNLUEToFzEZdBzvWeHTBabxxMMsNTs=; b=fsU8jPbCeIA1sACpZS7FcSisMls0IDVirX6ebiLFHLJjPFGdcSLtcqiI0S90H7+KDD 7Xlbw3tzulh+Vr0RZPHoe7vZN/KQetBMsjkJuayPkMAQGTx1ja6J5Qx95j7mGZJZZ38u dD41ku8lI4hH+lVI9ub33e7s2dngPtG1QpEamTS5QhGVz7xInOFA+AkOIeIJZbkramdp O0EdlVxcGCgTv92yKwUIbnAZildxvHRzAtmUwmgqUjiTwcehxsZtfs/sYwROu8lc9DsY JkUUzx8//b3iOJ3++6YMM4oqph5Mv/SvjHNNkQUY0xaJ7goWxcZ+O3U6tbBmpa5cFZZ7 CZMw== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YYKLFE1h; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::82a as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com. [2607:f8b0:4864:20::82a]) by gmr-mx.google.com with ESMTPS id p8-20020acad808000000b0035446541a0fsi813559oig.5.2022.12.13.23.52.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Dec 2022 23:52:37 -0800 (PST) Received-SPF: pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::82a as permitted sender) client-ip=2607:f8b0:4864:20::82a; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YYKLFE1h; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::82a as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-qt1-x82a.google.com with SMTP id fu10so1962848qtb.0 for ; Tue, 13 Dec 2022 23:52:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=GzVCme8a/4P33eNLUEToFzEZdBzvWeHTBabxxMMsNTs=; b=YYKLFE1h1UBELyQV2TGqtH0TavfoxblrNdGtyN4pFnAXJBv95MlslG57xHQoip0yrj QGuKpwYdE+52kwL/vN0VJ5ZKDUTW2Y8sQS1pWHuT4XKedIs9h1jMzE5xKTTAkDLDll0n 90yTRXCM1hGazkHii5Z9vfDyvUuKpSwDYoq6+geVZVh6bb+oBJvk6FzVHsfPS4qQ9vwE whjZj29h+aWlgIQjTzoaJcKZ/xvpzsKk+dF7VrGENpqgWfXEMPAUqvYCasuLhRW/5Typ mUTsttr49v5CRDJEaTcp4MB502z3M1bgXH5Yg+Wtw5ZwjD+vINBitfGfuYS56QF73+Qu BEfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GzVCme8a/4P33eNLUEToFzEZdBzvWeHTBabxxMMsNTs=; b=QpPtF3bh6IwTaWgTR4LwO5cDda1FIVwFKpKFh0MMQGDG+LQLWrQyOhJEjFrLJNwcQP CtxHk0jnDYwhGQA5PI4HRCy8bWjR3WJdGth3anNDC78QrjJIJlzsT5FnDTA74b+DDgpW usCD/QYALIR8AOrnzXW/kaPmSI4jaYGc1ru2moFEejJbDlshqXPZb1oha+IK5Nda8y/w Nss0ji7stZHThWXOxN59eQ44gh7qtxQ2jXWyicmgoSfjKdYBiRDevuGZ6slam1n0md+q 7MB/QULPa7pLgc/3qLFXR0EEFT0jGW6toXne8U1DM0S3o6RpWdH1D8inaviRk9rNj5Ey jwAA== X-Gm-Message-State: ANoB5pkEpZj1JVM/aV8zao/iUf30R1EQIfVjVom0KJmvWZmSoFM0QWaT K8BICwPLJOJSwGekI37Xc12cLw0fbGsYT05QQpsqDitb8pXB X-Received: by 2002:ac8:4e14:0:b0:3a7:648d:23d3 with SMTP id c20-20020ac84e14000000b003a7648d23d3mr17807203qtw.19.1671004356648; Tue, 13 Dec 2022 23:52:36 -0800 (PST) MIME-Version: 1.0 From: "Roberto A. Foglietta" Date: Wed, 14 Dec 2022 08:52:00 +0100 Message-ID: Subject: [PATCH v2] If expand last partition fails, unsupervised systems reboot To: isar-users@googlegroups.com Content-Type: multipart/mixed; boundary="00000000000018ec6505efc5058c" X-TUID: eCqnRCiwDsut --00000000000018ec6505efc5058c Content-Type: text/plain; charset="UTF-8" Hi all, in the expand last partition script I read this code ROOT_DEV="$(findmnt / -o source -n)" [...] BOOT_DEV="$(echo "${ROOT_DEV}" | sed 's/p\?[0-9]*$//')" if [ "${ROOT_DEV}" = "${BOOT_DEV}" ]; then echo "Boot device equals root device - no partitioning found" >&2 trap - EXIT exit 1 fi this means that there are no partitions because the boot partition /dev/sda is equal to root partition /dev/sda, which happens only when there is no partition table. roberto$ echo /dev/sda2 | sed 's/p\?[0-9]*$//' /dev/sda (which is different than /dev/sda2) roberto$ echo /dev/sda | sed 's/p\?[0-9]*$//' /dev/sda (there is no partition table) That's ok but not exit 1 because IMHO, it will retry again the next time but nothing will change the next time so it will continue to try and fail at every boot. Because one-time-only in systemd means one-successful-time-only and exit 1 prevents disabling the operation. So, exit 0 would be the correct code to execute and this is the reason because I removed the trap which would make an unsupervised system reboot. The patch v2 has been sent using the elastic mail SMTP and went in moderation, here in attachment. Best regards, R- --00000000000018ec6505efc5058c Content-Type: text/x-patch; charset="US-ASCII"; name="v2-0001-If-expand-last-partition-fails-unsupervised-syste.patch" Content-Disposition: attachment; filename="v2-0001-If-expand-last-partition-fails-unsupervised-syste.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lbncstwn0 RnJvbSAxNGNmZjJiYzE1MGIxYmU3N2Q1ZGU0MjUzYWMzZTkyZGYyYjRiMGY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiUm9iZXJ0byBBLiBGb2dsaWV0dGEiIDxyb2JlcnRvLmZvZ2xp ZXR0YUBnbWFpbC5jb20+CkRhdGU6IFR1ZSwgMTMgRGVjIDIwMjIgMDc6MTQ6MjUgKzAxMDAKU3Vi amVjdDogW1BBVENIIHYyXSBJZiBleHBhbmQgbGFzdCBwYXJ0aXRpb24gZmFpbHMsIHVuc3VwZXJ2 aXNlZCBzeXN0ZW1zCiByZWJvb3QKCkltcHJvdmVtZW50IGZvciB1bnN1cGVydmlzZWQgZW1iZWRk ZWQgZGV2aWNlcyB3aGljaCBuZWVkIHRvIHJlYm9vdCBpZiBleHBhbmQgbGFzdApwYXJ0aXRpb24g ZmFpbHMgYmVjYXVzZSBhIHVuZGVyLXByb3ZpZGVkIHN5c3RlbSBzaG91bGQgbm90IGV2ZW4gY29t cGxldGUgdGhlIGJvb3QKaW4gdGhlIGZpZWxkIGluIG9yZGVyIHRvIGF2b2lkIGZ1bmN0aW9uaW5n IGZhaWx1cmVzIGF0IHVuZXhwZWN0ZWQgZnV0dXJlIHRpbWUuClRoaXMgcGF0Y2ggZG8gbm90IGFm ZmVjdCB0aGUgcHJldmlvdXMgYmVoYXZpb3VyIGJlY2F1c2UgcmVxdWlycyAvZXRjL3Vuc3VwZXJ2 aXNlZAoKVGhpcyBwYXRjaCBhcHBsaWVzIGFmdGVyIHRoZSBmb2xsb3dpbmcgb3RoZXIgcGF0Y2hl czoKCiAtIEluIGV4cGFuZCBsYXN0IHBhcnRpdGlvbiBzY3JpcHQgYnRyZnMgc3VwcG9ydCBhZGRl ZAogLSBJbiBleHBhbmQgbGFzdCBwYXJ0aXRpb24gd2FpdCBmb3IgdWRldiBoYXZlIGZpbmlzaGVk Cgp2MjogaWYgdGhlcmUgaXMgbm8gcGFydGl0aW9uIHRhYmxlIGV4aXQgMCBpbnN0ZWFkIG9mIGV4 aXQgMQoKU2lnbmVkLW9mZi1ieTogUm9iZXJ0byBBLiBGb2dsaWV0dGEgPHJvYmVydG8uZm9nbGll dHRhQGdtYWlsLmNvbT4KLS0tCiAuLi4vZXhwYW5kLW9uLWZpcnN0LWJvb3QvZmlsZXMvZXhwYW5k LWxhc3QtcGFydGl0aW9uLnNoICAgfCA4ICsrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbWV0YS9yZWNpcGVzLXN1cHBv cnQvZXhwYW5kLW9uLWZpcnN0LWJvb3QvZmlsZXMvZXhwYW5kLWxhc3QtcGFydGl0aW9uLnNoIGIv bWV0YS9yZWNpcGVzLXN1cHBvcnQvZXhwYW5kLW9uLWZpcnN0LWJvb3QvZmlsZXMvZXhwYW5kLWxh c3QtcGFydGl0aW9uLnNoCmluZGV4IGY1YmNhZDEuLjJjNTJiMTYgMTAwNzU1Ci0tLSBhL21ldGEv cmVjaXBlcy1zdXBwb3J0L2V4cGFuZC1vbi1maXJzdC1ib290L2ZpbGVzL2V4cGFuZC1sYXN0LXBh cnRpdGlvbi5zaAorKysgYi9tZXRhL3JlY2lwZXMtc3VwcG9ydC9leHBhbmQtb24tZmlyc3QtYm9v dC9maWxlcy9leHBhbmQtbGFzdC1wYXJ0aXRpb24uc2gKQEAgLTksNiArOSw4IEBACiAKIHNldCAt ZQogCit0ZXN0IC1lIC9ldGMvdW5zdXBlcnZpc2VkICYmIHRyYXAgcmVib290IEVYSVQKKwogdWRl dmFkbSBzZXR0bGUKIAogUk9PVF9ERVY9IiQoZmluZG1udCAvIC1vIHNvdXJjZSAtbikiCkBAIC0y MSw3ICsyMyw4IEBAIGZpCiBCT09UX0RFVj0iJChlY2hvICIke1JPT1RfREVWfSIgfCBzZWQgJ3Mv cFw/WzAtOV0qJC8vJykiCiBpZiBbICIke1JPT1RfREVWfSIgPSAiJHtCT09UX0RFVn0iIF07IHRo ZW4KIAllY2hvICJCb290IGRldmljZSBlcXVhbHMgcm9vdCBkZXZpY2UgLSBubyBwYXJ0aXRpb25p bmcgZm91bmQiID4mMgotCWV4aXQgMQorCXRyYXAgLSBFWElUCisJZXhpdCAwCiBmaQogCiAjIHRo aXMgdmFsdWUgaXMgaW4gYmxvY2tzLiBOb3JtYWxseSBhIGJsb2NrIGhhcyA1MTIgYnl0ZXMuCkBA IC0zNyw2ICs0MCw3IEBAIGRvbmUKIE1JTklNQUxfU0laRT0kKChBTExfUEFSVFNfU0laRSArIEJV RkZFUl9TSVpFKSkKIGlmIFsgIiRESVNLX1NJWkUiIC1sdCAiJE1JTklNQUxfU0laRSIgXTsgdGhl bgogCWVjaG8gIkRpc2sgaXMgcHJhY3RpY2FsbHkgYWxyZWFkeSBmdWxsLCBkb2luZyBub3RoaW5n LiIgPiYyCisJdHJhcCAtIEVYSVQKIAlleGl0IDAKIGZpCiAKQEAgLTcyLDMgKzc2LDUgQEAgY2Fz ZSAkKGxzYmxrIC1mbm8gRlNUWVBFICIke0xBU1RfUEFSVH0iKSBpbgogCQl1bW91bnQgJHRtcGRp ciAmJiBybWRpciAkdG1wZGlyCiAJCTs7CiBlc2FjCisKK3RyYXAgLSBFWElUCi0tIAoyLjM0LjEK Cg== --00000000000018ec6505efc5058c--