public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: isar-users@googlegroups.com
Subject: Re: [PATCH] linux install.tmpl: added CONFIG_HAVE_OBJTOOL in OR for objtool
Date: Mon, 7 Nov 2022 10:46:02 +0100	[thread overview]
Message-ID: <CAJGKYO4qe2yJi6M9bhxEtfe0ZhkaO6hyJ00kw+k6GThEun3PBw@mail.gmail.com> (raw)
In-Reply-To: <20221107100235.48b07775@md1za8fc.ad001.siemens.net>

On Mon, 7 Nov 2022 at 09:02, Henning Schild <henning.schild@siemens.com> wrote:
>
> Am Thu, 03 Nov 2022 15:55:19 +0000
> schrieb roberto.foglietta@gmail.com:

> > -    if [ -n "${CONFIG_STACK_VALIDATION}" ]; then
> > +    if [ -n "${CONFIG_STACK_VALIDATION}" -o -n
> > "${CONFIG_HAVE_OBJTOOL}" ];
>
> !x || !y is the same as ! (x && y)
>
> i would find the latter more readable
>

Dear Henning,

first of all, thanks for your feedback. Considering man test:

    -n STRINGthe length of STRING is nonzero

it should be read as (X OR Y). Instead, using AND would be:

     if ! test -z "${x}" -a -z "${y}"; then

For this reason, I think that the patch is correct.

Best regards, R-

  reply	other threads:[~2022-11-07  9:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 15:55 roberto.foglietta
2022-11-07  8:02 ` Henning Schild
2022-11-07  9:46   ` Roberto A. Foglietta [this message]
2022-11-17  8:30 ` Anton Mikanovich
2022-11-17 20:28   ` Roberto A. Foglietta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJGKYO4qe2yJi6M9bhxEtfe0ZhkaO6hyJ00kw+k6GThEun3PBw@mail.gmail.com \
    --to=roberto.foglietta@gmail.com \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox