From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7162240210896420864 X-Received: by 2002:a05:6e02:1bc7:b0:2fa:876e:95a7 with SMTP id x7-20020a056e021bc700b002fa876e95a7mr28582724ilv.240.1667814401475; Mon, 07 Nov 2022 01:46:41 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a02:85c8:0:b0:374:99b0:f48f with SMTP id d66-20020a0285c8000000b0037499b0f48fls2315244jai.5.-pod-prod-gmail; Mon, 07 Nov 2022 01:46:41 -0800 (PST) X-Google-Smtp-Source: AMsMyM7/y3tFzkCzA7rZ2FBITgBwBCCGmSAthmtw2NbLtPUeeNFHHBvxRCPk5I1Qg18N2z3HFBJ6 X-Received: by 2002:a05:6638:c51:b0:375:8bcb:7b5c with SMTP id g17-20020a0566380c5100b003758bcb7b5cmr13801185jal.255.1667814400988; Mon, 07 Nov 2022 01:46:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667814400; cv=none; d=google.com; s=arc-20160816; b=sG/GbKsEfVt7MfZJ32JH2A1csbotvfu9q7/GRqWzcSBVvrkaM9KwbeauXgQ6n/C1u7 RQsZCs00Q3WaML2fZk/cpNkdO0qjtokC2RR7zFcf3x4XMngxwjodvBgoGorQ5gprnkiG ia+6AG3Zx01mGKFFy3z3VWG0HDDCwMEFhP8p+EAF96aOEQ7swIHNA4otiKoVf573n17P v+CyHQPPf6Xl8gRl8WBhR9SUglPlAyn8RK7v362UPEjIPgB0JFNG4s7pBz3rt0v1rANj YuLfp3GqtoONJVs5Y47GphH8YDf+Ca6+2b40xAKm7Beg1xHrz5tq6D5aI7fSYmZi8O3K PA2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=TxG8ZR2TnXEv4TpqtbaSk//1WmKkIa13Res3b9DyJCY=; b=aYOVxJyPjmxdwlaJRxS6ZDH+dhxoshFNrs2ArGw6utaBLfuSRlwS1zRM2E0FYcgcvo KoLjkK3Nhea7RMcZvlTEaNIgRB3LzxZLanJY+vKFe7pQrjq4mSuwJi6zvEwcnq0Ix6UH 2UPwd3aqx1+nOlrFcOwWFKSkXHb1+TPrQdfHaOqdJDZzP4s4/wgYuMbYmlyp7YeuONZS 8QUlTTTsy9Oo8AfB7Mh3Ipf2BLOOXDzSEjZ3B2esQFYZ3otiO04LprGm9tpEY0XN5qNl R2MxvhEfDt2R/HzAeijR/KxwdBV2RhtfJdV48PqDGNHdprxWA+vkUNaq6ZxYI4MGqvqs yKVA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=CGDlh6qD; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::633 as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com. [2607:f8b0:4864:20::633]) by gmr-mx.google.com with ESMTPS id p36-20020a027824000000b00349dba16b8dsi220124jac.6.2022.11.07.01.46.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Nov 2022 01:46:40 -0800 (PST) Received-SPF: pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::633 as permitted sender) client-ip=2607:f8b0:4864:20::633; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=CGDlh6qD; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::633 as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-pl1-x633.google.com with SMTP id y4so10576693plb.2 for ; Mon, 07 Nov 2022 01:46:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TxG8ZR2TnXEv4TpqtbaSk//1WmKkIa13Res3b9DyJCY=; b=CGDlh6qDrXhG7t174+yqviJ3+sc1k/cIHwmTPqf8Dmo6ZDs7jlugXB7h6Jxk5edorU r9QcEYw7NBq/6b7QZ7TV9Tz3VMwF5eP3KTCY45B1Y3omRwxEK/3JxCYbj9+NKsLEgzJq eM0UtuOqLNfFp8Y5/IIBUPRG2nZrhR7+sNbYOH9cwxz9NKmcUmSbgL/vtWs3W22JHiwU 6WheWPfRGEt2z/BNE5zDbuQ5BZEMHjfRmoaGH4am+FwF+Z0CYVjK3XPt7UAYIR9H4IEC kUORaRlyAhYH5wvo1QiwE/weWokDA8YQTB4IV5Bw9EfR8EjsfmU8d10UhCRoTkO7fwqp 0GQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TxG8ZR2TnXEv4TpqtbaSk//1WmKkIa13Res3b9DyJCY=; b=EkSyoZMwY422iILrybRbIFT+xbfmxs5zLtIs54nmc1uT6rCE1R9OBIOyIq47vdPkfK A13VO7zLdCw36esRQtZWkujAyskrvRsYFJseRrymkKpy+QM/l2oi7Mn7LdNN+J2c/Lrr RdzWZIJe6CJhhFzV1NV5PuL7S1NnylqxwXVhnWx0XLS5hCbp4eEyr+/2+msmu5wDWn1x mGfUUePzwkM0//reteQ/08S0SyhAEJIwA8PsewGJOT3ls2vvysQKTVAfcMhrouChBoJT jmV9NgsU/+RQWnE19UpWcVT/mRmg3+2+Ig+ZyVyM7BwaI17YHorRJl4gRzrDzxrT5uHU zJIw== X-Gm-Message-State: ACrzQf1a4YOXLUe2Gs943/3uO+8kF7bNkAIqSwiJ2QF6LExKD/lzJmPs WcId30E1CHCQ/afJUtmpGIT3tlnArkTqfngw97/OfvcISzMXeDA= X-Received: by 2002:a17:903:1245:b0:178:9234:3768 with SMTP id u5-20020a170903124500b0017892343768mr50017191plh.146.1667814400254; Mon, 07 Nov 2022 01:46:40 -0800 (PST) MIME-Version: 1.0 References: <4uib2il4q62q.q_EMhEP7Ci2DAvn54u8ALw2@16F0H.trk.elasticemail.com> <20221107100235.48b07775@md1za8fc.ad001.siemens.net> In-Reply-To: <20221107100235.48b07775@md1za8fc.ad001.siemens.net> From: "Roberto A. Foglietta" Date: Mon, 7 Nov 2022 10:46:02 +0100 Message-ID: Subject: Re: [PATCH] linux install.tmpl: added CONFIG_HAVE_OBJTOOL in OR for objtool To: Henning Schild Cc: isar-users@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-TUID: EUy/hRciObII On Mon, 7 Nov 2022 at 09:02, Henning Schild wrote: > > Am Thu, 03 Nov 2022 15:55:19 +0000 > schrieb roberto.foglietta@gmail.com: > > - if [ -n "${CONFIG_STACK_VALIDATION}" ]; then > > + if [ -n "${CONFIG_STACK_VALIDATION}" -o -n > > "${CONFIG_HAVE_OBJTOOL}" ]; > > !x || !y is the same as ! (x && y) > > i would find the latter more readable > Dear Henning, first of all, thanks for your feedback. Considering man test: -n STRINGthe length of STRING is nonzero it should be read as (X OR Y). Instead, using AND would be: if ! test -z "${x}" -a -z "${y}"; then For this reason, I think that the patch is correct. Best regards, R-