Re: [PATCH v2] If expand last partition fails, unsupervised systems reboot

["Roberto A. Foglietta" <roberto.foglietta@gmail.com>]

On Wed, 14 Dec 2022 at 10:05, Henning Schild <henning.schild@siemens.com> wrote:
>
> Am Wed, 14 Dec 2022 09:47:07 +0100
> schrieb Henning Schild <henning.schild@siemens.com>:
>
> > Patch can not be reviewed so i can as well top-post.
> >
> > We should maybe separate the discussion with the reboot trap and the
> > unsupervised file from the "aligning the nothing to do exit code to 0"
>
> I think it might also be a good idea to set
>
> ExecStopPost=-/bin/systemctl disable expand-on-first-boot.service
>
> in addition to ExecStartPost doing the same. So no matter if we succeed
> or not, we only give it one try. But i did not test that.

if it fails, it is a good thing to retry the next time. Some issues
might depend on boot timing which might be variable. if you want to
test what happens put a "false" as first instruction after set -e and
you will see. In any case the script should be written to be able to
cope with a different behaviour of the systemd between failure and
success because tomorrow we can change that. (reasonable
generalisation).

By the way my patch does not only change the exit 1 with exit 0 but
set a trap on exit to reboot the unsupervised systems to go working in
production without the planned filesystem resize = underprovided =
nasty failures at future unpredictable time. It is easy to revise a
patch that is just a text file attached to an e-mail... LOL

Best, R-