From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7176514492887465984 X-Received: by 2002:a63:525e:0:b0:477:bca8:1cd9 with SMTP id s30-20020a63525e000000b00477bca81cd9mr61806849pgl.581.1671009898196; Wed, 14 Dec 2022 01:24:58 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:903:3255:b0:187:488a:58c8 with SMTP id ji21-20020a170903325500b00187488a58c8ls21754207plb.9.-pod-prod-gmail; Wed, 14 Dec 2022 01:24:57 -0800 (PST) X-Google-Smtp-Source: AA0mqf4IdkdGM+uZWYdnArdt/56qmKuWQiAnlzgv/AaEhja1F45S93zqevbCfi180Vv65zIsKU49 X-Received: by 2002:a17:90b:2642:b0:219:feaf:6136 with SMTP id pa2-20020a17090b264200b00219feaf6136mr23659380pjb.28.1671009897203; Wed, 14 Dec 2022 01:24:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671009897; cv=none; d=google.com; s=arc-20160816; b=i6dZuD5ua36GUz8D7f/To0f0s/oPc7L1j0vEw7megzyXXLhdMI0wVpjvbozTpC+jtA +fgPVh5q2mTWOOo0aJj2rNlEsYTOmiSj6iFfxJf5Q+WY9CFavimZH2zIt6WTg4rejOkl qdR/jORUtjmHWjOEXTLoi+JUEwOT7qqiHaUsP3PVnM7Tn9GO3w1oi/tD/WQH8ZMVMHbU ZUwVKsga721iph5dgbyqxMME/JGxc0MJ08HW1TewnULUHAyJ+qJ0Fv9wZtTJiei8KhfC ygFJ4tvWH+vkhrvTOJ+PEjWTsh14ezVHtjrAzLBVelPb0L+KG4ME0FZ9AMKLazkL7/B1 hNzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=jPHDWuuN+f8j/XkoUM0a78gYpCLIDVY8mKI9IxY6CH0=; b=C6ovbxRLvwSAl2e1mT7PVrdspIycejE6+jHKtSYwVIN9k5jD/CpjfMNMftDVoroM5q 6SbxjY9KEyD0OZBUeFksdESk6BYHBsOCQCc7C+qmcWALGCsGJo4pGVG5qpEsdJd0Rny7 b2EAodcaB1xAVXf0q5+aINSTAhwmK8NGEoLJ0Dok067zq0LqeKoW22X+F/lYhbD5me3l MsuA2C4SmEbq27lxaFy9UslgN/3uX5utjGbwmy8PIwg1LkG+zBe3FSwMO2QHaC1sz0lK ZNz6inn5ZtKVKIr/3VSyvjBQ7jgsG1P5GRtg9B4mAwGHQ+rwTk6dBIANFjo6z9QyXhI2 c/hA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VDQAMJMH; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::f30 as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com. [2607:f8b0:4864:20::f30]) by gmr-mx.google.com with ESMTPS id mm21-20020a17090b359500b002195ef471f7si116586pjb.1.2022.12.14.01.24.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Dec 2022 01:24:57 -0800 (PST) Received-SPF: pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::f30 as permitted sender) client-ip=2607:f8b0:4864:20::f30; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VDQAMJMH; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::f30 as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-qv1-xf30.google.com with SMTP id h10so12158992qvq.7 for ; Wed, 14 Dec 2022 01:24:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jPHDWuuN+f8j/XkoUM0a78gYpCLIDVY8mKI9IxY6CH0=; b=VDQAMJMHNsimDkuZBOivWcCQYQVdgEDa/3WXUbIEidpIY2jvHKbuR/JAbzwJqBGF5h vCe1vNFRQI7SNIChkZJyK5ibynOPfGZRV7Pp/9TCS7lND/Zl5sVocTGaHYfOKIeMpQMi 0LWGbM2DqV+/5gXdGhEvbfgviQZTFNTYchrHNdFfLfKGhT4BidPufRiSvxcKPAGBhjXb 8An3qEaGfU6KX17w0A8kuN8+tbo9L8ANuqldd7/fbAq+u1sSgNaGjemtMy/yfBXW49Oi LmC+nfC4b2SOo0tjhpAXdI8AksXRRyg5NDihOrB52kyulK6V28FijDLSyo1DWIMeI5Gf Sgfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jPHDWuuN+f8j/XkoUM0a78gYpCLIDVY8mKI9IxY6CH0=; b=wsUM5i2eZh2qAvtrsBzlj0pJHGIqCY/y93wrMabstj+K1PX1AzBBTgB2J+eH+IG2BX Je2JPpTIM/okgjH4lW7bBsIS0E9lDQYfOo/yBH50XBN+dGz16znEFElomBFn0I0Ci4lP PFlKWBghsJA6pPdujU2HCShzJnwEDoor34RS+ytjzZmkdP3Z5ZJcicQ/D3wPt7zpZLa3 34nVT5yr1tNk2KvwIwbA4vORsxaM+gJJSuGVd7YlBQOy0E+dI6PNq5AHRE0U4Frks2o1 cpUg66OsFGw3QxFZturDKOycjON/I71UJLlHsauv2+r/sBBL99FnDvNo7wPVEy4ENIla aAUw== X-Gm-Message-State: ANoB5pnYyDRknJO/BeEKKYJNM73DfuzMdFLzOiu6NXUBmVNnadVFOWyJ 83NatiH/KOAIYlkoTwAfht6CkdnjwQvZNtHZW/r2y+nPiQ== X-Received: by 2002:a05:6214:2f88:b0:4c6:fc69:8220 with SMTP id ob8-20020a0562142f8800b004c6fc698220mr45596160qvb.72.1671009896308; Wed, 14 Dec 2022 01:24:56 -0800 (PST) MIME-Version: 1.0 References: <20221214094707.006cf073@md1za8fc.ad001.siemens.net> <20221214100528.0386e83b@md1za8fc.ad001.siemens.net> In-Reply-To: <20221214100528.0386e83b@md1za8fc.ad001.siemens.net> From: "Roberto A. Foglietta" Date: Wed, 14 Dec 2022 10:24:19 +0100 Message-ID: Subject: Re: [PATCH v2] If expand last partition fails, unsupervised systems reboot To: Henning Schild Cc: isar-users@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-TUID: tnicjiPUi3IQ On Wed, 14 Dec 2022 at 10:05, Henning Schild wrote: > > Am Wed, 14 Dec 2022 09:47:07 +0100 > schrieb Henning Schild : > > > Patch can not be reviewed so i can as well top-post. > > > > We should maybe separate the discussion with the reboot trap and the > > unsupervised file from the "aligning the nothing to do exit code to 0" > > I think it might also be a good idea to set > > ExecStopPost=-/bin/systemctl disable expand-on-first-boot.service > > in addition to ExecStartPost doing the same. So no matter if we succeed > or not, we only give it one try. But i did not test that. if it fails, it is a good thing to retry the next time. Some issues might depend on boot timing which might be variable. if you want to test what happens put a "false" as first instruction after set -e and you will see. In any case the script should be written to be able to cope with a different behaviour of the systemd between failure and success because tomorrow we can change that. (reasonable generalisation). By the way my patch does not only change the exit 1 with exit 0 but set a trap on exit to reboot the unsupervised systems to go working in production without the planned filesystem resize = underprovided = nasty failures at future unpredictable time. It is easy to revise a patch that is just a text file attached to an e-mail... LOL Best, R-