Re: [PATCH v2 01/10] fix rebuild of rootfs_finalize task

["Roberto A. Foglietta" <roberto.foglietta@gmail.com>]

On Sat, 14 Jan 2023 at 23:16, Roberto A. Foglietta
<roberto.foglietta@gmail.com> wrote:
>
> On Sat, 14 Jan 2023 at 21:48, Uladzimir Bely <ubely@ilbers.de> wrote:
> >
> > In the email from Thursday, 12 January 2023 08:56:10 +03 user Felix Moessbauer
> > wrote:
> > > [PATCH v2 01/10] fix rebuild of rootfs_finalize task
> >
> > Again, we had 4 different solutions for this (as single patches)

Now, 5! LOL

v5-0001-image-make-sure-do_rootfs_finalize-can-run-multip.patch

> >
> > Felix: [PATCH] fix rebuild of rootfs_finalize task
> > Roberto: [PATCH v4] image: make sure do_rootfs_finalize can run multiple
> > times, v4
>
> Hi Felix,
>
> if you do not like to reorganize the code above you can just use -f
> like in my patch
>
> +        mv -f "${aptdir}/sources-list" \
> +            "${aptdir}/sources.list.d/bootstrap.list" 2>/dev/null || :
>

We can also use change directory for re-organise the code above the fix

+        cd "${ROOTFSDIR}/etc/apt"
+        rm -f "apt.conf.d/50isar"
+        rm -f "preferences.d/isar-apt"
+        rm -f "sources.list.d/isar-apt.list"
+        rm -f "sources.list.d/base-apt.list"
+        mv -f "sources-list" "sources.list.d/bootstrap.list" 2>/dev/null ||:
+        cd -

cd - is not necessary at the end of SUDO but in future those add code
might not notice that the working path is changed and got crazy or
broken, so it is nice to have.

Best