From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
To: "Bezdeka, Florian" <florian.bezdeka@siemens.com>
Cc: "Schmidl, Tobias" <tobiasschmidl@siemens.com>,
isar-users@googlegroups.com, Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH 1/1] expand last partition supports btrfs (inline test)
Date: Fri, 30 Sep 2022 13:09:05 +0200 [thread overview]
Message-ID: <CAJGKYO61sMuQie9fJ8W76+L2kD2vQ7Yzkiwc_bvBczxegdr-VA@mail.gmail.com> (raw)
In-Reply-To: <3c13095fd15b6077e9b13b518ea7f25778a7c427.camel@siemens.com>
[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]
Il Ven 30 Set 2022, 12:50 Bezdeka, Florian <florian.bezdeka@siemens.com> ha
scritto:
> On Fri, 2022-09-30 at 12:39 +0200, Roberto A. Foglietta wrote:
>
> >
> > as you can see my approach is straight simple: if extending the ext4
> > fails because it does not match the filesystem type then try with
> > btrfs tool. Obviously, the btrfs tool is added as dependencies among
> > others before defined.
>
> First: resize2fs does not only support ext4. It supports all of the ext
> variants (ext2-ext4) to my understanding.
>
The man resize2fs said so: ext2/3/4.
Due to the implementation of ext4 and ext2 with the backcompatibility of
some features, the resize supported in ext4 is also supported in ext2
because it is a basic feature. Viceversa, a tool that resize ext2 will fail
to resize ext4 much probably because the journal.
Second: There might be more reasons why resize2fs could fail. IMHO, it
> doesn't make sense to run a btrfs tool on a ext filesystem that failed
> to expand.
>
It is not elegant but it does not hurt to run btrfs on ext4 or resize2fs on
btrfs.
Yes, I am a raw penguin! LOL
Third: The mount point (/tmp/btrfs) is never cleaned up in the Robertos
> patch.
>
I do umount but NOT rmdir because if for some reason umount fails
(expecially in combination with a bug that do not let the error code be
returned, I saw in busybox) I am going to remove the filesystem content.
Moreover, polluting the /tmp is usually not an issue.
Thanks for your feedbacks, R.
[-- Attachment #2: Type: text/html, Size: 2497 bytes --]
next prev parent reply other threads:[~2022-09-30 11:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 8:00 Roberto A. Foglietta
2022-09-30 8:56 ` Jan Kiszka
2022-09-30 10:23 ` Schmidl, Tobias
2022-09-30 10:39 ` Roberto A. Foglietta
2022-09-30 10:50 ` Bezdeka, Florian
2022-09-30 11:09 ` Roberto A. Foglietta [this message]
2022-09-30 11:17 ` Roberto A. Foglietta
2022-09-30 10:51 ` Henning Schild
2022-09-30 11:34 ` Fwd: [PATCH 1/1] expand last partition supports btrfs (inline 2nd version) Roberto A. Foglietta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJGKYO61sMuQie9fJ8W76+L2kD2vQ7Yzkiwc_bvBczxegdr-VA@mail.gmail.com \
--to=roberto.foglietta@gmail.com \
--cc=florian.bezdeka@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
--cc=tobiasschmidl@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox