From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
To: Florian Bezdeka <florian.bezdeka@siemens.com>
Cc: roberto.foglietta@linuxteam.org, isar-users@googlegroups.com
Subject: Re: [PATCH v6] suggested changes for reproducibility patchset v6
Date: Tue, 17 Jan 2023 14:10:38 +0100 [thread overview]
Message-ID: <CAJGKYO690kt332S4GcdvAuuONh_0Fp-0a1fJ4yyGHPoRgBHuRQ@mail.gmail.com> (raw)
In-Reply-To: <27337f043bddfad8dbc2c166fe1932ed45398c47.camel@siemens.com>
On Tue, 17 Jan 2023 at 12:53, Florian Bezdeka
<florian.bezdeka@siemens.com> wrote:
>
> On Sun, 2023-01-15 at 23:46 +0100, Roberto A. Foglietta wrote:
> > On Sun, 15 Jan 2023 at 23:32, Florian Bezdeka
> > <florian.bezdeka@siemens.com> wrote:
> > > > Signed-off-by: Roberto A. Foglietta <roberto.foglietta@gmail.com>
> > > > ---
> > >
> > > Comments like changes between versions of your patches should be
> > > mentioned here. Not inside the commit message.
> > >
> >
> > Ok, it seems weird to me but it probably is a standard that automatic
> > software needs. Is that right?
>
> This is how "git am" works. Everything above the "---" line will go
> into the commit message (should be used for story telling), everything
> below that line and in front of the first hunk will be thrown away and
> can be used for further comments/hints for reviewers/maintainers.
>
So, considering that I want to maintain the version revision of the
patch along with the commits, it makes perfect sense that I put them
in the description. After all, the description content is arbitrary to
some degrees. However, I can add the revision log also below the
signature in such a way that some other tools that expect to find,
they will find it. Does this sound good to you?
Best regards, R.
next prev parent reply other threads:[~2023-01-17 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 21:53 roberto.foglietta
2023-01-15 22:01 ` Roberto A. Foglietta
2023-01-15 22:31 ` Florian Bezdeka
2023-01-15 22:46 ` Roberto A. Foglietta
2023-01-17 11:53 ` Florian Bezdeka
2023-01-17 13:10 ` Roberto A. Foglietta [this message]
2023-01-25 16:38 ` Roberto A. Foglietta
2023-01-16 2:55 ` Moessbauer, Felix
2023-01-16 9:36 ` Roberto A. Foglietta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJGKYO690kt332S4GcdvAuuONh_0Fp-0a1fJ4yyGHPoRgBHuRQ@mail.gmail.com \
--to=roberto.foglietta@gmail.com \
--cc=florian.bezdeka@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=roberto.foglietta@linuxteam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox