Re: [PATCH v2 4/4] events: Cleanup lost schroot sessions if any

["Roberto A. Foglietta" <roberto.foglietta@gmail.com>]

On Tue, 3 Jan 2023 at 10:55, Roberto A. Foglietta
<roberto.foglietta@gmail.com> wrote:
>
> On Fri, 30 Dec 2022 at 20:08, Anton Mikanovich <amikan@ilbers.de> wrote:
> >
> > In case the user will only open imager schroot session but not close it
> > we need to find and clean it up.
>
> Hi Anton,
>
>  this patchset works for me but it missing a 5th patch to free dpkg
> base class from buildchroot, here in attachment.
>  The patch has been also sent by elastic mail SMTP and it went in
> moderation as usual.

Hi Anton,

I have identified an unexpected behaviour - for me an improvement but
technically speaking a regression - after having applied your patchset
about schroot migration.

Try this:

git clone https://github.com/robang74/isar-nvidia-debian.git
cd isar-nvidia-debian
put c9f4b21 in kas:

These patches are useful/necessary to let my project building:

* c9f4b21 - image tools ext. class defines ISAR_CROSS_COMPILE, if
missing  (HEAD)
* c945877 - dpkg class set default value for ISAR_CROSS_COMPILE, if missing
* adafe11 - dpkg class sbuild allows extra arguments by vars

This is my patch to migrate the dpkg base class to schroot:

* 423c2f3 - dpkg base class: use schroot only not buildchroot anymore

These are your patches for schroot migration:

* e2d2165 - events: Cleanup lost schroot sessions if any, v2
* 3fb634e - imager: Move image types to schroot, v2
* 51b08db - imager: Migrate from buildchroot to schroot, v2
* 0fea6b1 - sbuild: Allow setting custom config paths, v2

Then do:

source .profile
clean all
build basic-os
build

The second build should do nothing. Instead, it builds the wic image
again starting from image deps: 'do_install_imager_deps'. In my
opinion this is a feature because when I use 'wicshell' and I chroot
into the image to modify it, sometimes I break things and I want to be
back to the original. This allows me to avoid cleaning the build and
restart it again which takes a lot of time compared to starting again
from image deps. However, from a technical point of view it is a bug.

I hope this helps, R-