On Tue, 6 Dec 2022 at 14:30, Anton Mikanovich wrote: > > This changes are ok, but the patch itself is formatted quite badly. > the patch has been formatted by git format-patch > There is no need in mention fixed hash (87d31ee) in commit title. > On the other hard, mentioning of fixed hash in commit message should be > informative to note how it is connected to the current patch, like: > > Fixes: 87d31ee ("add interface to passthrough env vars to sbuild") ok, resending in attachment > > And once again: please submit patchsets with 'git send-mail'. This will > reduce > manual work during review and applying, and also will allow Patchwork to > generate correct applicable records. > I sent the patch with elastic mail and probably it went into the spam folder. As explained in this list in the past, Google does not allow anymore to use their smtp via git. Thus, I am using smtp.elasticmail.com but usually the e-mail that I send via that smtp do not arrive in the list but they end up in moderation. So, as far as possible, I did. Please check the following thread about: https://groups.google.com/g/isar-users/c/xC6-QImeLzc/m/1HATZVvVAgAJ Best regards, R-