Re: [PATCH v3] deb-dl-dir class rework to use faster ln -P or fallback to cp

["Roberto A. Foglietta" <roberto.foglietta@gmail.com>]

On Fri, 10 Feb 2023 at 11:07, Uladzimir Bely <ubely@ilbers.de> wrote:

> >
> >  deb_dl_dir_import() {
> >      export pc="${DEBDIR}/${2}"
> > -    export rootfs="${1}"
> > -    sudo mkdir -p "${rootfs}"/var/cache/apt/archives/
> > +    export sc="${1}/var/cache/apt/archives/"
> > +    sudo mkdir -p "${sc}"
> >      [ ! -d "${pc}" ] && return 0
> > -    flock -s "${pc}".lock -c '
> > +    export tf=$(ls -1 "${pc}"/*.deb | head -n1)
> > +    [ ! -e "${tf}" ] && return 0
> > +    flock -Fs "${pc}".lock sudo -Es << 'EOFSUDO'
> >          set -e
> >          printenv | grep -q BB_VERBOSE_LOGS && set -x
> >
> > -        sudo find "${pc}" -type f -iname "*\.deb" -exec \
> > -            ln -Pf -t "${rootfs}"/var/cache/apt/archives/ {} +
> > -    '
> > +        rm -f "${sc}/"$(basename "${tf}")
> > +        ln -Pf -t "${sc}" "${tf}" 2>/dev/null ||:
> > +        if [ -r "${tf}" ]; then

Because we need to check the destination, not the source.

if exists $sc/$(basename $tf) then

>
> I was almost ready to merge it since it passes CI (positive case), but
> patchset appeared don't work (negative case) on different filesystems - I find
> downloads/deb/*/ empty after build. At least, exports don't work.

Both do not work correctly. I am going to fix it. Sorry, R-