From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7197029299818332160 X-Received: by 2002:a05:6870:9627:b0:163:9c1a:3d4c with SMTP id d39-20020a056870962700b001639c1a3d4cmr1522609oaq.221.1676026278813; Fri, 10 Feb 2023 02:51:18 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a9d:6c06:0:b0:68d:b7eb:4712 with SMTP id f6-20020a9d6c06000000b0068db7eb4712ls731960otq.8.-pod-prod-gmail; Fri, 10 Feb 2023 02:51:18 -0800 (PST) X-Google-Smtp-Source: AK7set/3U1/5p/D1E81h8GquoKtkMzpdgQgHl/bvZ04EJuXBqEJzRWk+1dgs548FqhV7eRqNoJ/4 X-Received: by 2002:a05:6830:2a08:b0:68b:ba9b:5ac5 with SMTP id y8-20020a0568302a0800b0068bba9b5ac5mr9535899otu.18.1676026278068; Fri, 10 Feb 2023 02:51:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676026278; cv=none; d=google.com; s=arc-20160816; b=nbw8B1D5KMlhQSd20a9gLQRxHbN09vRi3y3p2I78svhGDGg/xEzvg0KnA3mtT/YHRN uz+FU+oRkeIk09vJ95FASQHLFhZOCOGd7bepbcM6MVS1fF3+1GyUFoUOaU6wZ7jQzppb PN1qNgeGfxaY+YNHl/IsAaqN/7J+GyYNSSYNLSEUpP3MJqNEw/O19kPfZtvpdUHWY5NI 9BwBwwgYbIuh6qpmFveKjSxV9w5I3duWgveB/ap/ZPEeLFsUAmLhrWpPb6MkIzRLq42m oyYetDNLbNFKlqLeGD+ugBkGy19X4MI6cXoyJixz8dfLnWcCyQlTyltbs6pMCa2tqT6J 01hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=x8ZpDkU51YEjU1SeZgxKqEvAGYqkK1iEXDtFtnfyWD0=; b=dDCLP5lntUbWWyzyK3TUD7p7xp4vWKurWb1o8N0wH5w1k1bXQkNRLq9q9lLrhdQAGw 0eFcJU6EvKtXUKsWHu4QXUtkAwjt4+b3rEceRs93NLP3JaAK2NfXw7Pmm8nuuHrKcXh7 c48lmx+QeiCt7ISqPeg9Nz8cWBcxKqBiA1SpsCvxqj3IKwCGmRyquH3tKgeK6oVxBFZQ el5irFibGWJ9kUMAKPZo9EGyoP+50g4gzBvdlWAlPAXdR9VyKvM6z/XMDy033bzxYCgG m1r54z4u0v7nmHRRmQ5tgs35CFONllle/yy1QWywAUPs4AyYnaNgYHoXEma2jYlw6CkP jVmg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=TuGb60GA; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::72f as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com. [2607:f8b0:4864:20::72f]) by gmr-mx.google.com with ESMTPS id bd1-20020a056808220100b00378599bee7dsi327846oib.2.2023.02.10.02.51.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Feb 2023 02:51:18 -0800 (PST) Received-SPF: pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::72f as permitted sender) client-ip=2607:f8b0:4864:20::72f; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=TuGb60GA; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::72f as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-qk1-x72f.google.com with SMTP id 135so1996945qkh.13 for ; Fri, 10 Feb 2023 02:51:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=x8ZpDkU51YEjU1SeZgxKqEvAGYqkK1iEXDtFtnfyWD0=; b=TuGb60GAh9WfV/RSW5xVr2xEdq3xUA7UHxlVCZhKehY4sdN3birkCk8waheKF0GKob Tw6cWTLpfXKUk5eQBaPLFZe4BS2W0Kq98594tdQ3FlRWA/tywZ+kZC2o3xQgeMF0Hmgs 8o2rNWVd4k98VsiIffANFp1a1p7+kvWMuOmwzIeXDsZQ5ih+KlIVx7B4Xx3PGthitAyD 4/77F2X/8BDI39KFtI9V4Fz8C2XZLu+4fB0pcZ4b/+ePTQwBcjrofJwoRAacT5TCZExO Moz5VFlNsUpZXcV+6sZATHRKsGCrlsvKPU6WVoZJo79hTWUCqicYhk1yXkSdCHsriCa+ peNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x8ZpDkU51YEjU1SeZgxKqEvAGYqkK1iEXDtFtnfyWD0=; b=tqBqN4jWYxEl3a5YtWrd/+QI7bqv13zi9XKzzMgUttgm2sRk1K4DdnO3Nk5/A8vQDU F9Udslfd+BpxYI8T3kbnUyXdgaBB4dzRkvWJw2spcf0qzkP/TQgPr9gbkTpugU2OK87u NY0JiUm2Q2SMK19fdrnNdXT3V+oPbYUuhNiGKHgt5adBSmNbwYEfoWPd+xu174tmwI4+ vY+ezaTr1Iygm5tyBFdRYJQMtPB+x61cBh2iRqFOWMnkfBhZ/rGoYkG3dhQXDiNg/a7i s0DgYzLYn7hs0ybBDBHmXwB5kfifZNh9+VhoPDBFGGPzx7tAoWzefjZL+JAYw317otDp EojA== X-Gm-Message-State: AO0yUKXOV1uhRTSPtsEm95lB7BkxU2/FZdwCtmtsCjkCS2FOyMPuvjDc 3YHB4Tdo+IgtP/+4oSrLHl9vcQUR+A8K6OIABXmWsVAVig== X-Received: by 2002:a37:b644:0:b0:706:6b11:8224 with SMTP id g65-20020a37b644000000b007066b118224mr604542qkf.197.1676026277712; Fri, 10 Feb 2023 02:51:17 -0800 (PST) MIME-Version: 1.0 References: <20230207075222.390954-1-roberto.foglietta@linuxteam.org> <15525925.Emhk5qWAgF@home> In-Reply-To: <15525925.Emhk5qWAgF@home> From: "Roberto A. Foglietta" Date: Fri, 10 Feb 2023 11:50:40 +0100 Message-ID: Subject: Re: [PATCH v3] deb-dl-dir class rework to use faster ln -P or fallback to cp To: Uladzimir Bely Cc: isar-users@googlegroups.com, roberto.foglietta@linuxteam.org Content-Type: text/plain; charset="UTF-8" X-TUID: TJmd25CEU8k8 On Fri, 10 Feb 2023 at 11:07, Uladzimir Bely wrote: > > > > deb_dl_dir_import() { > > export pc="${DEBDIR}/${2}" > > - export rootfs="${1}" > > - sudo mkdir -p "${rootfs}"/var/cache/apt/archives/ > > + export sc="${1}/var/cache/apt/archives/" > > + sudo mkdir -p "${sc}" > > [ ! -d "${pc}" ] && return 0 > > - flock -s "${pc}".lock -c ' > > + export tf=$(ls -1 "${pc}"/*.deb | head -n1) > > + [ ! -e "${tf}" ] && return 0 > > + flock -Fs "${pc}".lock sudo -Es << 'EOFSUDO' > > set -e > > printenv | grep -q BB_VERBOSE_LOGS && set -x > > > > - sudo find "${pc}" -type f -iname "*\.deb" -exec \ > > - ln -Pf -t "${rootfs}"/var/cache/apt/archives/ {} + > > - ' > > + rm -f "${sc}/"$(basename "${tf}") > > + ln -Pf -t "${sc}" "${tf}" 2>/dev/null ||: > > + if [ -r "${tf}" ]; then Because we need to check the destination, not the source. if exists $sc/$(basename $tf) then > > I was almost ready to merge it since it passes CI (positive case), but > patchset appeared don't work (negative case) on different filesystems - I find > downloads/deb/*/ empty after build. At least, exports don't work. Both do not work correctly. I am going to fix it. Sorry, R-