public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: isar-users@googlegroups.com
Subject: Re: [PATCH v2] rootfs class lock undefined in corner cases fix
Date: Thu, 5 Jan 2023 18:32:41 +0100	[thread overview]
Message-ID: <CAJGKYO6WfQDMxo5v6aBP2XY7yxrRPSZWZc_-Rpr4BSoOM52+LA@mail.gmail.com> (raw)
In-Reply-To: <b4f6b5cf-af9d-e60c-c2ee-8660405ce323@siemens.com>

On Thu, 5 Jan 2023 at 08:18, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>
> On 04.01.23 20:46, roberto.foglietta@gmail.com wrote:

>
> I thinks you didn't understand the logic yet when you are proposing such
> a change and you are rather papering over a downstream issue: missing
> "acquire-before" in a commend chain that later on has a "release-after".
>

I did not care about the logic / timing of the actions. I simply
notice that there is a corner case in which that variable is undefined
but tried to be used. This is a fact despite the reason because it
happens and IMHO should be fixed in the simplest way possible at
coding level before being fixed the cause at logic level. A more
elegant coding would be:

if 'lock' in locals():
    bb.utils.unlockfile(lock)

without any other changes.

Thanks for the feedback, R-

      reply	other threads:[~2023-01-05 17:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 19:46 roberto.foglietta
2023-01-04 20:31 ` Henning Schild
2023-01-05  7:18 ` Jan Kiszka
2023-01-05 17:32   ` Roberto A. Foglietta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJGKYO6WfQDMxo5v6aBP2XY7yxrRPSZWZc_-Rpr4BSoOM52+LA@mail.gmail.com \
    --to=roberto.foglietta@gmail.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox