From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7184872845710721024 X-Received: by 2002:a92:cacc:0:b0:30b:e29a:42c5 with SMTP id m12-20020a92cacc000000b0030be29a42c5mr4697656ilq.1.1672939997792; Thu, 05 Jan 2023 09:33:17 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6e02:ef0:b0:30c:1c4b:e185 with SMTP id j16-20020a056e020ef000b0030c1c4be185ls4624699ilk.11.-pod-prod-gmail; Thu, 05 Jan 2023 09:33:17 -0800 (PST) X-Google-Smtp-Source: AMrXdXvaF7G5i7JReg1C0Qsn/cjEGbY3hpULpVjHh9tg54vJjgpTFuO4NHp0v3gKHpxhleZiU0TT X-Received: by 2002:a05:6e02:10d3:b0:30d:7cf4:5d5d with SMTP id s19-20020a056e0210d300b0030d7cf45d5dmr1974312ilj.22.1672939997352; Thu, 05 Jan 2023 09:33:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672939997; cv=none; d=google.com; s=arc-20160816; b=m2e1+TsMq+ruo2I1A5fj1yp0a53EiI4ZOU5SE9WXJCBO3QEEroTpkKEJtcFo8qCa4F xwi74wXVlKfT79D71bbNbR482oOssATtvcV8uMcQY4XdbN0zIm1gBDj8eujIfNn9Yo0B ryvZBNeutVUhQh1OWv3e8ZPeWgQyfF6Fcgvrizdzu0TyHFvp6YQA/YctWmAHFs5lYg4Z Q7fph6YxS12fizK8hKoMOLHMukoy5Xh+TB1yDQgY6l3NRM6byiQ5twwmMTqlnochZWw6 uy3KpdgqJVT6toINgETTuL+Ml1NINYkoYokU0W7OpaTcrLU5S5p7LoxkaKKgUZPoJSHr pNYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=5MXE+QItXQsTJrGn+gUKdA/ZO10VwTq+zjNyvx33/B0=; b=KM9tNLQSP/9YdzXfIdCbsQHg4rc0DDHBnIpV4Kzyy1LW9fGDmGGctBOcEbfR6mmvan WVKjDX8sN9/ff3NQ8CumkoXrUtMrIIU+P5SvQJ/DU9jZpCMKjfDGR0betAk8TRLiO+nT fbpM9uy64J5Xn2h6v9qxQ9ZIFepv15uWth+aatTiLZLPb4jH7C4BeyNlmyscbVEI9dz+ c4K7UlH326S58Q2w/csGiH3yl0ijgKbveGIvppqjegHShgxehMHBmYrXef1UZXfKkztO s0gxUiMgPXQui1Co09yWy0Z5GQH7vRZm9SAp+MTtbt0I1Gc3S01RdaUdnjDoRzbNPw4L /MvQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=eJw5c+1U; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::82e as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com. [2607:f8b0:4864:20::82e]) by gmr-mx.google.com with ESMTPS id cu11-20020a05663848cb00b0038a27d5a3d8si2439570jab.3.2023.01.05.09.33.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jan 2023 09:33:17 -0800 (PST) Received-SPF: pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::82e as permitted sender) client-ip=2607:f8b0:4864:20::82e; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=eJw5c+1U; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::82e as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-qt1-x82e.google.com with SMTP id i20so30459381qtw.9 for ; Thu, 05 Jan 2023 09:33:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5MXE+QItXQsTJrGn+gUKdA/ZO10VwTq+zjNyvx33/B0=; b=eJw5c+1UEIbG4PzGnilsqbJAXthbHZrh0w2CPTlObsVZW4u2vBdHxpAjxvX+fIH8kV MrJERnWJEsK8WO3xHnNfpDVyQGXYTvBrifcOb3sGNxaTuoBeYyg6jkBqu+6PrwyEuFgx 5tjF5EN8NLuJct5KdJW/Q41RYwXM7EB5H1GW1loGcIvB5ALnxbDEeOjl90yK7V7KhCNe XX1eMgjUNIX8LoiqQao8o3hiCtoU8WNMwH19OO2XgdtWICbiKN3XXJLMZkqMamz55D5g kxIN94q92z72mUqMI9ay0UFIkGwv58moV4qI6xOQceh1qrOK23LsmOnuB+JGQZP91OfV atFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5MXE+QItXQsTJrGn+gUKdA/ZO10VwTq+zjNyvx33/B0=; b=hwDFlFjfM7n61BkufGOPHTmOz+PLwZ6mYOqv62Fek2Ev0ZcKHCNxiJzSpo+9rnRxV3 qUrwcr1SuiJJLHrNSOyP/Ohq5uZT1U7c66OXo+M9xxbY32z0xdSmZFow2erDyQ2FTuET Q6DEDqBHwA0S29vMrJllYJDlgpfcqldPZ34pvb7zqXboMtzd/+NYaQza9l0LNRXpX7LB Ve7n7BoUM16bCWKhh2L/IYU/ePoti9nCM4NijVaWRWoTYVbwVn1Zle+q+jY1prorKi9T e49i06JrMTvhgvxKk4TvquVcFHWildPohckS/WxoljrTxWb0E/8bbeF6v4L4SRetXXXp kBWg== X-Gm-Message-State: AFqh2krsGBP0SKvRvBZLoPOI9zf9XtVNaHBgo8OSxHgoDz1OiFOiOFKQ kynNHQAa8HsswpYPZ9RwouSq+Fzm5PX5d15DY7IzRXxTSA== X-Received: by 2002:a05:622a:601f:b0:3a7:f283:43cc with SMTP id he31-20020a05622a601f00b003a7f28343ccmr2315072qtb.467.1672939996983; Thu, 05 Jan 2023 09:33:16 -0800 (PST) MIME-Version: 1.0 References: <20230104194646.2545099-1-roberto.foglietta@gmail.com> In-Reply-To: From: "Roberto A. Foglietta" Date: Thu, 5 Jan 2023 18:32:41 +0100 Message-ID: Subject: Re: [PATCH v2] rootfs class lock undefined in corner cases fix To: Jan Kiszka Cc: isar-users@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-TUID: U+JXpBUcn7e6 On Thu, 5 Jan 2023 at 08:18, Jan Kiszka wrote: > > On 04.01.23 20:46, roberto.foglietta@gmail.com wrote: > > I thinks you didn't understand the logic yet when you are proposing such > a change and you are rather papering over a downstream issue: missing > "acquire-before" in a commend chain that later on has a "release-after". > I did not care about the logic / timing of the actions. I simply notice that there is a corner case in which that variable is undefined but tried to be used. This is a fact despite the reason because it happens and IMHO should be fixed in the simplest way possible at coding level before being fixed the cause at logic level. A more elegant coding would be: if 'lock' in locals(): bb.utils.unlockfile(lock) without any other changes. Thanks for the feedback, R-