From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
To: Anton Mikanovich <amikan@ilbers.de>
Cc: isar-users@googlegroups.com
Subject: Re: [PATCH 1/1] aesthetic changes in module.inc
Date: Fri, 23 Sep 2022 17:04:19 +0200 [thread overview]
Message-ID: <CAJGKYO6Z7XX_FJnZohYOCmRKbD=Nt-82eQbFGnO0o41T6Ao4-g@mail.gmail.com> (raw)
In-Reply-To: <c54ef3a7-0e42-7370-7f67-b45ef3e61ff0@ilbers.de>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
Il Ven 23 Set 2022, 15:36 Anton Mikanovich <amikan@ilbers.de> ha scritto:
> 18.09.2022 23:54, Roberto A. Foglietta wrote:
>
> Hi all,
>
> nothing else than an aesthetic changes in module.inc
>
> Cheers, R-
>
> Hello Roberto,
>
> Despite the fact that both versions work, the original one looks more
> readable.
> There is no need in complicating git blame history for such a cosmetic
> change.
> This one rejected.
>
Just an aesthetic consideration: original script open and close a file
descriptor each time it does a for cicle. My suggestion, open and close a
single time the that file descriptor.
Aesthetic, unless you have to go to the moon but then no bash/shell for
sure. 😊
Cheers, R-
>
[-- Attachment #2: Type: text/html, Size: 1762 bytes --]
prev parent reply other threads:[~2022-09-23 15:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-18 20:54 Roberto A. Foglietta
2022-09-23 13:36 ` Anton Mikanovich
2022-09-23 14:19 ` Roberto A. Foglietta
2022-09-23 15:04 ` Roberto A. Foglietta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJGKYO6Z7XX_FJnZohYOCmRKbD=Nt-82eQbFGnO0o41T6Ao4-g@mail.gmail.com' \
--to=roberto.foglietta@gmail.com \
--cc=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox