From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7144826409887727616 X-Received: by 2002:a05:6e02:b47:b0:2f6:4a8e:3656 with SMTP id f7-20020a056e020b4700b002f64a8e3656mr4187935ilu.48.1663945472408; Fri, 23 Sep 2022 08:04:32 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a02:a10e:0:b0:35a:328c:6cc0 with SMTP id f14-20020a02a10e000000b0035a328c6cc0ls3678366jag.2.-pod-prod-gmail; Fri, 23 Sep 2022 08:04:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4J51Z9BzrV3OzWrGx35tMT9kVrBDzOEqlDAokdEag9jj/xZD3jhsE6hfjRwfspIeW8icHP X-Received: by 2002:a05:6638:1a1b:b0:35a:ce31:2e2b with SMTP id cd27-20020a0566381a1b00b0035ace312e2bmr4912402jab.289.1663945471918; Fri, 23 Sep 2022 08:04:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663945471; cv=none; d=google.com; s=arc-20160816; b=GG8bn2BlIhBlDVN0buKgOqmMSJ9G4VbSfpYlE4FQs2iNo8gL4sxDxZCiohR5VtjnBp xFYwEGowNvZPVsTL7Xd/kWr3Ti74gKB/9sIrnmkfklKnZSYfrk9KACcLnusWaooeLtQD 8uvJp0vhal29m9Obt5zfpVJIMRIxuirFQol7dOOZ5XjRkQT5fmt2BKSIQq4MHXjEJ83k xIXkLxE0oafqLXEYBvtdM9cFljmRnsMuOPPlyK34F8Id9bj3M1HOAT12Y09ZgCmceQFN uuAmhcb4pWUYZ32f0WzjWaHcOQa2VJWWDiB3et73YMn5HoggS9v2H7cvRQrVKGFJ77u7 5onw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=o8/Oiap/BxW77SapqYkoesd9BIrV9vC/J55lQ+W2+A4=; b=fckzUhASJfPlU2I7gKanr7n8kKTKDEmCQE/SyhYdeXzPjGB6UGiLI3oncXphA1VmiB 3ru9ZKKhMmvFpeERhuZNLrhP4Oa1ODuH3plMZvK4k0hpeDWQqocvBJkaHZDfUA1HEa2T DfCjGeYAF3ZG4FQnMjF1IJ+E2WpjYU6KuJCLi74O0+cURUJL5tGxoK6ZaWUg+aLUDgES h+m4a6MwgrF4cyrhbZQXc/7YrdScax7bOuuhDy8In6AcwaVN3zBTGMIRqnWsWeSVsx8y GyFI4+j1iHd9ArZUizPgiy0KBFfDUHehnOqe6U4/5T0J0B5rlGsPLaHhucGb+btj1lrq h6LA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YShHNtdE; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::d2b as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com. [2607:f8b0:4864:20::d2b]) by gmr-mx.google.com with ESMTPS id ay6-20020a5d9d86000000b006a128dbb6efsi447197iob.0.2022.09.23.08.04.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Sep 2022 08:04:31 -0700 (PDT) Received-SPF: pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::d2b as permitted sender) client-ip=2607:f8b0:4864:20::d2b; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YShHNtdE; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::d2b as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-io1-xd2b.google.com with SMTP id y141so136786iof.5 for ; Fri, 23 Sep 2022 08:04:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=o8/Oiap/BxW77SapqYkoesd9BIrV9vC/J55lQ+W2+A4=; b=YShHNtdEPG+J38IDGEq5Gwk7hhqrZiH6zL0K3LUUaorLwWvOI6+dQ0CSvNwf4suuVm MxpCPv2E0UxqV1IiMnUvymAKPsRpDTfa76R97jbd3pBuit2e5nEXtQw92ixFicGqYoQX YT4AldS2/4lobxYFLmBB7irJI1Qau/Lwhjxdw3u5RLq5a0TakYCAzJgQxIbTlOlRGbB6 sPJVAukjUccdPNjfWT7wNwCveHzF9SEKRcTUoDru2HyxnSeqDCqhkjLT51/xovLKIDXl 5ZjNKpzZp/t/3iWqRtPqtvVKQq8LOuZXn+osUOFgog++4M9SVmbeF6F/6MlGV2pQWxr3 RQrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=o8/Oiap/BxW77SapqYkoesd9BIrV9vC/J55lQ+W2+A4=; b=4g83Rx1BCUSqshwLFErP/uh4/1bkFLoc2bBvee2PxIBYNGK1G3rQ2a1yWyjwQt5K4N q7StFK2Be+lGj4u4NWGCsLCl4+NzWxUnaQ4rR6nbbqi0SBcK6SGyH1yOEnXobSgUaJ0t Vsjzj2IHf3u3r0GAmAvz2aYHg0YXIx7QlXzo2ubeO0S0hAqeBIDLBJXniNyk5OmE23ck 8MQ3m2ZJ08jC/JVit7PEoA/oo6Ynl9Jdr41cI20MUn+YCm6wZUk4L6jazmkmN9LQq9cI IZsyLp2vkVO1M6WeBmvxY0y/G6cq/AsPxQeZ+IscFpkMgYaXmAbdYkVmhdZOIIZGk5vG zrQw== X-Gm-Message-State: ACrzQf2mcQ9Kl+/7eKTxb13Ou9wVL6H923j5JyF1is2j9IjEGJ6ynGlW sTkYPLgJhZ79gdE6bvRFcR+6gGKTR2sY6qMIitjybzYElA== X-Received: by 2002:a05:6638:58b:b0:35a:dff8:7c5a with SMTP id a11-20020a056638058b00b0035adff87c5amr4741006jar.280.1663945471364; Fri, 23 Sep 2022 08:04:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Roberto A. Foglietta" Date: Fri, 23 Sep 2022 17:04:19 +0200 Message-ID: Subject: Re: [PATCH 1/1] aesthetic changes in module.inc To: Anton Mikanovich Cc: isar-users@googlegroups.com Content-Type: multipart/alternative; boundary="000000000000bf1f1105e9597e0f" X-TUID: IqLUA7jH2CGl --000000000000bf1f1105e9597e0f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Il Ven 23 Set 2022, 15:36 Anton Mikanovich ha scritto: > 18.09.2022 23:54, Roberto A. Foglietta wrote: > > Hi all, > > nothing else than an aesthetic changes in module.inc > > Cheers, R- > > Hello Roberto, > > Despite the fact that both versions work, the original one looks more > readable. > There is no need in complicating git blame history for such a cosmetic > change. > This one rejected. > Just an aesthetic consideration: original script open and close a file descriptor each time it does a for cicle. My suggestion, open and close a single time the that file descriptor. Aesthetic, unless you have to go to the moon but then no bash/shell for sure. =F0=9F=98=8A Cheers, R- > --000000000000bf1f1105e9597e0f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Il Ven 23 Set 2022, 15:36 Anton Mikanovich <amikan@ilbers.de> ha scritto:
=
=20 =20 =20
18.09.2022 23:54, Roberto A. Foglietta wrote:
=20
Hi all,

=C2=A0nothing else than an=C2=A0aesthetic changes in module.in= c

Cheers, R-

Hello Roberto,

Despite the fact that both versions work, the original one looks more readable.
There is no need in complicating git blame history for such a cosmetic change.
This one rejected.

<= /div>

Just an aesthetic consid= eration: original script open and close a file descriptor each time it does= a for cicle. My suggestion, open and close a single time the that file des= criptor.=C2=A0

Aesthetic= , unless you have to go to the moon but then no bash/shell for sure. =F0=9F= =98=8A

Cheers, R-
<= div class=3D"gmail_quote" dir=3D"auto">
=

--000000000000bf1f1105e9597e0f--