From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
To: Florian Bezdeka <florian.bezdeka@siemens.com>
Cc: roberto.foglietta@linuxteam.org, isar-users@googlegroups.com
Subject: Re: [PATCH v6] suggested changes for reproducibility patchset v6
Date: Sun, 15 Jan 2023 23:46:16 +0100 [thread overview]
Message-ID: <CAJGKYO6a-sn5tYcb+4kXvCGwxz2OsG6ScADPndAhy_q+BzcEuQ@mail.gmail.com> (raw)
In-Reply-To: <551831fb188675b0c6d1a879f1a8b251efce4e4a.camel@siemens.com>
[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]
On Sun, 15 Jan 2023 at 23:32, Florian Bezdeka <florian.bezdeka@siemens.com>
wrote:
>
> On Sun, 2023-01-15 at 22:53 +0100, roberto.foglietta@linuxteam.org
> wrote:
> > From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
> >
> > suggested changes for reproducibility patchset
> >
> > WARNING: eval-image-1.0-r0 do_rootfs_finalize: modified timestamp
(1673628837) of 3 files for image reproducibly
> > List of files modified could be found here:
./build/tmp/deploy/images/debx86/files.modified_timestamps
> >
>
> Can't follow. Patches / Commits need proper description (= commit
> message). I guess you fixed a warning, but the warning itself (= list
> of modified files) was inside the mentioned file, so we have to guess
> what changed?
>
Do not worry, I will do a proper patch when your changes will be included
into ilbers/next - this is just a suggestion for Felix
@Felix
There is no reason to show a warning of long N files but just a summary
with the name of the file to check.
Please forget the v6 because it got out prematurely. I just sent the v7.
Keep in consideration that in my building after the image
finalize, do_install_imager_deps runs and mess-up things.
It is something that I need to investigate.
> >
> > v.6: the 1st part of the warning shows up each time the epoch is used
> > while the 2nd line appears only when some files has been touched
> > This allows the user to know the current situation aboat epoch.
>
> Version information does not belong here. See below.
>
> >
> > Signed-off-by: Roberto A. Foglietta <roberto.foglietta@gmail.com>
> > ---
>
> Comments like changes between versions of your patches should be
> mentioned here. Not inside the commit message.
>
Ok, it seems weird to me but it probably is a standard that automatic
software needs. Is that right?
[-- Attachment #2: Type: text/html, Size: 2447 bytes --]
next prev parent reply other threads:[~2023-01-15 22:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 21:53 roberto.foglietta
2023-01-15 22:01 ` Roberto A. Foglietta
2023-01-15 22:31 ` Florian Bezdeka
2023-01-15 22:46 ` Roberto A. Foglietta [this message]
2023-01-17 11:53 ` Florian Bezdeka
2023-01-17 13:10 ` Roberto A. Foglietta
2023-01-25 16:38 ` Roberto A. Foglietta
2023-01-16 2:55 ` Moessbauer, Felix
2023-01-16 9:36 ` Roberto A. Foglietta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJGKYO6a-sn5tYcb+4kXvCGwxz2OsG6ScADPndAhy_q+BzcEuQ@mail.gmail.com \
--to=roberto.foglietta@gmail.com \
--cc=florian.bezdeka@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=roberto.foglietta@linuxteam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox