From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7189000421229199360 X-Received: by 2002:a05:6102:ed2:b0:3d3:d2e9:691d with SMTP id m18-20020a0561020ed200b003d3d2e9691dmr237346vst.74.1673822813508; Sun, 15 Jan 2023 14:46:53 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1f:2f91:0:b0:3b4:4e41:3c89 with SMTP id v139-20020a1f2f91000000b003b44e413c89ls1738734vkv.6.-pod-prod-gmail; Sun, 15 Jan 2023 14:46:52 -0800 (PST) X-Google-Smtp-Source: AMrXdXvUH0CNmrVPQZF0bxHfEfnLr+StaqrhwNXYptI6DSNJ9jjTSzS7hlTsVxhYTZciSB5NOBPn X-Received: by 2002:a1f:d344:0:b0:3d8:d1d6:a35c with SMTP id k65-20020a1fd344000000b003d8d1d6a35cmr21370413vkg.2.1673822812585; Sun, 15 Jan 2023 14:46:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673822812; cv=none; d=google.com; s=arc-20160816; b=xAzl2UIjKJ0zkcK8gZ2rNYEyVt4VoDuCtDEgrSGV7RKrlYaqQHamVPud8OVe9X5ISk 4OLWOddPJiWOiZU70bDwImthHssY7Bv2FWMnBtDJaXPvT+wA4JHorQY/eMSWOJEr/wcm RfH/feANjqmbtLo2sj+fK6mlKlafCAtdrvDgI1mDeZ7t+o1AuOyNlQ5VZOVp9mF6vBT2 qUtCOnXpvJ1qS8zv52JshWlW2pAjMKX/X8woWWbrLwUQ3Tt8I/kugcxf/M/In6kaCnq6 BXLPV9HT7/1eXpqhhg8Qr/0oxxX/cOg4kclxrnKXP9HbQaoM8jpDgQDLQKGspvDtCiHT zsVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=vKNzswMB1vbciN1LzrtrOyWBAai/89VNZCuX1P1iglQ=; b=XMSQ7VjH8SKyoA41agf09u3d8MnuZBf6KeUktjnIJbtW3/ObYhshf5EzeAjesasoR6 DZS7WrzPfLyP6TyoWJ9AFXY6gzD0QKDsCjIjCaWObKDhkqmHqP6dqZBUerxzg3N28tXL vN6ppui+H2nP0ITBLnDfljM2JAAm8A8Wh+SxcBBuu/gR4/3vVhZWBwZu5gcy72PsPWaj uxQk9Km9aLNP2m+YQQJnNa7NaQD7Af2Dg/RwoVjbP4HTICvJcctF8JQF/QRBMAtkKd58 FL+9wSLZpgRakmwscg1G+g2TSUdl2dA0/UbY8MWbpjM3HJTX6n5VMHJvSRzuZD0B++00 29nA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=KXvHBubn; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::f2d as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com. [2607:f8b0:4864:20::f2d]) by gmr-mx.google.com with ESMTPS id az31-20020a056130039f00b005e51a1a1ef1si2990425uab.2.2023.01.15.14.46.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Jan 2023 14:46:52 -0800 (PST) Received-SPF: pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::f2d as permitted sender) client-ip=2607:f8b0:4864:20::f2d; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=KXvHBubn; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::f2d as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-qv1-xf2d.google.com with SMTP id y8so18580162qvn.11 for ; Sun, 15 Jan 2023 14:46:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vKNzswMB1vbciN1LzrtrOyWBAai/89VNZCuX1P1iglQ=; b=KXvHBubnjcKOKo9sevjPIVWbmDIigHwDLFunZJ9vcMA5gtsDnJa1/6q1/2IZDU5ss+ AJNL9DNqAZbkrUHtVjbmjdiVwKnvgGhSTq8QkhrtDQZl8BldsUmKooRoyi916NWywNSU vQq+j744szIk1EdyOq7Izg7E1c7EzATfiKHq/7vHlwCDVXJsiAyPQTA0g25NLERZ3/L8 /OA20K14EOcm/iVVpQIdHOdM0tKLzDf4Wi/8x6QCMES9gYoqIY5KJ3848tFG16LVxAsk /FCJWip+CVW1Hb7SrvRjVOQOnvmJ6Ly2fkSiKLIh4UOEXTePhh5PM+ASLmUKWY3KdTRT 5hQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vKNzswMB1vbciN1LzrtrOyWBAai/89VNZCuX1P1iglQ=; b=cmd3FBNwZK9mB5vZopRwYqK8LDHKLOxCueC7mEp/nlaGDhz4UqkPqHUpgTsKumUEwQ pHWgfHILCPBXXYxx6Yl7NYNwHXvQfgI/gz4GROp8Nuo7GcrVuXdTelZa4H6Ozm7QOaew Zq9jATJJlr+4REgwoZi4stL+rVMDhKy/l2k82NXKMxLRIRy4minxxDRmQL9tX52tWOXY QqKfPNWjAvIXE/pTb5GWZsRAtAnfxCjoaMyYFNQeaO/tzt16aXYFsI2cIiYLFv5hFNtD p0//C/BD7t1oY0pFNxuhdUxycP+2wmyooS03NT+/EfVcdw4/JU5oALd9EgVutgy7SU+B zqFg== X-Gm-Message-State: AFqh2kqkWHZUzNRJ+ThnJLTjW89YmvEfmp41MbdzzPSx4JGNpRcUVYTc 1WRGubnngWORhF4GffDB1ffXNJtbzhxpY9kdmWfJNdL/tw== X-Received: by 2002:ad4:4dc4:0:b0:534:ad6e:447b with SMTP id cw4-20020ad44dc4000000b00534ad6e447bmr323409qvb.72.1673822812168; Sun, 15 Jan 2023 14:46:52 -0800 (PST) MIME-Version: 1.0 References: <20230115215310.732295-1-roberto.foglietta@linuxteam.org> <551831fb188675b0c6d1a879f1a8b251efce4e4a.camel@siemens.com> In-Reply-To: <551831fb188675b0c6d1a879f1a8b251efce4e4a.camel@siemens.com> From: "Roberto A. Foglietta" Date: Sun, 15 Jan 2023 23:46:16 +0100 Message-ID: Subject: Re: [PATCH v6] suggested changes for reproducibility patchset v6 To: Florian Bezdeka Cc: roberto.foglietta@linuxteam.org, isar-users@googlegroups.com Content-Type: multipart/alternative; boundary="00000000000022e5ab05f2553e5c" X-TUID: eReFg+Vv4Yvo --00000000000022e5ab05f2553e5c Content-Type: text/plain; charset="UTF-8" On Sun, 15 Jan 2023 at 23:32, Florian Bezdeka wrote: > > On Sun, 2023-01-15 at 22:53 +0100, roberto.foglietta@linuxteam.org > wrote: > > From: "Roberto A. Foglietta" > > > > suggested changes for reproducibility patchset > > > > WARNING: eval-image-1.0-r0 do_rootfs_finalize: modified timestamp (1673628837) of 3 files for image reproducibly > > List of files modified could be found here: ./build/tmp/deploy/images/debx86/files.modified_timestamps > > > > Can't follow. Patches / Commits need proper description (= commit > message). I guess you fixed a warning, but the warning itself (= list > of modified files) was inside the mentioned file, so we have to guess > what changed? > Do not worry, I will do a proper patch when your changes will be included into ilbers/next - this is just a suggestion for Felix @Felix There is no reason to show a warning of long N files but just a summary with the name of the file to check. Please forget the v6 because it got out prematurely. I just sent the v7. Keep in consideration that in my building after the image finalize, do_install_imager_deps runs and mess-up things. It is something that I need to investigate. > > > > v.6: the 1st part of the warning shows up each time the epoch is used > > while the 2nd line appears only when some files has been touched > > This allows the user to know the current situation aboat epoch. > > Version information does not belong here. See below. > > > > > Signed-off-by: Roberto A. Foglietta > > --- > > Comments like changes between versions of your patches should be > mentioned here. Not inside the commit message. > Ok, it seems weird to me but it probably is a standard that automatic software needs. Is that right? --00000000000022e5ab05f2553e5c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, 15 Jan 2023 at 23:32, Florian Bezdeka <florian.bezdeka@siemens.com>= wrote:
>
> On Sun, 2023-01-15 at 22:53 +0100, roberto.foglietta@linuxteam.org
&= gt; wrote:
> > From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>=
> >
> > suggested changes for reproducibility patchset> >
> > WARNING: eval-image-1.0-r0 do_rootfs_finalize: mod= ified timestamp (1673628837) of 3 files for image reproducibly
> >= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0List of files modified could be found he= re: ./build/tmp/deploy/images/debx86/files.modified_timestamps
> >=
>
> Can't follow. Patches / Commits need proper descriptio= n (=3D commit
> message). I guess you fixed a warning, but the warnin= g itself (=3D list
> of modified files) was inside the mentioned file= , so we have to guess
> what changed?
>

Do not worry, I = will do a proper patch when your changes will be included into ilbers/next = - this is just a suggestion for Felix

There is no re= ason to show a warning of long N files but just a summary with the name of = the file to check.
Please forget the v6 because it got out prematurely. = I just sent the v7.
Keep in consideration that in my building aft= er the image finalize,=C2=A0do_install_imager_deps runs and mess-up things.=
It is something that I need to investigate.


&g= t; >
> > v.6: the 1st part of the warning shows up each time th= e epoch is used
> > =C2=A0 =C2=A0 =C2=A0while the 2nd line appears= only when some files has been touched
> > =C2=A0 =C2=A0 =C2=A0Thi= s allows the user to know the current situation aboat epoch.
>
>= ; Version information does not belong here. See below.
>
> >=
> > Signed-off-by: Roberto A. Foglietta <roberto.foglietta@gmail.com>
> > = ---
>
> Comments like changes between versions of your patches = should be
> mentioned here. Not inside the commit message.
>
Ok, it seems weird to me but it probably is a standard that automatic = software needs. Is that right?
--00000000000022e5ab05f2553e5c--