Re: [PATCH] dpkg class sbuild allows extra arguments by vars

["Roberto A. Foglietta" <roberto.foglietta@gmail.com>]

On Wed, 25 Jan 2023 at 13:27, Uladzimir Bely <ubely@ilbers.de> wrote:
>
> In mail from Tuesday, 3 January 2023 22:58:15 +03 user Roberto A. Foglietta
> wrote:
> > Hi all,
> >
> > Sometimes it is necessary to add some extra commands or arguments to sbuild
> > but create a class into an upper layer just for this breaks the updates.
> > So, this patch allows setting extra parameters through two variables.
> >
> > Signed-off-by: Roberto A. Foglietta <roberto.foglietta@gmail.com>
> > ---
> >  meta/classes/dpkg.bbclass | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > https://github.com/ilbers/isar/commit/7e72921747aedf588af492be95fb0b91ad70f4
> > 55
>
> Can't respond on specific line in the patch due to attachment form, but it
> would be better not to modify existing lines but just add new ones, like:
>
>          --no-apt-update \
> +        ${DPKG_SBUILD_EXTRA_ARGS_PRE} \
>          --chroot-setup-commands=...
>
> It's a bit more readable.

Two variables are useless, I realised. One in the middle is the
optimal compromise. Remove the _PRE in append, it does not make sense
anymore.

> You could send v2 or I can modify it on my side while testing / merging.

I am doing, just give me the time to rebase it on the next.

Best, R-