From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7184517929381134336 X-Received: by 2002:a05:6102:30a7:b0:3d3:d12d:4065 with SMTP id y7-20020a05610230a700b003d3d12d4065mr4511427vsd.70.1674663216374; Wed, 25 Jan 2023 08:13:36 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1f:91d2:0:b0:3dd:f98f:ae7a with SMTP id t201-20020a1f91d2000000b003ddf98fae7als3407441vkd.8.-pod-prod-gmail; Wed, 25 Jan 2023 08:13:35 -0800 (PST) X-Google-Smtp-Source: AMrXdXtTNF0u9CRtLRgIGyMitzKgWubxO6Vxw2+LvUYvY85ZJBPaeRKIaBvttSGWIhoSIaUJmNXI X-Received: by 2002:a1f:4107:0:b0:3d1:f1f1:b946 with SMTP id o7-20020a1f4107000000b003d1f1f1b946mr20362134vka.6.1674663215627; Wed, 25 Jan 2023 08:13:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674663215; cv=none; d=google.com; s=arc-20160816; b=Y4qUticUOloKK/rqJz1fUQ3zlZCGyGpz6O57WatfZ8JiFptEHeGmm5DPVQfdVcjESB C2xcwLBBmPOFfRHwlCv6+ndjjWgm8yga7Jq1iP6Ib4MN2w4mFeCjDTj4X5CRrg8qkiND cycG5p3NtIovY+XtaLV0QOW3XvcWFXfbN15zvWH7b0I4N5XNRuu92A9A/xwxnW9/enQP 58ayROthJsUYq8rUtMNPIhmhuI9nw0DAnKOi+xBpKbAp8Bi3/lCOr3gBAzf01ihKmos3 OLA7/evG9aKqLevybJ1LJS5dZo400N0p4acxNJ8Dh6QZ0SiB2kTht/yT+t/RqsGXNGP7 cMEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=4V+YY0vFemCKY7eEY9kdKMxpsWRVlsjhaTRbFMviL64=; b=LBHs91sQ5M2CZauzJ9yA3bRAtJy7eJUUCELMOBJXK1+ZdONVHypjSa93F56Urx6B4E 6NHv4kkd3VmrrrTMIXkvYhpR1R6Qje7J38JJ15Kq6i2R49NGAyKIxNScN96f4gzeLZ9p 8PkEG8KFKBFylAsf6Ygkpj2XBHxi9tlhLhnr1/xi56Ln1haLW9/Vt3Eg1E6XzRGsMtQv Fqy7Bheqvz6iX4uK6a7QpoJtQC3PoW6aXmjh7PoA5upWnvilwP3XelTA5H9YinnBQr/e hbZLU+zMfn288lxt1kv9xATtS/C1dFucPMRHFgf6N3UGcHtFXPtoXUnN1jT0X88Eilku 8NAQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=NkJmAAr6; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::f30 as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com. [2607:f8b0:4864:20::f30]) by gmr-mx.google.com with ESMTPS id l22-20020a05612210d600b003e4251d7a1fsi216088vko.3.2023.01.25.08.13.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 08:13:35 -0800 (PST) Received-SPF: pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::f30 as permitted sender) client-ip=2607:f8b0:4864:20::f30; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=NkJmAAr6; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::f30 as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-qv1-xf30.google.com with SMTP id q10so14384548qvt.10 for ; Wed, 25 Jan 2023 08:13:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4V+YY0vFemCKY7eEY9kdKMxpsWRVlsjhaTRbFMviL64=; b=NkJmAAr6LZ6QvBMahrumMrwv46KQlrmxXo145tSVpmavacXoyQfMhbVKwkJy30ZsQa 65rpDYmHVTQl58s0se7m+Net/lDshNyX0FKchlPByRjfhVXOCEd3fhYrs5CctyiWL6OV oyknyqCs9ibV2GAJ0ZaqWvmiv4EeYQF6hMoqLijGDqrc7Urjy++/VUeh72pReIwo4V5L /QSUeY9rVOrSE99aIcaBPq8vsMQQp7yx+mK88YvyyICordn7ZpLPYVVxqIV0re7i+43L TvuF1Cmo7zy4MDU1WCiAgFyXYyYQ/diwhQ3iG22na7qfWczvKl6Qn1TAFtvy6m5Y3mvD Q5qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4V+YY0vFemCKY7eEY9kdKMxpsWRVlsjhaTRbFMviL64=; b=q9TM4RDgk5BgMghOA4ackPUmhiKpa0b7ovlsvf//V0JRsXlTWJ9Hh0JT8yrp/qp0oU IrfIzEFbQ+alXLdnaj8ceh+qtYDTPIxXP+ZkaylNhfUkSAbi+E5dkohhw/JQ1RWM+mS5 /rS68VLCTCv6ph5QWJ/j0OkYOMH4jlQMObdcChw1AkbvDWytCSCtWb8ltNqpZ+43BAro QzKeDUy4d6E2fZMwp1HjCnMgxlK889HuIa28rQA81i0hMHDSuaTAg42ihWEZdWVF8k2J ivraigiFru7yxAR/qNl2Ijs06RumeG5Q6J+FUqEy7HIrc0Y+H6OVQytOrXmTyN35fQjX h1QQ== X-Gm-Message-State: AFqh2kpUnkJ33b+NgVn3GHZuoi54A03yeNe2s+yb3WLWDyO+D2mtbAdF AvoVyiWiT4luG0I3SbqJBjizRiumhfm89S0gM6sWhxdQfQ== X-Received: by 2002:a05:6214:3b0a:b0:532:1f17:2ce1 with SMTP id nm10-20020a0562143b0a00b005321f172ce1mr1680840qvb.52.1674663215211; Wed, 25 Jan 2023 08:13:35 -0800 (PST) MIME-Version: 1.0 References: <2176963.hkbZ0PkbqX@hp> In-Reply-To: <2176963.hkbZ0PkbqX@hp> From: "Roberto A. Foglietta" Date: Wed, 25 Jan 2023 17:12:58 +0100 Message-ID: Subject: Re: [PATCH] dpkg class sbuild allows extra arguments by vars To: Uladzimir Bely Cc: isar-users@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-TUID: FOZErxUiHFK8 On Wed, 25 Jan 2023 at 13:27, Uladzimir Bely wrote: > > In mail from Tuesday, 3 January 2023 22:58:15 +03 user Roberto A. Foglietta > wrote: > > Hi all, > > > > Sometimes it is necessary to add some extra commands or arguments to sbuild > > but create a class into an upper layer just for this breaks the updates. > > So, this patch allows setting extra parameters through two variables. > > > > Signed-off-by: Roberto A. Foglietta > > --- > > meta/classes/dpkg.bbclass | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > https://github.com/ilbers/isar/commit/7e72921747aedf588af492be95fb0b91ad70f4 > > 55 > > Can't respond on specific line in the patch due to attachment form, but it > would be better not to modify existing lines but just add new ones, like: > > --no-apt-update \ > + ${DPKG_SBUILD_EXTRA_ARGS_PRE} \ > --chroot-setup-commands=... > > It's a bit more readable. Two variables are useless, I realised. One in the middle is the optimal compromise. Remove the _PRE in append, it does not make sense anymore. > You could send v2 or I can modify it on my side while testing / merging. I am doing, just give me the time to rebase it on the next. Best, R-