From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
To: "MOESSBAUER, FELIX JONATHAN" <felix.moessbauer@siemens.com>
Cc: "Schild, Henning" <henning.schild@siemens.com>,
"isar-users@googlegroups.com" <isar-users@googlegroups.com>,
"Schmidt, Adriaan" <adriaan.schmidt@siemens.com>,
"jan.kiszka@siemens.com" <jan.kiszka@siemens.com>
Subject: Re: [PATCH 1/1] Re-add .wic prefix to deployed bmap file
Date: Sun, 16 Oct 2022 09:26:23 +0200 [thread overview]
Message-ID: <CAJGKYO72UGoZcEUARPGoLFiNQgrh6+kJMe5hesdShYnfY=_PEw@mail.gmail.com> (raw)
In-Reply-To: <HE1PR1001MB109823DF7952A0D613BB089089269@HE1PR1001MB1098.EURPRD10.PROD.OUTLOOK.COM>
Il giorno dom 16 ott 2022 alle ore 05:58 MOESSBAUER, FELIX JONATHAN
<felix.moessbauer@siemens.com> ha scritto:
>
> > -----Original Message-----
> > From: Roberto A. Foglietta <roberto.foglietta@gmail.com>
> > Sent: Sunday, October 16, 2022 1:10 AM
> > To: Schild, Henning (T CED SES-DE) <henning.schild@siemens.com>
> > Cc: Moessbauer, Felix Jonathan (T CED INW-CN)
> > <felix.moessbauer@siemens.com>; isar-users@googlegroups.com; Schmidt,
> > Adriaan (T CED SES-DE) <adriaan.schmidt@siemens.com>; Kiszka, Jan (T CED)
> > <jan.kiszka@siemens.com>
> > Subject: Re: [PATCH 1/1] Re-add .wic prefix to deployed bmap file
> >
> > Il giorno sab 15 ott 2022 alle ore 12:50 Henning Schild
> > <henning.schild@siemens.com> ha scritto:
> > >
> > > Am Sat, 15 Oct 2022 11:37:58 +0200
> > > schrieb "Roberto A. Foglietta" <roberto.foglietta@gmail.com>:
> > >
> > > > Il giorno ven 14 ott 2022 alle ore 13:51 Felix Moessbauer
> > > > <felix.moessbauer@siemens.com> ha scritto:
> > > > >
> > > > > This patch fixes a regression introduced in edc10d9.
> > > > > The bmap corresponds to the .wic file, hence it should also
> > > > > contain the .wic part of the filename.
> > > > >
> > > >
> > > > Thanks for this patch. However, the bmap tool works even if the name
> > > > of that file is changed.
> > >
> > > It sure does. But any scripting that comes after an isar build could
> > > get confused by the name change and not find the file. Like CD not
> > > even deploying it.
> >
> > just a matter of generalisation... :-)
>
> Too much generalization might just break things.
> The bmap file is specific to a block file, like the<image> .wic one.
> There might be other imagers or deployment formats, that use a different bmap.
> An with ISARs imagetypes, you can generate multiple image formats / types in a single run.
> Each of these could - in theory - have its own bmap, hence just appending .bmap to the image filename is not sufficient.
>
Thanks for the explanation. I wait for this patch to get accepted into
the 'next' and I will update the kas.yml with the new hash.
Best regards, R-
next prev parent reply other threads:[~2022-10-16 7:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 11:51 Felix Moessbauer
2022-10-15 9:37 ` Roberto A. Foglietta
2022-10-15 10:50 ` Henning Schild
2022-10-15 17:09 ` Roberto A. Foglietta
2022-10-16 3:58 ` MOESSBAUER, FELIX JONATHAN
2022-10-16 7:26 ` Roberto A. Foglietta [this message]
2022-10-19 8:03 ` Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJGKYO72UGoZcEUARPGoLFiNQgrh6+kJMe5hesdShYnfY=_PEw@mail.gmail.com' \
--to=roberto.foglietta@gmail.com \
--cc=adriaan.schmidt@siemens.com \
--cc=felix.moessbauer@siemens.com \
--cc=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox