From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7189000421229199360 X-Received: by 2002:a05:6a00:e83:b0:56b:9ce2:891f with SMTP id bo3-20020a056a000e8300b0056b9ce2891fmr3334278pfb.43.1674664751366; Wed, 25 Jan 2023 08:39:11 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:902:e5c3:b0:192:62df:a3e7 with SMTP id u3-20020a170902e5c300b0019262dfa3e7ls19719537plf.9.-pod-prod-gmail; Wed, 25 Jan 2023 08:39:10 -0800 (PST) X-Google-Smtp-Source: AMrXdXtvdS2a6yDUz3C0OqE2bIeo67QGl77KU40j/yG0eleptZhJwR9UFDE4Z+1mJyHIQU3aeNgb X-Received: by 2002:a17:902:bb8f:b0:194:751d:978 with SMTP id m15-20020a170902bb8f00b00194751d0978mr32081369pls.61.1674664750424; Wed, 25 Jan 2023 08:39:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674664750; cv=none; d=google.com; s=arc-20160816; b=HB3DjHLgyP5NjxTP291nBV/Rvw78T9uEu6yac6OXeFD13wgYKGdo0fioqfMRg02OMa ixmsLmMCx3RbzGZ7jGL3qBbQgHIpgjl0ichqpOMCyWRhgidigXAB/Yh8rCKgu/Nd0PCX ZmJALZyKo6ijzhXNVU6kJPSm+oPMhzwufR6qSPkjS4QTCGxQ5H7J9/0qQPATlKAa1whX sihWTpJX5cjED2KQ64nK0ng98igJ5oGQgJqx4Yo+RaFmYgB5PAZeq3NZx+MIvLcGvD9n F0puCIqV/wYFFyvySNKDpEJOXZnrm/EYlEICYy9mR3DhOkazBOd4j9WprL6erxKByVfn yzFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=l1IWn0azKbmE/i3Mw2sOdz4P+vt/rL4ojapdMsyaeNk=; b=dmhTiwXP18v82ORZtRnPGZF5IKIZrwnF4bKhE4qLRqKXyjgxoYYpC/YGPDqX/AZJ+M impf5LGPsaEevWFuvEJCKYLd57oJkSzlJLT9UoWYff9IqT1A+45JZB3LEcNh7rMNRY3f 0nnNuESW/gGjlditiQxe2AKZO/QhDBXdx+NA+OKO/0wgK0n4NVjWsF3VLJ+/ffUUCMzF /jcTb3n6Vh4CXzIBcBV3m3Ftm0Rsmb2KW3FuKL2SqiCzHm6BK2fkHdaptyoo3j012UjF aS2XUxmBJkgCdw9SkqJ+6W1rUilETNeUNILPrIA8d2Blns5W/L9x1j1SFhrzBQOfYaQl p3eA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=JaV72pxU; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::729 as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com. [2607:f8b0:4864:20::729]) by gmr-mx.google.com with ESMTPS id jx10-20020a170903138a00b0018712ccd6e0si339457plb.2.2023.01.25.08.39.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 08:39:10 -0800 (PST) Received-SPF: pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::729 as permitted sender) client-ip=2607:f8b0:4864:20::729; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=JaV72pxU; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::729 as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-qk1-x729.google.com with SMTP id x26so10127450qkj.4 for ; Wed, 25 Jan 2023 08:39:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=l1IWn0azKbmE/i3Mw2sOdz4P+vt/rL4ojapdMsyaeNk=; b=JaV72pxUKleuQ4ZNZlT+xs7W9MzGMvVcQBER3Q4qjDMKSxO03DVrooflosCBTzZyLA /teg1BQLumK0sPmouU9hkte3wYQHg2PUf3Rq0M2QVqE7dpeZ19qpkSj/wKb4zZyVDCqc Y4Yxz3cbKMdoxU+4ewgwFr1BXLz20LYIq1xBz+WJwToTixeiHNfocagL6Rn1JV0vBXsR RYalwQ4dCQJ7rmd6834qhFrAwYZzt0/YLVye/3Iu6QzBvAkQ4jMkmRtwWVYfkVGLy5dz ULUqXMr2fUrpj3mOkSmJXCxMCUAi3zZNnjkeQVppXFDAsyClhm7shhzcGDjYVnkMtoq7 JR+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l1IWn0azKbmE/i3Mw2sOdz4P+vt/rL4ojapdMsyaeNk=; b=SaYnwyUWKRLNGc5+reX1Jdx6KX/74n3XLjsibTQfHy7tLFOuVfgG3r9LPR2kgFuh/t uCg/MJcGoWUS7qhWpFu55jj9SCuO87fhyNHNhxSlqRM2/WptHxcBiJwIfExDtHt9XCR4 FTfml4Igc2bwViYWOscfF6zO2KTF3Ycoav5Kdy5qRaXI84CexLrYTO0m2BCIYrJmNzyA 3z+fI7Xup6fqWo/vbdpv0VvHgT74rnubvrycm5DIRmLVa0VPjCfb7Iy2keVoRuMYI5D8 ZyQ6KiC2ePoqC2fTQPtsboYxPTXtPyXR30NdxRv0HE83AADsjZSMrV9sU02nGtZCrOJX VikA== X-Gm-Message-State: AFqh2kqxAKhG/XIfwnxcFS6W7mRy6Y3bVSNYl33LHB0zlBicQTphp67s mfoISQXejVN5aH8e1cCClEagzKaWvl7AOvFYWQ== X-Received: by 2002:a05:620a:6d3:b0:6fc:9680:fd44 with SMTP id 19-20020a05620a06d300b006fc9680fd44mr1874954qky.223.1674664749483; Wed, 25 Jan 2023 08:39:09 -0800 (PST) MIME-Version: 1.0 References: <20230115215310.732295-1-roberto.foglietta@linuxteam.org> <551831fb188675b0c6d1a879f1a8b251efce4e4a.camel@siemens.com> <27337f043bddfad8dbc2c166fe1932ed45398c47.camel@siemens.com> In-Reply-To: From: "Roberto A. Foglietta" Date: Wed, 25 Jan 2023 17:38:33 +0100 Message-ID: Subject: Re: [PATCH v6] suggested changes for reproducibility patchset v6 To: Florian Bezdeka Cc: roberto.foglietta@linuxteam.org, isar-users@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-TUID: 96vNVdRXOOs0 On Tue, 17 Jan 2023 at 14:10, Roberto A. Foglietta wrote: > > On Tue, 17 Jan 2023 at 12:53, Florian Bezdeka > wrote: > > > > On Sun, 2023-01-15 at 23:46 +0100, Roberto A. Foglietta wrote: > > > On Sun, 15 Jan 2023 at 23:32, Florian Bezdeka > > > wrote: > > > > > > Signed-off-by: Roberto A. Foglietta > > > > > --- > > > > > > > > Comments like changes between versions of your patches should be > > > > mentioned here. Not inside the commit message. > > > > > > > > > > Ok, it seems weird to me but it probably is a standard that automatic > > > software needs. Is that right? > > > > This is how "git am" works. Everything above the "---" line will go > > into the commit message (should be used for story telling), everything > > below that line and in front of the first hunk will be thrown away and > > can be used for further comments/hints for reviewers/maintainers. > > > > So, considering that I want to maintain the version revision of the > patch along with the commits, it makes perfect sense that I put them > in the description. After all, the description content is arbitrary to > some degrees. However, I can add the revision log also below the > signature in such a way that some other tools that expect to find, > they will find it. Does this sound good to you? > Put the versioning after the signature, it remains in the comment. Put the versioning after the --- after the signature is required to edit manually the patch because git format-patch does not do that. My versioning is part of the comment to the patch and it is ok to add it also below --- but I wish to have a way to do that without manually editing the patch. By the way, if the versioning is not added into the message commit, there is no way to keep track of the versioning when I do a commit-patch-commit transfer. So, I am trying to understand how to keep track of the versioning and populate a field that is lost with git am patch. The next patch arriving has been edited manually. I hope it will be fine under this point of view in the meantime my questions are pending. Best regards, R-