Re: [PATCH 0-10 of 16 v2 8/8] meta: dpkg: reorder and rename do_install to install in addtask

[Alexander Smirnov <alex.bluesman.smirnov@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

2017-08-03 14:55 GMT+03:00 Henning Schild <henning.schild@siemens.com>:

> the reordering should improve readability
> when adding a task you skip the do_ prefix
>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  meta/classes/dpkg.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> index 36e047a..ca0c5ab 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg.bbclass
> @@ -23,12 +23,12 @@ do_build() {
>      sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DIR}
>  }
>
> -do_install[stamp-extra-info] = "${MACHINE}"
>
>  # Install package to dedicated deploy directory
>  do_install() {
>      install -m 755 ${BUILDROOT}/*.deb ${DEPLOY_DIR_DEB}/
>  }
>
> -addtask do_install after do_build
> +addtask install after do_build
>  do_install[dirs] = "${DEPLOY_DIR_DEB}"
> +do_install[stamp-extra-info] = "${MACHINE}"
> --
> 2.13.0
>
>
Applied to asmirnov/next

[-- Attachment #2: Type: text/html, Size: 1571 bytes --]